| Message ID | CA+XhMqy95D8X-QvBcEfL=a-Rkgy6aJtheskkqZwQkreru+T_Wg@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi David, Your git-sendemail seems broken... Usually 0/N is for the cover letter, patches are 1/N to N/N. Also patches are sent as replies to the cover (as a thread). In your series all patches are posted as new thread... On 7/18/20 3:19 PM, David CARLIER wrote: > From 63a3c9639d708a796abd958607aa6376fc9b99f2 Mon Sep 17 00:00:00 2001 > From: David Carlier <devnexen@gmail.com> > Date: Sat, 18 Jul 2020 13:27:52 +0100 > Subject: [PATCH 1/3] configure: fix for SunOS based systems. > > local directive make the configure fails on these systems. > > Signed-off-by: David Carlier <devnexen@gmail.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index e93836aaae..5d100eba72 100755 > --- a/configure > +++ b/configure > @@ -59,7 +59,7 @@ error_exit() { > do_compiler() { > # Run the compiler, capturing its output to the log. First argument > # is compiler binary to execute. > - local compiler="$1" > + compiler="$1" > shift > if test -n "$BASH_VERSION"; then eval ' > echo >>config.log " >
Hi David, On 18/07/2020 15.19, David CARLIER wrote: > From 63a3c9639d708a796abd958607aa6376fc9b99f2 Mon Sep 17 00:00:00 2001 > From: David Carlier <devnexen@gmail.com> > Date: Sat, 18 Jul 2020 13:27:52 +0100 These headers --^ should not be part of the e-mail body (otherwise they will be part of the patch description if this patch gets picked up with "git am"). > Subject: [PATCH 1/3] configure: fix for SunOS based systems. > > local directive make the configure fails on these systems. > > Signed-off-by: David Carlier <devnexen@gmail.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index e93836aaae..5d100eba72 100755 > --- a/configure > +++ b/configure > @@ -59,7 +59,7 @@ error_exit() { > do_compiler() { > # Run the compiler, capturing its output to the log. First argument > # is compiler binary to execute. > - local compiler="$1" > + compiler="$1" > shift > if test -n "$BASH_VERSION"; then eval ' > echo >>config.log " > We're not using $compiler anywhere else outside of this function in the configure script, so I think this should be ok. Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/configure b/configure index e93836aaae..5d100eba72 100755 --- a/configure +++ b/configure @@ -59,7 +59,7 @@ error_exit() { do_compiler() { # Run the compiler, capturing its output to the log. First argument # is compiler binary to execute. - local compiler="$1" + compiler="$1" shift if test -n "$BASH_VERSION"; then eval ' echo >>config.log "