Message ID | 20200813175729.15088-6-andriy.shevchenko@linux.intel.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | None | expand |
On Thu, Aug 13, 2020 at 7:57 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Fix description of handle parameter in documentation of acpi_is_root_bridge(). > Otherwise we get the following warning: > > CHECK drivers/acpi/pci_root.c > drivers/acpi/pci_root.c:71: warning: Function parameter or member 'handle' not described in 'acpi_is_root_bridge' I'm not sure why this patch doesn't go by itself. It appears to be immediately applicable. I'll apply it next week if Bjorn doesn't object. > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > --- > drivers/acpi/pci_root.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c > index 2a6a741896de..f723679954d7 100644 > --- a/drivers/acpi/pci_root.c > +++ b/drivers/acpi/pci_root.c > @@ -62,7 +62,7 @@ static DEFINE_MUTEX(osc_lock); > > /** > * acpi_is_root_bridge - determine whether an ACPI CA node is a PCI root bridge > - * @handle - the ACPI CA node in question. > + * @handle: the ACPI CA node in question. > * > * Note: we could make this API take a struct acpi_device * instead, but > * for now, it's more convenient to operate on an acpi_handle. > -- > 2.28.0 >
On Fri, Aug 14, 2020 at 05:11:55PM +0200, Rafael J. Wysocki wrote: > On Thu, Aug 13, 2020 at 7:57 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > Fix description of handle parameter in documentation of acpi_is_root_bridge(). > > Otherwise we get the following warning: > > > > CHECK drivers/acpi/pci_root.c > > drivers/acpi/pci_root.c:71: warning: Function parameter or member 'handle' not described in 'acpi_is_root_bridge' > > I'm not sure why this patch doesn't go by itself. It appears to be > immediately applicable. Just appears when I working on the rest of the series. Can be standalone if it makes more sense. > I'll apply it next week if Bjorn doesn't object. At least fine with me, thanks! > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: linux-pci@vger.kernel.org > > --- > > drivers/acpi/pci_root.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c > > index 2a6a741896de..f723679954d7 100644 > > --- a/drivers/acpi/pci_root.c > > +++ b/drivers/acpi/pci_root.c > > @@ -62,7 +62,7 @@ static DEFINE_MUTEX(osc_lock); > > > > /** > > * acpi_is_root_bridge - determine whether an ACPI CA node is a PCI root bridge > > - * @handle - the ACPI CA node in question. > > + * @handle: the ACPI CA node in question. > > * > > * Note: we could make this API take a struct acpi_device * instead, but > > * for now, it's more convenient to operate on an acpi_handle. > > -- > > 2.28.0 > >
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c index 2a6a741896de..f723679954d7 100644 --- a/drivers/acpi/pci_root.c +++ b/drivers/acpi/pci_root.c @@ -62,7 +62,7 @@ static DEFINE_MUTEX(osc_lock); /** * acpi_is_root_bridge - determine whether an ACPI CA node is a PCI root bridge - * @handle - the ACPI CA node in question. + * @handle: the ACPI CA node in question. * * Note: we could make this API take a struct acpi_device * instead, but * for now, it's more convenient to operate on an acpi_handle.
Fix description of handle parameter in documentation of acpi_is_root_bridge(). Otherwise we get the following warning: CHECK drivers/acpi/pci_root.c drivers/acpi/pci_root.c:71: warning: Function parameter or member 'handle' not described in 'acpi_is_root_bridge' Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org --- drivers/acpi/pci_root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)