Message ID | 20200812044223.19279-4-tanmay@codeaurora.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Add support for DisplayPort driver on SnapDragon | expand |
On 12/08/2020 07:42, Tanmay Shah wrote: > From: Chandan Uddaraju <chandanu@codeaurora.org> > > Add the needed DP PLL specific files to support > display port interface on msm targets. [skipped] > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h b/drivers/gpu/drm/msm/dp/dp_pll_private.h > new file mode 100644 > index 000000000000..475ba6ed59ab > --- /dev/null > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h > @@ -0,0 +1,98 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. > + */ > + > +#ifndef __DP_PLL_10NM_H > +#define __DP_PLL_10NM_H > + > +#include "dp_pll.h" > +#include "dp_reg.h" > + > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL > + > +#define NUM_DP_CLOCKS_MAX 6 > + > +#define DP_PHY_PLL_POLL_SLEEP_US 500 > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 > + > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL > + > +struct dp_pll_vco_clk { > + struct clk_hw hw; > + unsigned long rate; /* current vco rate */ > + u64 min_rate; /* min vco rate */ > + u64 max_rate; /* max vco rate */ > + void *priv; > +}; > + > +struct dp_pll_db { This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for example, will use slightly different structure. > + struct msm_dp_pll *base; > + > + int id; > + struct platform_device *pdev; > + > + /* private clocks: */ > + bool fixed_factor_clk[NUM_DP_CLOCKS_MAX]; > + struct clk_hw *hws[NUM_DP_CLOCKS_MAX]; Then these two fields can use exact number of clocks rather than NUM_DP_CLOCKS_MAX. > + u32 num_hws; > + > + /* lane and orientation settings */ > + u8 lane_cnt; > + u8 orientation; > + > + /* COM PHY settings */ > + u32 hsclk_sel; > + u32 dec_start_mode0; > + u32 div_frac_start1_mode0; > + u32 div_frac_start2_mode0; > + u32 div_frac_start3_mode0; > + u32 integloop_gain0_mode0; > + u32 integloop_gain1_mode0; > + u32 vco_tune_map; > + u32 lock_cmp1_mode0; > + u32 lock_cmp2_mode0; > + u32 lock_cmp3_mode0; > + u32 lock_cmp_en; > + > + /* PHY vco divider */ > + u32 phy_vco_div; > + /* > + * Certain pll's needs to update the same vco rate after resume in > + * suspend/resume scenario. Cached the vco rate for such plls. > + */ > + unsigned long vco_cached_rate; > + u32 cached_cfg0; > + u32 cached_cfg1; > + u32 cached_outdiv; > + > + uint32_t index; > +}; > + > +static inline struct dp_pll_vco_clk *to_dp_vco_hw(struct clk_hw *hw) > +{ > + return container_of(hw, struct dp_pll_vco_clk, hw); > +} > + > +#define to_msm_dp_pll(vco) ((struct msm_dp_pll *)vco->priv) > + > +#define to_dp_pll_db(x) ((struct dp_pll_db *)x->priv) > + > +int dp_vco_set_rate_10nm(struct clk_hw *hw, unsigned long rate, > + unsigned long parent_rate); > +unsigned long dp_vco_recalc_rate_10nm(struct clk_hw *hw, > + unsigned long parent_rate); > +long dp_vco_round_rate_10nm(struct clk_hw *hw, unsigned long rate, > + unsigned long *parent_rate); > +int dp_vco_prepare_10nm(struct clk_hw *hw); > +void dp_vco_unprepare_10nm(struct clk_hw *hw); > + > +int msm_dp_pll_10nm_init(struct msm_dp_pll *dp_pll, int id); > +void msm_dp_pll_10nm_deinit(struct msm_dp_pll *dp_pll); These functions don't seem to be used outside of dp_pll_10nm. What about making them static?
On 2020-08-14 10:05, Dmitry Baryshkov wrote: > On 12/08/2020 07:42, Tanmay Shah wrote: >> From: Chandan Uddaraju <chandanu@codeaurora.org> >> >> Add the needed DP PLL specific files to support >> display port interface on msm targets. > > [skipped] > >> diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h >> b/drivers/gpu/drm/msm/dp/dp_pll_private.h >> new file mode 100644 >> index 000000000000..475ba6ed59ab >> --- /dev/null >> +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h >> @@ -0,0 +1,98 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) 2016-2020, The Linux Foundation. All rights >> reserved. >> + */ >> + >> +#ifndef __DP_PLL_10NM_H >> +#define __DP_PLL_10NM_H >> + >> +#include "dp_pll.h" >> +#include "dp_reg.h" >> + >> +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL >> +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL >> +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL >> +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL >> + >> +#define NUM_DP_CLOCKS_MAX 6 >> + >> +#define DP_PHY_PLL_POLL_SLEEP_US 500 >> +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 >> + >> +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL >> +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL >> +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL >> + >> +struct dp_pll_vco_clk { >> + struct clk_hw hw; >> + unsigned long rate; /* current vco rate */ >> + u64 min_rate; /* min vco rate */ >> + u64 max_rate; /* max vco rate */ >> + void *priv; >> +}; >> + >> +struct dp_pll_db { > > This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for > example, will use slightly different structure. > Sure, it sounds good. I will give it try. Thanks! >> + struct msm_dp_pll *base; >> + >> + int id; >> + struct platform_device *pdev; >> + >> + /* private clocks: */ >> + bool fixed_factor_clk[NUM_DP_CLOCKS_MAX]; >> + struct clk_hw *hws[NUM_DP_CLOCKS_MAX]; > > Then these two fields can use exact number of clocks rather than > NUM_DP_CLOCKS_MAX. > I didn't get this. I think NUM_DP_CLOCKS_MAX is doing same? >> + u32 num_hws; >> + >> + /* lane and orientation settings */ >> + u8 lane_cnt; >> + u8 orientation; >> + >> + /* COM PHY settings */ >> + u32 hsclk_sel; >> + u32 dec_start_mode0; >> + u32 div_frac_start1_mode0; >> + u32 div_frac_start2_mode0; >> + u32 div_frac_start3_mode0; >> + u32 integloop_gain0_mode0; >> + u32 integloop_gain1_mode0; >> + u32 vco_tune_map; >> + u32 lock_cmp1_mode0; >> + u32 lock_cmp2_mode0; >> + u32 lock_cmp3_mode0; >> + u32 lock_cmp_en; >> + >> + /* PHY vco divider */ >> + u32 phy_vco_div; >> + /* >> + * Certain pll's needs to update the same vco rate after resume >> in >> + * suspend/resume scenario. Cached the vco rate for such plls. >> + */ >> + unsigned long vco_cached_rate; >> + u32 cached_cfg0; >> + u32 cached_cfg1; >> + u32 cached_outdiv; >> + >> + uint32_t index; >> +}; >> + >> +static inline struct dp_pll_vco_clk *to_dp_vco_hw(struct clk_hw *hw) >> +{ >> + return container_of(hw, struct dp_pll_vco_clk, hw); >> +} >> + >> +#define to_msm_dp_pll(vco) ((struct msm_dp_pll *)vco->priv) >> + >> +#define to_dp_pll_db(x) ((struct dp_pll_db *)x->priv) >> + >> +int dp_vco_set_rate_10nm(struct clk_hw *hw, unsigned long rate, >> + unsigned long parent_rate); >> +unsigned long dp_vco_recalc_rate_10nm(struct clk_hw *hw, >> + unsigned long parent_rate); >> +long dp_vco_round_rate_10nm(struct clk_hw *hw, unsigned long rate, >> + unsigned long *parent_rate); >> +int dp_vco_prepare_10nm(struct clk_hw *hw); >> +void dp_vco_unprepare_10nm(struct clk_hw *hw); >> + >> +int msm_dp_pll_10nm_init(struct msm_dp_pll *dp_pll, int id); >> +void msm_dp_pll_10nm_deinit(struct msm_dp_pll *dp_pll); > > These functions don't seem to be used outside of dp_pll_10nm. What > about making them static? I can't declare static to "init" and "deinit" as they are exported to dp_pll.c. Rest of them I can move to dp_pll_10nm and then define static.
On 15/08/2020 02:22, Tanmay Shah wrote: > On 2020-08-14 10:05, Dmitry Baryshkov wrote: >> On 12/08/2020 07:42, Tanmay Shah wrote: >>> From: Chandan Uddaraju <chandanu@codeaurora.org> >>> >>> Add the needed DP PLL specific files to support >>> display port interface on msm targets. >> >> [skipped] >> >>> diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h >>> b/drivers/gpu/drm/msm/dp/dp_pll_private.h >>> new file mode 100644 >>> index 000000000000..475ba6ed59ab >>> --- /dev/null >>> +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h >>> @@ -0,0 +1,98 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +/* >>> + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. >>> + */ >>> + >>> +#ifndef __DP_PLL_10NM_H >>> +#define __DP_PLL_10NM_H >>> + >>> +#include "dp_pll.h" >>> +#include "dp_reg.h" >>> + >>> +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL >>> +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL >>> +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL >>> +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL >>> + >>> +#define NUM_DP_CLOCKS_MAX 6 >>> + >>> +#define DP_PHY_PLL_POLL_SLEEP_US 500 >>> +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 >>> + >>> +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL >>> +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL >>> +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL >>> + >>> +struct dp_pll_vco_clk { >>> + struct clk_hw hw; >>> + unsigned long rate; /* current vco rate */ >>> + u64 min_rate; /* min vco rate */ >>> + u64 max_rate; /* max vco rate */ >>> + void *priv; >>> +}; >>> + >>> +struct dp_pll_db { >> >> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for >> example, will use slightly different structure. >> > > Sure, it sounds good. I will give it try. Thanks! > >>> + struct msm_dp_pll *base; >>> + >>> + int id; >>> + struct platform_device *pdev; >>> + >>> + /* private clocks: */ >>> + bool fixed_factor_clk[NUM_DP_CLOCKS_MAX]; >>> + struct clk_hw *hws[NUM_DP_CLOCKS_MAX]; >> >> Then these two fields can use exact number of clocks rather than >> NUM_DP_CLOCKS_MAX. >> > > I didn't get this. I think NUM_DP_CLOCKS_MAX is doing same? Not exactly. We'd need fixed_factor_clk[4] for 10nm rather than 6. It's not that important, just a small nitpick. >>> + u32 num_hws; >>> + >>> + /* lane and orientation settings */ >>> + u8 lane_cnt; >>> + u8 orientation; >>> + >>> + /* COM PHY settings */ >>> + u32 hsclk_sel; >>> + u32 dec_start_mode0; >>> + u32 div_frac_start1_mode0; >>> + u32 div_frac_start2_mode0; >>> + u32 div_frac_start3_mode0; >>> + u32 integloop_gain0_mode0; >>> + u32 integloop_gain1_mode0; >>> + u32 vco_tune_map; >>> + u32 lock_cmp1_mode0; >>> + u32 lock_cmp2_mode0; >>> + u32 lock_cmp3_mode0; >>> + u32 lock_cmp_en; >>> + >>> + /* PHY vco divider */ >>> + u32 phy_vco_div; >>> + /* >>> + * Certain pll's needs to update the same vco rate after resume in >>> + * suspend/resume scenario. Cached the vco rate for such plls. >>> + */ >>> + unsigned long vco_cached_rate; >>> + u32 cached_cfg0; >>> + u32 cached_cfg1; >>> + u32 cached_outdiv; >>> + >>> + uint32_t index; >>> +}; >>> + >>> +static inline struct dp_pll_vco_clk *to_dp_vco_hw(struct clk_hw *hw) >>> +{ >>> + return container_of(hw, struct dp_pll_vco_clk, hw); >>> +} >>> + >>> +#define to_msm_dp_pll(vco) ((struct msm_dp_pll *)vco->priv) >>> + >>> +#define to_dp_pll_db(x) ((struct dp_pll_db *)x->priv) >>> + >>> +int dp_vco_set_rate_10nm(struct clk_hw *hw, unsigned long rate, >>> + unsigned long parent_rate); >>> +unsigned long dp_vco_recalc_rate_10nm(struct clk_hw *hw, >>> + unsigned long parent_rate); >>> +long dp_vco_round_rate_10nm(struct clk_hw *hw, unsigned long rate, >>> + unsigned long *parent_rate); >>> +int dp_vco_prepare_10nm(struct clk_hw *hw); >>> +void dp_vco_unprepare_10nm(struct clk_hw *hw); >>> + >>> +int msm_dp_pll_10nm_init(struct msm_dp_pll *dp_pll, int id); >>> +void msm_dp_pll_10nm_deinit(struct msm_dp_pll *dp_pll); >> >> These functions don't seem to be used outside of dp_pll_10nm. What >> about making them static? > > I can't declare static to "init" and "deinit" as they are exported to > dp_pll.c. > Rest of them I can move to dp_pll_10nm and then define static. Please exuse me for not being exact enough. Of course I meant dp_vco_FOO_10nm() functions, not init/exit. BTW: as I'm looking onto 7nm dp pll, which naming would you prefer? We can have separate DP_PLL_10nm/DP_PLL_7nm namespaces (as DSI PLLs do) or I can override only a set of constants (like downstream driver does).
On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > > On 12/08/2020 07:42, Tanmay Shah wrote: > > From: Chandan Uddaraju <chandanu@codeaurora.org> > > > > Add the needed DP PLL specific files to support > > display port interface on msm targets. > > [skipped] > > > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h > b/drivers/gpu/drm/msm/dp/dp_pll_private.h > > new file mode 100644 > > index 000000000000..475ba6ed59ab > > --- /dev/null > > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h > > @@ -0,0 +1,98 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. > > + */ > > + > > +#ifndef __DP_PLL_10NM_H > > +#define __DP_PLL_10NM_H > > + > > +#include "dp_pll.h" > > +#include "dp_reg.h" > > + > > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL > > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL > > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL > > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL > > + > > +#define NUM_DP_CLOCKS_MAX 6 > > + > > +#define DP_PHY_PLL_POLL_SLEEP_US 500 > > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 > > + > > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL > > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL > > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL > > + > > +struct dp_pll_vco_clk { > > + struct clk_hw hw; > > + unsigned long rate; /* current vco rate */ > > + u64 min_rate; /* min vco rate */ > > + u64 max_rate; /* max vco rate */ > > + void *priv; > > +}; > > + > > +struct dp_pll_db { > > This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for > example, will use slightly different structure. Note that sboyd has a WIP series to move all of the pll code out to a phy driver. If there is work already happening on 7nm support, it might be better to go with the separate phy driver approach? I'm still a bit undecided about whether to land the dp code initially with the pll stuff in drm, and then continue refactoring to move to separate phy driver upstream, or to strip out the pll code from the beginning. If you/someone is working on 7nm support, then feedback about which approach is easier is welcome. https://lore.kernel.org/dri-devel/20200611091919.108018-1-swboyd@chromium.org/ BR, -R
On 8/15/20 4:20 PM, Rob Clark wrote: > On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> >> On 12/08/2020 07:42, Tanmay Shah wrote: >> > From: Chandan Uddaraju <chandanu@codeaurora.org> >> > >> > Add the needed DP PLL specific files to support >> > display port interface on msm targets. >> >> [skipped] >> >> > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h >> b/drivers/gpu/drm/msm/dp/dp_pll_private.h >> > new file mode 100644 >> > index 000000000000..475ba6ed59ab >> > --- /dev/null >> > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h >> > @@ -0,0 +1,98 @@ >> > +/* SPDX-License-Identifier: GPL-2.0-only */ >> > +/* >> > + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. >> > + */ >> > + >> > +#ifndef __DP_PLL_10NM_H >> > +#define __DP_PLL_10NM_H >> > + >> > +#include "dp_pll.h" >> > +#include "dp_reg.h" >> > + >> > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL >> > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL >> > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL >> > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL >> > + >> > +#define NUM_DP_CLOCKS_MAX 6 >> > + >> > +#define DP_PHY_PLL_POLL_SLEEP_US 500 >> > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 >> > + >> > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL >> > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL >> > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL >> > + >> > +struct dp_pll_vco_clk { >> > + struct clk_hw hw; >> > + unsigned long rate; /* current vco rate */ >> > + u64 min_rate; /* min vco rate */ >> > + u64 max_rate; /* max vco rate */ >> > + void *priv; >> > +}; >> > + >> > +struct dp_pll_db { >> >> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for >> example, will use slightly different structure. > > Note that sboyd has a WIP series to move all of the pll code out to a > phy driver. If there is work already happening on 7nm support, it > might be better to go with the separate phy driver approach? I'm > still a bit undecided about whether to land the dp code initially with > the pll stuff in drm, and then continue refactoring to move to > separate phy driver upstream, or to strip out the pll code from the > beginning. If you/someone is working on 7nm support, then feedback > about which approach is easier is welcome. > > https://lore.kernel.org/dri-devel/20200611091919.108018-1-swboyd@chromium.org/ > I have a sm8150/sm8250 (7nm) upstream kernel stack with DP enabled, and I have done something similar, with the PLL driver in the QMP phy, although not based on sboyd's series (along with some typec changes to negotiate the DP alt mode and get HPD events, etc.). I don't think having PLL in drm/msm makes sense, the drm/msm DP driver shouldn't need to be aware of the DP PLL/PHY driver, it only needs to set the link/pixel clock rates which are in dispcc (and those then have the PLL clocks as a parent). FYI, since it sounds you are considering landing this: it is completely broken, for example: - ioremap()'s to #define'd addresses in the PLL driver - main DP driver reading/writing to registers in the PHY region, but getting the base address from devicetree was removed since earlier revisions, so it just fails completely. Look at usb3_dp_com (for example), which in dp_catalog_ctrl_usb_reset() would be used to overwrite registers already being driven by the qmp phy driver - but now the usb3_dp_com.base is never initialized. -Jonathan > BR, > -R > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno >
On Sat, Aug 15, 2020 at 2:21 PM Jonathan Marek <jonathan@marek.ca> wrote: > > On 8/15/20 4:20 PM, Rob Clark wrote: > > On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > >> > >> > >> On 12/08/2020 07:42, Tanmay Shah wrote: > >> > From: Chandan Uddaraju <chandanu@codeaurora.org> > >> > > >> > Add the needed DP PLL specific files to support > >> > display port interface on msm targets. > >> > >> [skipped] > >> > >> > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h > >> b/drivers/gpu/drm/msm/dp/dp_pll_private.h > >> > new file mode 100644 > >> > index 000000000000..475ba6ed59ab > >> > --- /dev/null > >> > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h > >> > @@ -0,0 +1,98 @@ > >> > +/* SPDX-License-Identifier: GPL-2.0-only */ > >> > +/* > >> > + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. > >> > + */ > >> > + > >> > +#ifndef __DP_PLL_10NM_H > >> > +#define __DP_PLL_10NM_H > >> > + > >> > +#include "dp_pll.h" > >> > +#include "dp_reg.h" > >> > + > >> > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL > >> > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL > >> > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL > >> > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL > >> > + > >> > +#define NUM_DP_CLOCKS_MAX 6 > >> > + > >> > +#define DP_PHY_PLL_POLL_SLEEP_US 500 > >> > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 > >> > + > >> > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL > >> > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL > >> > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL > >> > + > >> > +struct dp_pll_vco_clk { > >> > + struct clk_hw hw; > >> > + unsigned long rate; /* current vco rate */ > >> > + u64 min_rate; /* min vco rate */ > >> > + u64 max_rate; /* max vco rate */ > >> > + void *priv; > >> > +}; > >> > + > >> > +struct dp_pll_db { > >> > >> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for > >> example, will use slightly different structure. > > > > Note that sboyd has a WIP series to move all of the pll code out to a > > phy driver. If there is work already happening on 7nm support, it > > might be better to go with the separate phy driver approach? I'm > > still a bit undecided about whether to land the dp code initially with > > the pll stuff in drm, and then continue refactoring to move to > > separate phy driver upstream, or to strip out the pll code from the > > beginning. If you/someone is working on 7nm support, then feedback > > about which approach is easier is welcome. > > > > https://lore.kernel.org/dri-devel/20200611091919.108018-1-swboyd@chromium.org/ > > > > I have a sm8150/sm8250 (7nm) upstream kernel stack with DP enabled, and > I have done something similar, with the PLL driver in the QMP phy, > although not based on sboyd's series (along with some typec changes to > negotiate the DP alt mode and get HPD events, etc.). I don't think > having PLL in drm/msm makes sense, the drm/msm DP driver shouldn't need > to be aware of the DP PLL/PHY driver, it only needs to set the > link/pixel clock rates which are in dispcc (and those then have the PLL > clocks as a parent). yeah, in the dp case, having phy split out makes a ton of sense.. it would maybe be a nice cleanup in other cases (dsi, hdmi) but the combination of usb+dp makes burying this in drm not so great.. It would be good if you could work w/ sboyd on this.. based on what I've seen on previous gens, it is probably a different phy driver for 7nm vs 10nm, but I think where we want to end up upstream is with phy split out of drm. > FYI, since it sounds you are considering landing this: it is completely > broken, for example: > - ioremap()'s to #define'd addresses in the PLL driver > - main DP driver reading/writing to registers in the PHY region, but > getting the base address from devicetree was removed since earlier > revisions, so it just fails completely. Look at usb3_dp_com (for > example), which in dp_catalog_ctrl_usb_reset() would be used to > overwrite registers already being driven by the qmp phy driver - but now > the usb3_dp_com.base is never initialized. Yeah, the idea to land dp isn't that it is perfect (or even not broken), so much as having something upstream gives a common base for others to work against.. maybe we should make the dp parts 'depends on STAGING'? I could keep a separate msm-next-dp branch that I rebase, to give a common point for folks working dp support for various different gens to coordinate work on.. that kinda sounds like a bunch of extra work for me, so might as well land what we have somehow and work together from there ;-) But it does sound like you are making the case for including the patch to drop the pll stuff and use phy framework as part of what initially goes upstream. BR, -R > > -Jonathan > > > BR, > > -R > > _______________________________________________ > > Freedreno mailing list > > Freedreno@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/freedreno > >
On 2020-08-15 04:45, Dmitry Baryshkov wrote: > On 15/08/2020 02:22, Tanmay Shah wrote: >> On 2020-08-14 10:05, Dmitry Baryshkov wrote: >>> On 12/08/2020 07:42, Tanmay Shah wrote: >>>> From: Chandan Uddaraju <chandanu@codeaurora.org> >>>> >>>> Add the needed DP PLL specific files to support >>>> display port interface on msm targets. >>> >>> [skipped] >>> >>>> diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h >>>> b/drivers/gpu/drm/msm/dp/dp_pll_private.h >>>> new file mode 100644 >>>> index 000000000000..475ba6ed59ab >>>> --- /dev/null >>>> +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h >>>> @@ -0,0 +1,98 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>>> +/* >>>> + * Copyright (c) 2016-2020, The Linux Foundation. All rights >>>> reserved. >>>> + */ >>>> + >>>> +#ifndef __DP_PLL_10NM_H >>>> +#define __DP_PLL_10NM_H >>>> + >>>> +#include "dp_pll.h" >>>> +#include "dp_reg.h" >>>> + >>>> +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL >>>> +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL >>>> +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL >>>> +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL >>>> + >>>> +#define NUM_DP_CLOCKS_MAX 6 >>>> + >>>> +#define DP_PHY_PLL_POLL_SLEEP_US 500 >>>> +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 >>>> + >>>> +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL >>>> +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL >>>> +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL >>>> + >>>> +struct dp_pll_vco_clk { >>>> + struct clk_hw hw; >>>> + unsigned long rate; /* current vco rate */ >>>> + u64 min_rate; /* min vco rate */ >>>> + u64 max_rate; /* max vco rate */ >>>> + void *priv; >>>> +}; >>>> + >>>> +struct dp_pll_db { >>> >>> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for >>> example, will use slightly different structure. >>> >> >> Sure, it sounds good. I will give it try. Thanks! >> >>>> + struct msm_dp_pll *base; >>>> + >>>> + int id; >>>> + struct platform_device *pdev; >>>> + >>>> + /* private clocks: */ >>>> + bool fixed_factor_clk[NUM_DP_CLOCKS_MAX]; >>>> + struct clk_hw *hws[NUM_DP_CLOCKS_MAX]; >>> >>> Then these two fields can use exact number of clocks rather than >>> NUM_DP_CLOCKS_MAX. >>> >> >> I didn't get this. I think NUM_DP_CLOCKS_MAX is doing same? > > Not exactly. We'd need fixed_factor_clk[4] for 10nm rather than 6. > It's not that important, just a small nitpick. > > >>>> + u32 num_hws; >>>> + >>>> + /* lane and orientation settings */ >>>> + u8 lane_cnt; >>>> + u8 orientation; >>>> + >>>> + /* COM PHY settings */ >>>> + u32 hsclk_sel; >>>> + u32 dec_start_mode0; >>>> + u32 div_frac_start1_mode0; >>>> + u32 div_frac_start2_mode0; >>>> + u32 div_frac_start3_mode0; >>>> + u32 integloop_gain0_mode0; >>>> + u32 integloop_gain1_mode0; >>>> + u32 vco_tune_map; >>>> + u32 lock_cmp1_mode0; >>>> + u32 lock_cmp2_mode0; >>>> + u32 lock_cmp3_mode0; >>>> + u32 lock_cmp_en; >>>> + >>>> + /* PHY vco divider */ >>>> + u32 phy_vco_div; >>>> + /* >>>> + * Certain pll's needs to update the same vco rate after resume >>>> in >>>> + * suspend/resume scenario. Cached the vco rate for such plls. >>>> + */ >>>> + unsigned long vco_cached_rate; >>>> + u32 cached_cfg0; >>>> + u32 cached_cfg1; >>>> + u32 cached_outdiv; >>>> + >>>> + uint32_t index; >>>> +}; >>>> + >>>> +static inline struct dp_pll_vco_clk *to_dp_vco_hw(struct clk_hw >>>> *hw) >>>> +{ >>>> + return container_of(hw, struct dp_pll_vco_clk, hw); >>>> +} >>>> + >>>> +#define to_msm_dp_pll(vco) ((struct msm_dp_pll *)vco->priv) >>>> + >>>> +#define to_dp_pll_db(x) ((struct dp_pll_db *)x->priv) >>>> + >>>> +int dp_vco_set_rate_10nm(struct clk_hw *hw, unsigned long rate, >>>> + unsigned long parent_rate); >>>> +unsigned long dp_vco_recalc_rate_10nm(struct clk_hw *hw, >>>> + unsigned long parent_rate); >>>> +long dp_vco_round_rate_10nm(struct clk_hw *hw, unsigned long rate, >>>> + unsigned long *parent_rate); >>>> +int dp_vco_prepare_10nm(struct clk_hw *hw); >>>> +void dp_vco_unprepare_10nm(struct clk_hw *hw); >>>> + >>>> +int msm_dp_pll_10nm_init(struct msm_dp_pll *dp_pll, int id); >>>> +void msm_dp_pll_10nm_deinit(struct msm_dp_pll *dp_pll); >>> >>> These functions don't seem to be used outside of dp_pll_10nm. What >>> about making them static? >> >> I can't declare static to "init" and "deinit" as they are exported to >> dp_pll.c. >> Rest of them I can move to dp_pll_10nm and then define static. > > Please exuse me for not being exact enough. Of course I meant > dp_vco_FOO_10nm() functions, not init/exit. > Ok got it. Sorry I didn't mean to nitpick here. > BTW: as I'm looking onto 7nm dp pll, which naming would you prefer? > I didn't get this. Did you mean naming convention of functions and structure between 7nm and 10 nm? Could you point me where 7nm dp pll code is posted? > We can have separate DP_PLL_10nm/DP_PLL_7nm namespaces (as DSI PLLs > do) or I can override only a set of constants (like downstream driver > does). Having separate namespace sounds good.
On 2020-08-15 15:45, Rob Clark wrote: > On Sat, Aug 15, 2020 at 2:21 PM Jonathan Marek <jonathan@marek.ca> > wrote: >> >> On 8/15/20 4:20 PM, Rob Clark wrote: >> > On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov >> > <dmitry.baryshkov@linaro.org> wrote: >> >> >> >> >> >> On 12/08/2020 07:42, Tanmay Shah wrote: >> >> > From: Chandan Uddaraju <chandanu@codeaurora.org> >> >> > >> >> > Add the needed DP PLL specific files to support >> >> > display port interface on msm targets. >> >> >> >> [skipped] >> >> >> >> > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h >> >> b/drivers/gpu/drm/msm/dp/dp_pll_private.h >> >> > new file mode 100644 >> >> > index 000000000000..475ba6ed59ab >> >> > --- /dev/null >> >> > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h >> >> > @@ -0,0 +1,98 @@ >> >> > +/* SPDX-License-Identifier: GPL-2.0-only */ >> >> > +/* >> >> > + * Copyright (c) 2016-2020, The Linux Foundation. All rights > reserved. >> >> > + */ >> >> > + >> >> > +#ifndef __DP_PLL_10NM_H >> >> > +#define __DP_PLL_10NM_H >> >> > + >> >> > +#include "dp_pll.h" >> >> > +#include "dp_reg.h" >> >> > + >> >> > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL >> >> > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL >> >> > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL >> >> > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL >> >> > + >> >> > +#define NUM_DP_CLOCKS_MAX 6 >> >> > + >> >> > +#define DP_PHY_PLL_POLL_SLEEP_US 500 >> >> > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 >> >> > + >> >> > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL >> >> > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL >> >> > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL >> >> > + >> >> > +struct dp_pll_vco_clk { >> >> > + struct clk_hw hw; >> >> > + unsigned long rate; /* current vco rate */ >> >> > + u64 min_rate; /* min vco rate */ >> >> > + u64 max_rate; /* max vco rate */ >> >> > + void *priv; >> >> > +}; >> >> > + >> >> > +struct dp_pll_db { >> >> >> >> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for >> >> example, will use slightly different structure. >> > >> > Note that sboyd has a WIP series to move all of the pll code out to a >> > phy driver. If there is work already happening on 7nm support, it >> > might be better to go with the separate phy driver approach? I'm >> > still a bit undecided about whether to land the dp code initially with >> > the pll stuff in drm, and then continue refactoring to move to >> > separate phy driver upstream, or to strip out the pll code from the >> > beginning. If you/someone is working on 7nm support, then feedback >> > about which approach is easier is welcome. >> > >> > > https://lore.kernel.org/dri-devel/20200611091919.108018-1-swboyd@chromium. > org/ >> > >> >> I have a sm8150/sm8250 (7nm) upstream kernel stack with DP enabled, >> and >> I have done something similar, with the PLL driver in the QMP phy, >> although not based on sboyd's series (along with some typec changes to >> negotiate the DP alt mode and get HPD events, etc.). I don't think >> having PLL in drm/msm makes sense, the drm/msm DP driver shouldn't >> need >> to be aware of the DP PLL/PHY driver, it only needs to set the >> link/pixel clock rates which are in dispcc (and those then have the >> PLL >> clocks as a parent). > > yeah, in the dp case, having phy split out makes a ton of sense.. it > would maybe be a nice cleanup in other cases (dsi, hdmi) but the > combination of usb+dp makes burying this in drm not so great.. > > It would be good if you could work w/ sboyd on this.. based on what > I've seen on previous gens, it is probably a different phy driver for > 7nm vs 10nm, but I think where we want to end up upstream is with phy > split out of drm. > >> FYI, since it sounds you are considering landing this: it is >> completely >> broken, for example: >> - ioremap()'s to #define'd addresses in the PLL driver >> - main DP driver reading/writing to registers in the PHY region, but >> getting the base address from devicetree was removed since earlier >> revisions, so it just fails completely. Look at usb3_dp_com (for >> example), which in dp_catalog_ctrl_usb_reset() would be used to >> overwrite registers already being driven by the qmp phy driver - but >> now >> the usb3_dp_com.base is never initialized. > > Yeah, the idea to land dp isn't that it is perfect (or even not > broken), so much as having something upstream gives a common base for > others to work against.. maybe we should make the dp parts 'depends on > STAGING'? > > I could keep a separate msm-next-dp branch that I rebase, to give a > common point for folks working dp support for various different gens > to coordinate work on.. that kinda sounds like a bunch of extra work > for me, so might as well land what we have somehow and work together > from there ;-) > > But it does sound like you are making the case for including the patch > to drop the pll stuff and use phy framework as part of what initially > goes upstream. > I agree with Rob on landing what we have in DP driver. Of course, by addressing any outstanding comments. That would help in setting base functional code for DisplayPort Bring-up. Other features such as PHY compliance and DP audio are dependent on these changes. We don't want to keep PLL code in drm/msm directory and so we have removed bindings of PLL from DP node. Once base driver is merged, we can rebase Stephen's QMP PHY changes and merge them. Stephen's changes are removing PLL code from drm/msm directory already. Other dependent patches for DisplayPort driver on msm are posted here: https://lore.kernel.org/dri-devel/20200810232315.18707-1-khsieh@codeaurora.org/ https://lore.kernel.org/dri-devel/20200813015439.4174-2-abhinavk@codeaurora.org/ > BR, > -R > >> >> -Jonathan >> >> > BR, >> > -R >> > _______________________________________________ >> > Freedreno mailing list >> > Freedreno@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/freedreno >> > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 16/08/2020 01:45, Rob Clark wrote: > On Sat, Aug 15, 2020 at 2:21 PM Jonathan Marek <jonathan@marek.ca> wrote: >> >> On 8/15/20 4:20 PM, Rob Clark wrote: >>> On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov >>> <dmitry.baryshkov@linaro.org> wrote: >>>> >>>> >>>> On 12/08/2020 07:42, Tanmay Shah wrote: >>>> > From: Chandan Uddaraju <chandanu@codeaurora.org> >>>> > >>>> > Add the needed DP PLL specific files to support >>>> > display port interface on msm targets. >>>> >>>> [skipped] >>>> >>>> > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h >>>> b/drivers/gpu/drm/msm/dp/dp_pll_private.h >>>> > new file mode 100644 >>>> > index 000000000000..475ba6ed59ab >>>> > --- /dev/null >>>> > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h >>>> > @@ -0,0 +1,98 @@ >>>> > +/* SPDX-License-Identifier: GPL-2.0-only */ >>>> > +/* >>>> > + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. >>>> > + */ >>>> > + >>>> > +#ifndef __DP_PLL_10NM_H >>>> > +#define __DP_PLL_10NM_H >>>> > + >>>> > +#include "dp_pll.h" >>>> > +#include "dp_reg.h" >>>> > + >>>> > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL >>>> > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL >>>> > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL >>>> > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL >>>> > + >>>> > +#define NUM_DP_CLOCKS_MAX 6 >>>> > + >>>> > +#define DP_PHY_PLL_POLL_SLEEP_US 500 >>>> > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 >>>> > + >>>> > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL >>>> > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL >>>> > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL >>>> > + >>>> > +struct dp_pll_vco_clk { >>>> > + struct clk_hw hw; >>>> > + unsigned long rate; /* current vco rate */ >>>> > + u64 min_rate; /* min vco rate */ >>>> > + u64 max_rate; /* max vco rate */ >>>> > + void *priv; >>>> > +}; >>>> > + >>>> > +struct dp_pll_db { >>>> >>>> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for >>>> example, will use slightly different structure. >>> >>> Note that sboyd has a WIP series to move all of the pll code out to a >>> phy driver. If there is work already happening on 7nm support, it >>> might be better to go with the separate phy driver approach? I'm >>> still a bit undecided about whether to land the dp code initially with >>> the pll stuff in drm, and then continue refactoring to move to >>> separate phy driver upstream, or to strip out the pll code from the >>> beginning. If you/someone is working on 7nm support, then feedback >>> about which approach is easier is welcome. >>> >>> https://lore.kernel.org/dri-devel/20200611091919.108018-1-swboyd@chromium.org/ >>> >> >> I have a sm8150/sm8250 (7nm) upstream kernel stack with DP enabled, and >> I have done something similar, with the PLL driver in the QMP phy, >> although not based on sboyd's series (along with some typec changes to >> negotiate the DP alt mode and get HPD events, etc.). I don't think >> having PLL in drm/msm makes sense, the drm/msm DP driver shouldn't need >> to be aware of the DP PLL/PHY driver, it only needs to set the >> link/pixel clock rates which are in dispcc (and those then have the PLL >> clocks as a parent). > > yeah, in the dp case, having phy split out makes a ton of sense.. it > would maybe be a nice cleanup in other cases (dsi, hdmi) but the > combination of usb+dp makes burying this in drm not so great.. > > It would be good if you could work w/ sboyd on this.. based on what > I've seen on previous gens, it is probably a different phy driver for > 7nm vs 10nm, but I think where we want to end up upstream is with phy > split out of drm. 7nm differs in registers programming, so it would end up with a separate set of tables in qmp phy driver. There is also a 14nm version of dp phy, but I don't know if it usable in any actual hardware design.
On Mon, Aug 17, 2020 at 1:32 PM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On 16/08/2020 01:45, Rob Clark wrote: > > On Sat, Aug 15, 2020 at 2:21 PM Jonathan Marek <jonathan@marek.ca> wrote: > >> > >> On 8/15/20 4:20 PM, Rob Clark wrote: > >>> On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov > >>> <dmitry.baryshkov@linaro.org> wrote: > >>>> > >>>> > >>>> On 12/08/2020 07:42, Tanmay Shah wrote: > >>>> > From: Chandan Uddaraju <chandanu@codeaurora.org> > >>>> > > >>>> > Add the needed DP PLL specific files to support > >>>> > display port interface on msm targets. > >>>> > >>>> [skipped] > >>>> > >>>> > diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h > >>>> b/drivers/gpu/drm/msm/dp/dp_pll_private.h > >>>> > new file mode 100644 > >>>> > index 000000000000..475ba6ed59ab > >>>> > --- /dev/null > >>>> > +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h > >>>> > @@ -0,0 +1,98 @@ > >>>> > +/* SPDX-License-Identifier: GPL-2.0-only */ > >>>> > +/* > >>>> > + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. > >>>> > + */ > >>>> > + > >>>> > +#ifndef __DP_PLL_10NM_H > >>>> > +#define __DP_PLL_10NM_H > >>>> > + > >>>> > +#include "dp_pll.h" > >>>> > +#include "dp_reg.h" > >>>> > + > >>>> > +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL > >>>> > +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL > >>>> > +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL > >>>> > +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL > >>>> > + > >>>> > +#define NUM_DP_CLOCKS_MAX 6 > >>>> > + > >>>> > +#define DP_PHY_PLL_POLL_SLEEP_US 500 > >>>> > +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 > >>>> > + > >>>> > +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL > >>>> > +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL > >>>> > +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL > >>>> > + > >>>> > +struct dp_pll_vco_clk { > >>>> > + struct clk_hw hw; > >>>> > + unsigned long rate; /* current vco rate */ > >>>> > + u64 min_rate; /* min vco rate */ > >>>> > + u64 max_rate; /* max vco rate */ > >>>> > + void *priv; > >>>> > +}; > >>>> > + > >>>> > +struct dp_pll_db { > >>>> > >>>> This struct should probably go into dp_pll_10nm.c. dp_pll_7nm.c, for > >>>> example, will use slightly different structure. > >>> > >>> Note that sboyd has a WIP series to move all of the pll code out to a > >>> phy driver. If there is work already happening on 7nm support, it > >>> might be better to go with the separate phy driver approach? I'm > >>> still a bit undecided about whether to land the dp code initially with > >>> the pll stuff in drm, and then continue refactoring to move to > >>> separate phy driver upstream, or to strip out the pll code from the > >>> beginning. If you/someone is working on 7nm support, then feedback > >>> about which approach is easier is welcome. > >>> > >>> https://lore.kernel.org/dri-devel/20200611091919.108018-1-swboyd@chromium.org/ > >>> > >> > >> I have a sm8150/sm8250 (7nm) upstream kernel stack with DP enabled, and > >> I have done something similar, with the PLL driver in the QMP phy, > >> although not based on sboyd's series (along with some typec changes to > >> negotiate the DP alt mode and get HPD events, etc.). I don't think > >> having PLL in drm/msm makes sense, the drm/msm DP driver shouldn't need > >> to be aware of the DP PLL/PHY driver, it only needs to set the > >> link/pixel clock rates which are in dispcc (and those then have the PLL > >> clocks as a parent). > > > > yeah, in the dp case, having phy split out makes a ton of sense.. it > > would maybe be a nice cleanup in other cases (dsi, hdmi) but the > > combination of usb+dp makes burying this in drm not so great.. > > > > It would be good if you could work w/ sboyd on this.. based on what > > I've seen on previous gens, it is probably a different phy driver for > > 7nm vs 10nm, but I think where we want to end up upstream is with phy > > split out of drm. > > 7nm differs in registers programming, so it would end up with a separate > set of tables in qmp phy driver. There is also a 14nm version of dp phy, > but I don't know if it usable in any actual hardware design. > I'll defer to Stephen about phy stuff, but was kinda just expecting to have different phy drivers for different process sizes, rather than trying to bundle it all in one phy driver. At least what I've seen before for dsi/hdmi/etc phy's is that the register programming is different enough to not really share much. BR, -R
diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 0b59e4f184fb..8e6ca119ea94 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP config DRM_MSM_DP bool "Enable DisplayPort support in MSM DRM driver" depends on DRM_MSM + default y help Compile in support for DP driver in MSM DRM driver. DP external display support is enabled through this config option. It can diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile index af868e791210..6d31188cc776 100644 --- a/drivers/gpu/drm/msm/Makefile +++ b/drivers/gpu/drm/msm/Makefile @@ -109,7 +109,9 @@ msm-$(CONFIG_DRM_MSM_DP)+= dp/dp_aux.o \ dp/dp_link.o \ dp/dp_panel.o \ dp/dp_parser.o \ - dp/dp_power.o + dp/dp_power.o \ + dp/dp_pll.o \ + dp/dp_pll_10nm.o msm-$(CONFIG_DRM_FBDEV_EMULATION) += msm_fbdev.o msm-$(CONFIG_COMMON_CLK) += disp/mdp4/mdp4_lvds_pll.o diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c index 497f97f86c82..e506e0756e92 100644 --- a/drivers/gpu/drm/msm/dp/dp_catalog.c +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c @@ -5,6 +5,7 @@ #define pr_fmt(fmt) "[drm-dp] %s: " fmt, __func__ +#include <linux/rational.h> #include <linux/delay.h> #include <linux/iopoll.h> #include <linux/rational.h> @@ -131,51 +132,58 @@ static inline void dp_write_ahb(struct dp_catalog_private *catalog, static inline void dp_write_phy(struct dp_catalog_private *catalog, u32 offset, u32 data) { + offset += DP_PHY_REG_OFFSET; /* * To make sure phy reg writes happens before any other operation, * this function uses writel() instread of writel_relaxed() */ - writel(data, catalog->io->phy_io.base + offset); + writel(data, catalog->io->phy_reg.base + offset); } static inline u32 dp_read_phy(struct dp_catalog_private *catalog, u32 offset) { + offset += DP_PHY_REG_OFFSET; /* * To make sure phy reg writes happens before any other operation, * this function uses writel() instread of writel_relaxed() */ - return readl_relaxed(catalog->io->phy_io.base + offset); + return readl_relaxed(catalog->io->phy_reg.base + offset); } static inline void dp_write_pll(struct dp_catalog_private *catalog, u32 offset, u32 data) { - writel_relaxed(data, catalog->io->dp_pll_io.base + offset); + offset += DP_PHY_PLL_OFFSET; + writel_relaxed(data, catalog->io->phy_reg.base + offset); } static inline void dp_write_ln_tx0(struct dp_catalog_private *catalog, u32 offset, u32 data) { - writel_relaxed(data, catalog->io->ln_tx0_io.base + offset); + offset += DP_PHY_LN_TX0_OFFSET; + writel_relaxed(data, catalog->io->phy_reg.base + offset); } static inline void dp_write_ln_tx1(struct dp_catalog_private *catalog, u32 offset, u32 data) { - writel_relaxed(data, catalog->io->ln_tx1_io.base + offset); + offset += DP_PHY_LN_TX1_OFFSET; + writel_relaxed(data, catalog->io->phy_reg.base + offset); } static inline u32 dp_read_ln_tx0(struct dp_catalog_private *catalog, u32 offset) { - return readl_relaxed(catalog->io->ln_tx0_io.base + offset); + offset += DP_PHY_LN_TX0_OFFSET; + return readl_relaxed(catalog->io->phy_reg.base + offset); } static inline u32 dp_read_ln_tx1(struct dp_catalog_private *catalog, u32 offset) { - return readl_relaxed(catalog->io->ln_tx1_io.base + offset); + offset += DP_PHY_LN_TX1_OFFSET; + return readl_relaxed(catalog->io->phy_reg.base + offset); } static inline void dp_write_usb_cm(struct dp_catalog_private *catalog, @@ -386,13 +394,16 @@ void dp_catalog_dump_regs(struct dp_catalog *dp_catalog) dump_regs(catalog->io->usb3_dp_com.base, catalog->io->usb3_dp_com.len); pr_info("LN TX0 regs\n"); - dump_regs(catalog->io->ln_tx0_io.base, catalog->io->ln_tx0_io.len); + dump_regs(catalog->io->phy_reg.base + DP_PHY_LN_TX0_OFFSET, + DP_PHY_LN_TX0_SIZE); pr_info("LN TX1 regs\n"); - dump_regs(catalog->io->ln_tx1_io.base, catalog->io->ln_tx1_io.len); + dump_regs(catalog->io->phy_reg.base + DP_PHY_LN_TX1_OFFSET, + DP_PHY_LN_TX1_SIZE); pr_info("DP PHY regs\n"); - dump_regs(catalog->io->phy_io.base, catalog->io->phy_io.len); + dump_regs(catalog->io->phy_reg.base + DP_PHY_REG_OFFSET, + DP_PHY_REG_SIZE); } void dp_catalog_aux_setup(struct dp_catalog *dp_catalog) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 4b0d64e504ac..86c958b21c97 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -22,6 +22,7 @@ #include "dp_ctrl.h" #include "dp_display.h" #include "dp_drm.h" +#include "dp_pll.h" static struct msm_dp *g_dp_display; #define HPD_STRING_SIZE 30 @@ -42,6 +43,7 @@ struct dp_display_private { struct dp_usbpd *usbpd; struct dp_parser *parser; + struct msm_dp_pll *pll; struct dp_power *power; struct dp_catalog *catalog; struct drm_dp_aux *aux; @@ -232,7 +234,6 @@ static int dp_display_process_hpd_high(struct dp_display_private *dp) edid = dp->panel->edid; dp->audio_supported = drm_detect_monitor_audio(edid); - dp_panel_handle_sink_request(dp->panel); dp->dp_display.max_pclk_khz = DP_MAX_PIXEL_CLK_KHZ; @@ -410,6 +411,7 @@ static void dp_display_deinit_sub_modules(struct dp_display_private *dp) dp_ctrl_put(dp->ctrl); dp_panel_put(dp->panel); dp_aux_put(dp->aux); + dp_pll_put(dp->pll); } static int dp_init_sub_modules(struct dp_display_private *dp) @@ -420,6 +422,9 @@ static int dp_init_sub_modules(struct dp_display_private *dp) struct dp_panel_in panel_in = { .dev = dev, }; + struct dp_pll_in pll_in = { + .pdev = dp->pdev, + }; /* Callback APIs used for cable status change event */ cb->configure = dp_display_usbpd_configure_cb; @@ -450,6 +455,17 @@ static int dp_init_sub_modules(struct dp_display_private *dp) goto error; } + pll_in.parser = dp->parser; + dp->pll = dp_pll_get(&pll_in); + if (IS_ERR_OR_NULL(dp->pll)) { + rc = -EINVAL; + DRM_ERROR("failed to initialize pll, rc = %d\n", rc); + dp->pll = NULL; + goto error; + } + + dp->parser->pll = dp->pll; + dp->power = dp_power_get(dp->parser); if (IS_ERR(dp->power)) { rc = PTR_ERR(dp->power); diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h index dad8610685a6..4c53ed55d1cc 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.h +++ b/drivers/gpu/drm/msm/dp/dp_display.h @@ -25,4 +25,7 @@ int dp_display_request_irq(struct msm_dp *dp_display); bool dp_display_check_video_test(struct msm_dp *dp_display); int dp_display_get_test_bpp(struct msm_dp *dp_display); +void __init msm_dp_pll_driver_register(void); +void __exit msm_dp_pll_driver_unregister(void); + #endif /* _DP_DISPLAY_H_ */ diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c index fd5c959bdcaf..558eaf7ce656 100644 --- a/drivers/gpu/drm/msm/dp/dp_parser.c +++ b/drivers/gpu/drm/msm/dp/dp_parser.c @@ -6,6 +6,7 @@ #include <linux/of_gpio.h> #include "dp_parser.h" +#include "dp_reg.h" static const struct dp_regulator_cfg sdm845_dp_reg_cfg = { .num = 2, @@ -52,6 +53,7 @@ static void dp_parser_unmap_io_resources(struct dp_parser *parser) struct dp_io *io = &parser->io; msm_dss_iounmap(&io->dp_controller); + msm_dss_iounmap(&io->phy_reg); msm_dss_iounmap(&io->usb3_dp_com); } diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h b/drivers/gpu/drm/msm/dp/dp_parser.h index 2085b15aa4cf..aa0380b6a280 100644 --- a/drivers/gpu/drm/msm/dp/dp_parser.h +++ b/drivers/gpu/drm/msm/dp/dp_parser.h @@ -10,6 +10,7 @@ #include "dpu_io_util.h" #include "msm_drv.h" +#include "dp_pll.h" #define DP_LABEL "MDSS DP DISPLAY" #define DP_MAX_PIXEL_CLK_KHZ 675000 @@ -66,10 +67,7 @@ struct dp_display_data { */ struct dp_io { struct dss_io_data dp_controller; - struct dss_io_data phy_io; - struct dss_io_data ln_tx0_io; - struct dss_io_data ln_tx1_io; - struct dss_io_data dp_pll_io; + struct dss_io_data phy_reg; struct dss_io_data usb3_dp_com; }; @@ -117,6 +115,7 @@ struct dp_parser { struct dp_pinctrl pinctrl; struct dp_io io; struct dp_display_data disp_data; + struct msm_dp_pll *pll; const struct dp_regulator_cfg *regulator_cfg; u32 max_dp_lanes; diff --git a/drivers/gpu/drm/msm/dp/dp_pll.c b/drivers/gpu/drm/msm/dp/dp_pll.c new file mode 100644 index 000000000000..53f82cd97027 --- /dev/null +++ b/drivers/gpu/drm/msm/dp/dp_pll.c @@ -0,0 +1,99 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. + */ + +#include <linux/device.h> + +#include "dp_parser.h" +#include "dp_pll.h" +#include "dp_pll_private.h" + +static int dp_pll_get_phy_io(struct dp_parser *parser) +{ + struct dp_io *io = &parser->io; + + io->usb3_dp_com.base = ioremap(REG_USB3_DP_COM_REGION_BASE, + REG_USB3_DP_COM_REGION_SIZE); + if (!io->usb3_dp_com.base) { + DRM_ERROR("unable to map USB3 DP COM IO\n"); + return -EIO; + } + + /* ToDo(user): DP PLL and DP PHY will not be part of + * DP driver eventually so for now Hardcode Base and offsets + * of PHY registers so we can remove them from dts and bindings + */ + io->phy_reg.base = ioremap(REG_DP_PHY_REGION_BASE, + REG_DP_PHY_REGION_SIZE); + if (!io->phy_reg.base) { + DRM_ERROR("DP PHY io region mapping failed\n"); + return -EIO; + } + io->phy_reg.len = REG_DP_PHY_REGION_SIZE; + + return 0; +} + +static int msm_dp_pll_init(struct msm_dp_pll *pll, + enum msm_dp_pll_type type, int id) +{ + struct device *dev = &pll->pdev->dev; + int ret = 0; + + switch (type) { + case MSM_DP_PLL_10NM: + ret = msm_dp_pll_10nm_init(pll, id); + break; + default: + DRM_DEV_ERROR(dev, "%s: Wrong PLL type %d\n", __func__, type); + return -ENXIO; + } + + if (ret) { + DRM_DEV_ERROR(dev, "%s: failed to init DP PLL\n", __func__); + return ret; + } + + pll->type = type; + + DRM_DEBUG_DP("DP:%d PLL registered", id); + + return ret; +} + +struct msm_dp_pll *dp_pll_get(struct dp_pll_in *pll_in) +{ + struct msm_dp_pll *dp_pll; + struct dp_parser *parser = pll_in->parser; + struct dp_io_pll *pll_io; + int ret; + + dp_pll = devm_kzalloc(&pll_in->pdev->dev, sizeof(*dp_pll), GFP_KERNEL); + if (!dp_pll) + return ERR_PTR(-ENOMEM); + + pll_io = &dp_pll->pll_io; + dp_pll->pdev = pll_in->pdev; + + dp_pll_get_phy_io(parser); + + pll_io->pll_base = parser->io.phy_reg.base + DP_PHY_PLL_OFFSET; + pll_io->phy_base = parser->io.phy_reg.base + DP_PHY_REG_OFFSET; + pll_io->ln_tx0_base = parser->io.phy_reg.base + DP_PHY_LN_TX0_OFFSET; + pll_io->ln_tx1_base = parser->io.phy_reg.base + DP_PHY_LN_TX1_OFFSET; + + ret = msm_dp_pll_init(dp_pll, MSM_DP_PLL_10NM, 0); + if (ret) { + kfree(dp_pll); + return ERR_PTR(ret); + } + + return dp_pll; +} + +void dp_pll_put(struct msm_dp_pll *dp_pll) +{ + if (dp_pll->type == MSM_DP_PLL_10NM) + msm_dp_pll_10nm_deinit(dp_pll); +} diff --git a/drivers/gpu/drm/msm/dp/dp_pll.h b/drivers/gpu/drm/msm/dp/dp_pll.h new file mode 100644 index 000000000000..5a10c8f3cfea --- /dev/null +++ b/drivers/gpu/drm/msm/dp/dp_pll.h @@ -0,0 +1,61 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. + */ + +#ifndef __DP_PLL_H +#define __DP_PLL_H + +#include <linux/clk.h> +#include <linux/clk-provider.h> +#include <linux/platform_device.h> + +#include "dpu_io_util.h" +#include "msm_drv.h" +#include "dp_parser.h" + +#define PLL_REG_W(base, offset, data) \ + writel((data), (base) + (offset)) +#define PLL_REG_R(base, offset) readl((base) + (offset)) + +enum msm_dp_pll_type { + MSM_DP_PLL_10NM, + MSM_DP_PLL_MAX +}; + +struct dp_pll_in { + struct platform_device *pdev; + struct dp_parser *parser; +}; + +struct dp_io_pll { + void __iomem *pll_base; + void __iomem *phy_base; + void __iomem *ln_tx0_base; + void __iomem *ln_tx1_base; +}; + +struct msm_dp_pll { + enum msm_dp_pll_type type; + bool pll_on; + + struct dp_io_pll pll_io; + + /* clock-provider: */ + struct clk_hw_onecell_data *hw_data; + + struct platform_device *pdev; + void *priv; + + /* Pll specific resources like GPIO, power supply, clocks, etc*/ + struct dss_module_power mp; + int (*get_provider)(struct msm_dp_pll *pll, + struct clk **link_clk_provider, + struct clk **pixel_clk_provider); +}; + +struct msm_dp_pll *dp_pll_get(struct dp_pll_in *pll_in); + +void dp_pll_put(struct msm_dp_pll *dp_pll); + +#endif /* __DP_PLL_H */ diff --git a/drivers/gpu/drm/msm/dp/dp_pll_10nm.c b/drivers/gpu/drm/msm/dp/dp_pll_10nm.c new file mode 100644 index 000000000000..6d9ae7b891c7 --- /dev/null +++ b/drivers/gpu/drm/msm/dp/dp_pll_10nm.c @@ -0,0 +1,917 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. + */ + +/* + * Display Port PLL driver block diagram for branch clocks + * + * +------------------------------+ + * | DP_VCO_CLK | + * | | + * | +-------------------+ | + * | | (DP PLL/VCO) | | + * | +---------+---------+ | + * | v | + * | +----------+-----------+ | + * | | hsclk_divsel_clk_src | | + * | +----------+-----------+ | + * +------------------------------+ + * | + * +---------<---------v------------>----------+ + * | | + * +--------v---------+ | + * | dp_phy_pll | | + * | link_clk | | + * +--------+---------+ | + * | | + * | | + * v v + * Input to DISPCC block | + * for link clk, crypto clk | + * and interface clock | + * | + * | + * +--------<------------+-----------------+---<---+ + * | | | + * +----v---------+ +--------v-----+ +--------v------+ + * | vco_divided | | vco_divided | | vco_divided | + * | _clk_src | | _clk_src | | _clk_src | + * | | | | | | + * |divsel_six | | divsel_two | | divsel_four | + * +-------+------+ +-----+--------+ +--------+------+ + * | | | + * v---->----------v-------------<------v + * | + * +----------+---------+ + * | dp_phy_pll_vco | + * | div_clk | + * +---------+----------+ + * | + * v + * Input to DISPCC block + * for DP pixel clock + * + */ + +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/err.h> +#include <linux/kernel.h> +#include <linux/regmap.h> +#include <linux/iopoll.h> + +#include "dp_hpd.h" +#include "dp_pll.h" +#include "dp_pll_private.h" + +#define NUM_PROVIDED_CLKS 2 + +#define DP_LINK_CLK_SRC 0 +#define DP_PIXEL_CLK_SRC 1 + +static struct dp_pll_db *dp_pdb; + +static const struct clk_ops dp_10nm_vco_clk_ops = { + .recalc_rate = dp_vco_recalc_rate_10nm, + .set_rate = dp_vco_set_rate_10nm, + .round_rate = dp_vco_round_rate_10nm, + .prepare = dp_vco_prepare_10nm, + .unprepare = dp_vco_unprepare_10nm, +}; + +struct dp_pll_10nm_pclksel { + struct clk_hw hw; + + /* divider params */ + u8 shift; + u8 width; + u8 flags; /* same flags as used by clk_divider struct */ + + struct dp_pll_db *pll; +}; + +#define to_pll_10nm_pclksel(_hw) \ + container_of(_hw, struct dp_pll_10nm_pclksel, hw) + +static const struct clk_parent_data disp_cc_parent_data_0[] = { + { .fw_name = "bi_tcxo" }, + { .fw_name = "dp_phy_pll_link_clk", .name = "dp_phy_pll_link_clk" }, + { .fw_name = "core_bi_pll_test_se", .name = "core_bi_pll_test_se" }, +}; + +static struct dp_pll_vco_clk dp_vco_clk = { + .min_rate = DP_VCO_HSCLK_RATE_1620MHZDIV1000, + .max_rate = DP_VCO_HSCLK_RATE_8100MHZDIV1000, +}; + +static int dp_pll_mux_set_parent_10nm(struct clk_hw *hw, u8 val) +{ + struct dp_pll_10nm_pclksel *pclksel = to_pll_10nm_pclksel(hw); + struct dp_pll_db *dp_res = pclksel->pll; + struct dp_io_pll *pll_io = &dp_res->base->pll_io; + u32 auxclk_div; + + auxclk_div = PLL_REG_R(pll_io->phy_base, REG_DP_PHY_VCO_DIV); + auxclk_div &= ~0x03; + + if (val == 0) + auxclk_div |= 1; + else if (val == 1) + auxclk_div |= 2; + else if (val == 2) + auxclk_div |= 0; + + PLL_REG_W(pll_io->phy_base, + REG_DP_PHY_VCO_DIV, auxclk_div); + DRM_DEBUG_DP("%s: mux=%d auxclk_div=%x\n", __func__, val, auxclk_div); + + return 0; +} + +static u8 dp_pll_mux_get_parent_10nm(struct clk_hw *hw) +{ + u32 auxclk_div = 0; + struct dp_pll_10nm_pclksel *pclksel = to_pll_10nm_pclksel(hw); + struct dp_pll_db *dp_res = pclksel->pll; + struct dp_io_pll *pll_io = &dp_res->base->pll_io; + u8 val = 0; + + auxclk_div = PLL_REG_R(pll_io->phy_base, REG_DP_PHY_VCO_DIV); + auxclk_div &= 0x03; + + if (auxclk_div == 1) /* Default divider */ + val = 0; + else if (auxclk_div == 2) + val = 1; + else if (auxclk_div == 0) + val = 2; + + DRM_DEBUG_DP("%s: auxclk_div=%d, val=%d\n", __func__, auxclk_div, val); + + return val; +} + +static int dp_pll_clk_mux_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + unsigned long rate = 0; + + rate = clk_get_rate(hw->clk); + + if (rate <= 0) { + DRM_ERROR("Rate is not set properly\n"); + return -EINVAL; + } + + req->rate = rate; + + DRM_DEBUG_DP("%s: rate=%ld\n", __func__, req->rate); + return 0; +} + +static unsigned long dp_pll_mux_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct clk_hw *div_clk_hw = NULL, *vco_clk_hw = NULL; + struct dp_pll_vco_clk *vco; + + div_clk_hw = clk_hw_get_parent(hw); + if (!div_clk_hw) + return 0; + + vco_clk_hw = clk_hw_get_parent(div_clk_hw); + if (!vco_clk_hw) + return 0; + + vco = to_dp_vco_hw(vco_clk_hw); + if (!vco) + return 0; + + if (vco->rate == DP_VCO_HSCLK_RATE_8100MHZDIV1000) + return (vco->rate / 6); + else if (vco->rate == DP_VCO_HSCLK_RATE_5400MHZDIV1000) + return (vco->rate / 4); + else + return (vco->rate / 2); +} + +static int dp_pll_10nm_get_provider(struct msm_dp_pll *pll, + struct clk **link_clk_provider, + struct clk **pixel_clk_provider) +{ + struct clk_hw_onecell_data *hw_data = pll->hw_data; + + if (link_clk_provider) + *link_clk_provider = hw_data->hws[DP_LINK_CLK_SRC]->clk; + if (pixel_clk_provider) + *pixel_clk_provider = hw_data->hws[DP_PIXEL_CLK_SRC]->clk; + + return 0; +} + +static const struct clk_ops dp_10nm_pclksel_clk_ops = { + .get_parent = dp_pll_mux_get_parent_10nm, + .set_parent = dp_pll_mux_set_parent_10nm, + .recalc_rate = dp_pll_mux_recalc_rate, + .determine_rate = dp_pll_clk_mux_determine_rate, +}; + +static struct clk_hw *dp_pll_10nm_pixel_clk_sel(struct dp_pll_db *pll_10nm) +{ + struct device *dev = &pll_10nm->pdev->dev; + struct dp_pll_10nm_pclksel *pll_pclksel; + struct clk_init_data pclksel_init = { + .parent_data = disp_cc_parent_data_0, + .num_parents = 3, + .name = "dp_phy_pll_vco_div_clk", + .ops = &dp_10nm_pclksel_clk_ops, + }; + int ret; + + pll_pclksel = devm_kzalloc(dev, sizeof(*pll_pclksel), GFP_KERNEL); + if (!pll_pclksel) + return ERR_PTR(-ENOMEM); + + pll_pclksel->pll = pll_10nm; + pll_pclksel->shift = 0; + pll_pclksel->width = 4; + pll_pclksel->hw.init = &pclksel_init; + + ret = clk_hw_register(dev, &pll_pclksel->hw); + if (ret) + return ERR_PTR(ret); + + return &pll_pclksel->hw; +} + +static void dp_pll_10nm_unregister(struct dp_pll_db *pll_10nm) +{ + int i = 0; + struct clk_hw **hws; + + hws = pll_10nm->hws; + + for (i = 0; i < pll_10nm->num_hws; i++) { + if (pll_10nm->fixed_factor_clk[i] == true) + clk_hw_unregister_fixed_factor(hws[i]); + else + clk_hw_unregister(hws[i]); + } +} + +static int dp_pll_10nm_register(struct dp_pll_db *pll_10nm) +{ + struct clk_hw_onecell_data *hw_data; + int ret = 0; + struct clk_hw *hw; + + struct msm_dp_pll *pll = pll_10nm->base; + struct device *dev = &pll_10nm->pdev->dev; + struct clk_hw **hws = pll_10nm->hws; + int num = 0; + + struct clk_init_data vco_init = { + .parent_data = &(const struct clk_parent_data){ + .fw_name = "bi_tcxo", + }, + .num_parents = 1, + .name = "dp_vco_clk", + .ops = &dp_10nm_vco_clk_ops, + }; + + if (!dev) { + DRM_ERROR("DP dev node not available\n"); + return 0; + } + + DRM_DEBUG_DP("DP->id = %d", pll_10nm->id); + + hw_data = devm_kzalloc(dev, sizeof(*hw_data) + + NUM_PROVIDED_CLKS * sizeof(struct clk_hw *), + GFP_KERNEL); + if (!hw_data) + return -ENOMEM; + + dp_vco_clk.hw.init = &vco_init; + ret = clk_hw_register(dev, &dp_vco_clk.hw); + if (ret) + return ret; + hws[num++] = &dp_vco_clk.hw; + + hw = clk_hw_register_fixed_factor(dev, "dp_phy_pll_link_clk", + "dp_vco_clk", CLK_SET_RATE_PARENT, 1, 10); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + pll_10nm->fixed_factor_clk[num] = true; + hws[num++] = hw; + hw_data->hws[DP_LINK_CLK_SRC] = hw; + + hw = clk_hw_register_fixed_factor(dev, "dp_vco_divsel_two_clk_src", + "dp_vco_clk", 0, 1, 2); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + pll_10nm->fixed_factor_clk[num] = true; + hws[num++] = hw; + + hw = clk_hw_register_fixed_factor(dev, "dp_vco_divsel_four_clk_src", + "dp_vco_clk", 0, 1, 4); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + pll_10nm->fixed_factor_clk[num] = true; + hws[num++] = hw; + + hw = clk_hw_register_fixed_factor(dev, "dp_vco_divsel_six_clk_src", + "dp_vco_clk", 0, 1, 6); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + pll_10nm->fixed_factor_clk[num] = true; + hws[num++] = hw; + + hw = dp_pll_10nm_pixel_clk_sel(pll_10nm); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + hws[num++] = hw; + hw_data->hws[DP_PIXEL_CLK_SRC] = hw; + + pll_10nm->num_hws = num; + + hw_data->num = NUM_PROVIDED_CLKS; + pll->hw_data = hw_data; + + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, + pll->hw_data); + if (ret) { + DRM_DEV_ERROR(dev, "failed to register clk provider: %d\n", + ret); + return ret; + } + + return ret; +} + +void msm_dp_pll_10nm_deinit(struct msm_dp_pll *pll) +{ + dp_pll_10nm_unregister(pll->priv); +} + +int msm_dp_pll_10nm_init(struct msm_dp_pll *pll, int id) +{ + struct dp_pll_db *dp_10nm_pll; + struct platform_device *pdev = pll->pdev; + int ret; + + dp_10nm_pll = devm_kzalloc(&pdev->dev, + sizeof(*dp_10nm_pll), GFP_KERNEL); + if (!dp_10nm_pll) + return -ENOMEM; + + DRM_DEBUG_DP("DP PLL%d", id); + + dp_10nm_pll->base = pll; + dp_10nm_pll->pdev = pll->pdev; + dp_10nm_pll->id = id; + dp_pdb = dp_10nm_pll; + pll->priv = (void *)dp_10nm_pll; + dp_vco_clk.priv = pll; + dp_10nm_pll->index = 0; + + ret = dp_pll_10nm_register(dp_10nm_pll); + if (ret) { + DRM_DEV_ERROR(&pdev->dev, "failed to register PLL: %d\n", ret); + return ret; + } + + pll->get_provider = dp_pll_10nm_get_provider; + + return ret; +} + +static int dp_vco_pll_init_db_10nm(struct msm_dp_pll *pll, + unsigned long rate) +{ + u32 spare_value = 0; + struct dp_io_pll *pll_io; + struct dp_pll_db *dp_res = to_dp_pll_db(pll); + + pll_io = &pll->pll_io; + spare_value = PLL_REG_R(pll_io->phy_base, REG_DP_PHY_SPARE0); + dp_res->lane_cnt = spare_value & 0x0F; + dp_res->orientation = (spare_value & 0xF0) >> 4; + + DRM_DEBUG_DP("%s: spare_value=0x%x, ln_cnt=0x%x, orientation=0x%x\n", + __func__, spare_value, dp_res->lane_cnt, + dp_res->orientation); + + switch (rate) { + case DP_VCO_HSCLK_RATE_1620MHZDIV1000: + DRM_DEBUG_DP("%s: VCO rate: %ld\n", __func__, + DP_VCO_RATE_9720MHZDIV1000); + dp_res->hsclk_sel = 0x0c; + dp_res->dec_start_mode0 = 0x69; + dp_res->div_frac_start1_mode0 = 0x00; + dp_res->div_frac_start2_mode0 = 0x80; + dp_res->div_frac_start3_mode0 = 0x07; + dp_res->integloop_gain0_mode0 = 0x3f; + dp_res->integloop_gain1_mode0 = 0x00; + dp_res->vco_tune_map = 0x00; + dp_res->lock_cmp1_mode0 = 0x6f; + dp_res->lock_cmp2_mode0 = 0x08; + dp_res->lock_cmp3_mode0 = 0x00; + dp_res->phy_vco_div = 0x1; + dp_res->lock_cmp_en = 0x00; + break; + case DP_VCO_HSCLK_RATE_2700MHZDIV1000: + DRM_DEBUG_DP("%s: VCO rate: %ld\n", __func__, + DP_VCO_RATE_10800MHZDIV1000); + dp_res->hsclk_sel = 0x04; + dp_res->dec_start_mode0 = 0x69; + dp_res->div_frac_start1_mode0 = 0x00; + dp_res->div_frac_start2_mode0 = 0x80; + dp_res->div_frac_start3_mode0 = 0x07; + dp_res->integloop_gain0_mode0 = 0x3f; + dp_res->integloop_gain1_mode0 = 0x00; + dp_res->vco_tune_map = 0x00; + dp_res->lock_cmp1_mode0 = 0x0f; + dp_res->lock_cmp2_mode0 = 0x0e; + dp_res->lock_cmp3_mode0 = 0x00; + dp_res->phy_vco_div = 0x1; + dp_res->lock_cmp_en = 0x00; + break; + case DP_VCO_HSCLK_RATE_5400MHZDIV1000: + DRM_DEBUG_DP("%s: VCO rate: %ld\n", __func__, + DP_VCO_RATE_10800MHZDIV1000); + dp_res->hsclk_sel = 0x00; + dp_res->dec_start_mode0 = 0x8c; + dp_res->div_frac_start1_mode0 = 0x00; + dp_res->div_frac_start2_mode0 = 0x00; + dp_res->div_frac_start3_mode0 = 0x0a; + dp_res->integloop_gain0_mode0 = 0x3f; + dp_res->integloop_gain1_mode0 = 0x00; + dp_res->vco_tune_map = 0x00; + dp_res->lock_cmp1_mode0 = 0x1f; + dp_res->lock_cmp2_mode0 = 0x1c; + dp_res->lock_cmp3_mode0 = 0x00; + dp_res->phy_vco_div = 0x2; + dp_res->lock_cmp_en = 0x00; + break; + case DP_VCO_HSCLK_RATE_8100MHZDIV1000: + DRM_DEBUG_DP("%s: VCO rate: %ld\n", __func__, + DP_VCO_RATE_8100MHZDIV1000); + dp_res->hsclk_sel = 0x03; + dp_res->dec_start_mode0 = 0x69; + dp_res->div_frac_start1_mode0 = 0x00; + dp_res->div_frac_start2_mode0 = 0x80; + dp_res->div_frac_start3_mode0 = 0x07; + dp_res->integloop_gain0_mode0 = 0x3f; + dp_res->integloop_gain1_mode0 = 0x00; + dp_res->vco_tune_map = 0x00; + dp_res->lock_cmp1_mode0 = 0x2f; + dp_res->lock_cmp2_mode0 = 0x2a; + dp_res->lock_cmp3_mode0 = 0x00; + dp_res->phy_vco_div = 0x0; + dp_res->lock_cmp_en = 0x08; + break; + default: + return -EINVAL; + } + return 0; +} + +static int dp_config_vco_rate_10nm(struct dp_pll_vco_clk *vco, + unsigned long rate) +{ + u32 res = 0; + struct msm_dp_pll *pll = vco->priv; + struct dp_io_pll *pll_io = &pll->pll_io; + struct dp_pll_db *dp_res = to_dp_pll_db(pll); + + res = dp_vco_pll_init_db_10nm(pll, rate); + if (res) { + DRM_ERROR("VCO Init DB failed\n"); + return res; + } + + if (dp_res->lane_cnt != 4) { + if (dp_res->orientation == ORIENTATION_CC2) + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_PD_CTL, 0x6d); + else + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_PD_CTL, 0x75); + } else { + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_PD_CTL, 0x7d); + } + + PLL_REG_W(pll_io->pll_base, QSERDES_COM_SVS_MODE_CLK_SEL, 0x01); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_SYSCLK_EN_SEL, 0x37); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_SYS_CLK_CTRL, 0x02); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_CLK_ENABLE1, 0x0e); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_SYSCLK_BUF_ENABLE, 0x06); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_CLK_SEL, 0x30); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_CMN_CONFIG, 0x02); + + /* Different for each clock rates */ + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_HSCLK_SEL, dp_res->hsclk_sel); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_DEC_START_MODE0, dp_res->dec_start_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_DIV_FRAC_START1_MODE0, + dp_res->div_frac_start1_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_DIV_FRAC_START2_MODE0, + dp_res->div_frac_start2_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_DIV_FRAC_START3_MODE0, + dp_res->div_frac_start3_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_INTEGLOOP_GAIN0_MODE0, + dp_res->integloop_gain0_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_INTEGLOOP_GAIN1_MODE0, + dp_res->integloop_gain1_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_VCO_TUNE_MAP, dp_res->vco_tune_map); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_LOCK_CMP1_MODE0, dp_res->lock_cmp1_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_LOCK_CMP2_MODE0, dp_res->lock_cmp2_mode0); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_LOCK_CMP3_MODE0, dp_res->lock_cmp3_mode0); + + PLL_REG_W(pll_io->pll_base, QSERDES_COM_BG_TIMER, 0x0a); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_CORECLK_DIV_MODE0, 0x0a); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_VCO_TUNE_CTRL, 0x00); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_BIAS_EN_CLKBUFLR_EN, 0x3f); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_CORE_CLK_EN, 0x1f); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_PLL_IVCO, 0x07); + PLL_REG_W(pll_io->pll_base, + QSERDES_COM_LOCK_CMP_EN, dp_res->lock_cmp_en); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_PLL_CCTRL_MODE0, 0x36); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_PLL_RCTRL_MODE0, 0x16); + PLL_REG_W(pll_io->pll_base, QSERDES_COM_CP_CTRL_MODE0, 0x06); + + if (dp_res->orientation == ORIENTATION_CC2) + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_MODE, 0x4c); + else + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_MODE, 0x5c); + + /* TX Lane configuration */ + PLL_REG_W(pll_io->phy_base, + REG_DP_PHY_TX0_TX1_LANE_CTL, 0x05); + PLL_REG_W(pll_io->phy_base, + REG_DP_PHY_TX2_TX3_LANE_CTL, 0x05); + + /* TX-0 register configuration */ + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_TRANSCEIVER_BIAS_EN, 0x1a); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_VMODE_CTRL1, 0x40); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_PRE_STALL_LDO_BOOST_EN, 0x30); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_INTERFACE_SELECT, 0x3d); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_CLKBUF_ENABLE, 0x0f); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_RESET_TSYNC_EN, 0x03); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_TRAN_DRVR_EMP_EN, 0x03); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_PARRATE_REC_DETECT_IDLE_EN, 0x00); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_TX_INTERFACE_MODE, 0x00); + PLL_REG_W(pll_io->ln_tx0_base, REG_DP_PHY_TXn_TX_BAND, 0x4); + + /* TX-1 register configuration */ + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_TRANSCEIVER_BIAS_EN, 0x1a); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_VMODE_CTRL1, 0x40); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_PRE_STALL_LDO_BOOST_EN, 0x30); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_INTERFACE_SELECT, 0x3d); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_CLKBUF_ENABLE, 0x0f); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_RESET_TSYNC_EN, 0x03); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_TRAN_DRVR_EMP_EN, 0x03); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_PARRATE_REC_DETECT_IDLE_EN, 0x00); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_TX_INTERFACE_MODE, 0x00); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_TX_BAND, 0x4); + + /* dependent on the vco frequency */ + PLL_REG_W(pll_io->phy_base, + REG_DP_PHY_VCO_DIV, dp_res->phy_vco_div); + + return res; +} + +static bool dp_10nm_pll_lock_status(struct dp_pll_db *dp_res) +{ + u32 status; + bool pll_locked; + struct dp_io_pll *pll_io = &dp_res->base->pll_io; + + /* poll for PLL lock status */ + if (readl_poll_timeout_atomic((pll_io->pll_base + + QSERDES_COM_C_READY_STATUS), + status, + ((status & BIT(0)) > 0), + DP_PHY_PLL_POLL_SLEEP_US, + DP_PHY_PLL_POLL_TIMEOUT_US)) { + DRM_ERROR("%s: C_READY status is not high. Status=%x\n", + __func__, status); + pll_locked = false; + } else { + pll_locked = true; + } + + return pll_locked; +} + +static bool dp_10nm_phy_rdy_status(struct dp_pll_db *dp_res) +{ + u32 status; + bool phy_ready = true; + struct dp_io_pll *pll_io = &dp_res->base->pll_io; + + /* poll for PHY ready status */ + if (readl_poll_timeout_atomic((pll_io->phy_base + + REG_DP_PHY_STATUS), + status, + ((status & (BIT(1))) > 0), + DP_PHY_PLL_POLL_SLEEP_US, + DP_PHY_PLL_POLL_TIMEOUT_US)) { + DRM_ERROR("%s: Phy_ready is not high. Status=%x\n", + __func__, status); + phy_ready = false; + } + + return phy_ready; +} + +static int dp_pll_enable_10nm(struct clk_hw *hw) +{ + int rc = 0; + u32 bias_en, drvr_en; + struct dp_io_pll *pll_io; + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + struct msm_dp_pll *pll = to_msm_dp_pll(vco); + struct dp_pll_db *dp_res = to_dp_pll_db(pll); + + pll_io = &pll->pll_io; + + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_AUX_CFG2, 0x04); + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x01); + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x05); + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x01); + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x09); + + PLL_REG_W(pll_io->pll_base, QSERDES_COM_RESETSM_CNTRL, 0x20); + + if (!dp_10nm_pll_lock_status(dp_res)) { + rc = -EINVAL; + goto lock_err; + } + + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x19); + /* poll for PHY ready status */ + if (!dp_10nm_phy_rdy_status(dp_res)) { + rc = -EINVAL; + goto lock_err; + } + + DRM_DEBUG_DP("%s: PLL is locked\n", __func__); + + if (dp_res->lane_cnt == 1) { + bias_en = 0x3e; + drvr_en = 0x13; + } else { + bias_en = 0x3f; + drvr_en = 0x10; + } + + if (dp_res->lane_cnt != 4) { + if (dp_res->orientation == ORIENTATION_CC1) { + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_HIGHZ_DRVR_EN, drvr_en); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_TRANSCEIVER_BIAS_EN, bias_en); + } else { + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_HIGHZ_DRVR_EN, drvr_en); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_TRANSCEIVER_BIAS_EN, bias_en); + } + } else { + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_HIGHZ_DRVR_EN, drvr_en); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_TRANSCEIVER_BIAS_EN, bias_en); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_HIGHZ_DRVR_EN, drvr_en); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_TRANSCEIVER_BIAS_EN, bias_en); + } + + PLL_REG_W(pll_io->ln_tx0_base, REG_DP_PHY_TXn_TX_POL_INV, 0x0a); + PLL_REG_W(pll_io->ln_tx1_base, REG_DP_PHY_TXn_TX_POL_INV, 0x0a); + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x18); + udelay(2000); + + PLL_REG_W(pll_io->phy_base, REG_DP_PHY_CFG, 0x19); + + /* poll for PHY ready status */ + if (!dp_10nm_phy_rdy_status(dp_res)) { + rc = -EINVAL; + goto lock_err; + } + + PLL_REG_W(pll_io->ln_tx0_base, REG_DP_PHY_TXn_TX_DRV_LVL, 0x38); + PLL_REG_W(pll_io->ln_tx1_base, REG_DP_PHY_TXn_TX_DRV_LVL, 0x38); + PLL_REG_W(pll_io->ln_tx0_base, REG_DP_PHY_TXn_TX_EMP_POST1_LVL, 0x20); + PLL_REG_W(pll_io->ln_tx1_base, REG_DP_PHY_TXn_TX_EMP_POST1_LVL, 0x20); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_RES_CODE_LANE_OFFSET_TX, 0x06); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_RES_CODE_LANE_OFFSET_TX, 0x06); + PLL_REG_W(pll_io->ln_tx0_base, + REG_DP_PHY_TXn_RES_CODE_LANE_OFFSET_RX, 0x07); + PLL_REG_W(pll_io->ln_tx1_base, + REG_DP_PHY_TXn_RES_CODE_LANE_OFFSET_RX, 0x07); + +lock_err: + return rc; +} + +static int dp_pll_disable_10nm(struct clk_hw *hw) +{ + int rc = 0; + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + struct msm_dp_pll *pll = to_msm_dp_pll(vco); + + /* Assert DP PHY power down */ + PLL_REG_W(pll->pll_io.phy_base, REG_DP_PHY_PD_CTL, 0x2); + + return rc; +} + + +int dp_vco_prepare_10nm(struct clk_hw *hw) +{ + int rc = 0; + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + struct msm_dp_pll *pll = (struct msm_dp_pll *)vco->priv; + struct dp_pll_db *dp_res = to_dp_pll_db(pll); + + DRM_DEBUG_DP("%s: rate = %ld\n", __func__, vco->rate); + if ((dp_res->vco_cached_rate != 0) + && (dp_res->vco_cached_rate == vco->rate)) { + rc = dp_vco_set_rate_10nm(hw, + dp_res->vco_cached_rate, dp_res->vco_cached_rate); + if (rc) { + DRM_ERROR("index=%d vco_set_rate failed. rc=%d\n", + rc, dp_res->index); + goto error; + } + } + + rc = dp_pll_enable_10nm(hw); + if (rc) { + DRM_ERROR("ndx=%d failed to enable dp pll\n", + dp_res->index); + goto error; + } + + pll->pll_on = true; +error: + return rc; +} + +void dp_vco_unprepare_10nm(struct clk_hw *hw) +{ + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + struct msm_dp_pll *pll = to_msm_dp_pll(vco); + struct dp_pll_db *dp_res = to_dp_pll_db(pll); + + if (!dp_res) { + DRM_ERROR("Invalid input parameter\n"); + return; + } + + if (!pll->pll_on) { + DRM_ERROR("pll resource can't be enabled\n"); + return; + } + dp_res->vco_cached_rate = vco->rate; + dp_pll_disable_10nm(hw); + + pll->pll_on = false; +} + +int dp_vco_set_rate_10nm(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + int rc; + + DRM_DEBUG_DP("DP lane CLK rate=%ld\n", rate); + + rc = dp_config_vco_rate_10nm(vco, rate); + if (rc) + DRM_ERROR("%s: Failed to set clk rate\n", __func__); + + vco->rate = rate; + + return 0; +} + +unsigned long dp_vco_recalc_rate_10nm(struct clk_hw *hw, + unsigned long parent_rate) +{ + u32 div, hsclk_div, link_clk_div = 0; + u64 vco_rate; + struct dp_io_pll *pll_io; + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + struct msm_dp_pll *pll = to_msm_dp_pll(vco); + struct dp_pll_db *dp_res = to_dp_pll_db(pll); + + pll_io = &pll->pll_io; + + div = PLL_REG_R(pll_io->pll_base, QSERDES_COM_HSCLK_SEL); + div &= 0x0f; + + if (div == 12) + hsclk_div = 6; /* Default */ + else if (div == 4) + hsclk_div = 4; + else if (div == 0) + hsclk_div = 2; + else if (div == 3) + hsclk_div = 1; + else { + DRM_DEBUG_DP("unknown divider. forcing to default\n"); + hsclk_div = 5; + } + + div = PLL_REG_R(pll_io->phy_base, REG_DP_PHY_AUX_CFG2); + div >>= 2; + + if ((div & 0x3) == 0) + link_clk_div = 5; + else if ((div & 0x3) == 1) + link_clk_div = 10; + else if ((div & 0x3) == 2) + link_clk_div = 20; + else + DRM_ERROR("%s: unsupported div. Phy_mode: %d\n", __func__, div); + + if (link_clk_div == 20) { + vco_rate = DP_VCO_HSCLK_RATE_2700MHZDIV1000; + } else { + if (hsclk_div == 6) + vco_rate = DP_VCO_HSCLK_RATE_1620MHZDIV1000; + else if (hsclk_div == 4) + vco_rate = DP_VCO_HSCLK_RATE_2700MHZDIV1000; + else if (hsclk_div == 2) + vco_rate = DP_VCO_HSCLK_RATE_5400MHZDIV1000; + else + vco_rate = DP_VCO_HSCLK_RATE_8100MHZDIV1000; + } + + DRM_DEBUG_DP("returning vco rate = %lu\n", (unsigned long)vco_rate); + + dp_res->vco_cached_rate = vco->rate = vco_rate; + return (unsigned long)vco_rate; +} + +long dp_vco_round_rate_10nm(struct clk_hw *hw, unsigned long rate, + unsigned long *parent_rate) +{ + unsigned long rrate = rate; + struct dp_pll_vco_clk *vco = to_dp_vco_hw(hw); + + if (rate <= vco->min_rate) + rrate = vco->min_rate; + else if (rate <= DP_VCO_HSCLK_RATE_2700MHZDIV1000) + rrate = DP_VCO_HSCLK_RATE_2700MHZDIV1000; + else if (rate <= DP_VCO_HSCLK_RATE_5400MHZDIV1000) + rrate = DP_VCO_HSCLK_RATE_5400MHZDIV1000; + else + rrate = vco->max_rate; + + DRM_DEBUG_DP("%s: rrate=%ld\n", __func__, rrate); + + *parent_rate = rrate; + return rrate; +} diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h b/drivers/gpu/drm/msm/dp/dp_pll_private.h new file mode 100644 index 000000000000..475ba6ed59ab --- /dev/null +++ b/drivers/gpu/drm/msm/dp/dp_pll_private.h @@ -0,0 +1,98 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved. + */ + +#ifndef __DP_PLL_10NM_H +#define __DP_PLL_10NM_H + +#include "dp_pll.h" +#include "dp_reg.h" + +#define DP_VCO_HSCLK_RATE_1620MHZDIV1000 1620000UL +#define DP_VCO_HSCLK_RATE_2700MHZDIV1000 2700000UL +#define DP_VCO_HSCLK_RATE_5400MHZDIV1000 5400000UL +#define DP_VCO_HSCLK_RATE_8100MHZDIV1000 8100000UL + +#define NUM_DP_CLOCKS_MAX 6 + +#define DP_PHY_PLL_POLL_SLEEP_US 500 +#define DP_PHY_PLL_POLL_TIMEOUT_US 10000 + +#define DP_VCO_RATE_8100MHZDIV1000 8100000UL +#define DP_VCO_RATE_9720MHZDIV1000 9720000UL +#define DP_VCO_RATE_10800MHZDIV1000 10800000UL + +struct dp_pll_vco_clk { + struct clk_hw hw; + unsigned long rate; /* current vco rate */ + u64 min_rate; /* min vco rate */ + u64 max_rate; /* max vco rate */ + void *priv; +}; + +struct dp_pll_db { + struct msm_dp_pll *base; + + int id; + struct platform_device *pdev; + + /* private clocks: */ + bool fixed_factor_clk[NUM_DP_CLOCKS_MAX]; + struct clk_hw *hws[NUM_DP_CLOCKS_MAX]; + u32 num_hws; + + /* lane and orientation settings */ + u8 lane_cnt; + u8 orientation; + + /* COM PHY settings */ + u32 hsclk_sel; + u32 dec_start_mode0; + u32 div_frac_start1_mode0; + u32 div_frac_start2_mode0; + u32 div_frac_start3_mode0; + u32 integloop_gain0_mode0; + u32 integloop_gain1_mode0; + u32 vco_tune_map; + u32 lock_cmp1_mode0; + u32 lock_cmp2_mode0; + u32 lock_cmp3_mode0; + u32 lock_cmp_en; + + /* PHY vco divider */ + u32 phy_vco_div; + /* + * Certain pll's needs to update the same vco rate after resume in + * suspend/resume scenario. Cached the vco rate for such plls. + */ + unsigned long vco_cached_rate; + u32 cached_cfg0; + u32 cached_cfg1; + u32 cached_outdiv; + + uint32_t index; +}; + +static inline struct dp_pll_vco_clk *to_dp_vco_hw(struct clk_hw *hw) +{ + return container_of(hw, struct dp_pll_vco_clk, hw); +} + +#define to_msm_dp_pll(vco) ((struct msm_dp_pll *)vco->priv) + +#define to_dp_pll_db(x) ((struct dp_pll_db *)x->priv) + +int dp_vco_set_rate_10nm(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate); +unsigned long dp_vco_recalc_rate_10nm(struct clk_hw *hw, + unsigned long parent_rate); +long dp_vco_round_rate_10nm(struct clk_hw *hw, unsigned long rate, + unsigned long *parent_rate); +int dp_vco_prepare_10nm(struct clk_hw *hw); +void dp_vco_unprepare_10nm(struct clk_hw *hw); + +int msm_dp_pll_10nm_init(struct msm_dp_pll *dp_pll, int id); +void msm_dp_pll_10nm_deinit(struct msm_dp_pll *dp_pll); + +#endif /* __DP_PLL_10NM_H */ diff --git a/drivers/gpu/drm/msm/dp/dp_power.c b/drivers/gpu/drm/msm/dp/dp_power.c index 4aaa0aae4883..8b0a276d34a4 100644 --- a/drivers/gpu/drm/msm/dp/dp_power.c +++ b/drivers/gpu/drm/msm/dp/dp_power.c @@ -101,6 +101,16 @@ static int dp_power_clk_init(struct dp_power_private *power) core = &power->parser->mp[DP_CORE_PM]; ctrl = &power->parser->mp[DP_CTRL_PM]; + if (power->parser->pll && power->parser->pll->get_provider) { + rc = power->parser->pll->get_provider(power->parser->pll, + &power->link_provider, &power->pixel_provider); + if (rc) { + DRM_ERROR("%s:provider failed,don't set parent\n", + __func__); + return 0; + } + } + rc = msm_dss_get_clk(dev, core->clk_config, core->num_clk); if (rc) { DRM_ERROR("failed to get %s clk. err=%d\n", diff --git a/drivers/gpu/drm/msm/dp/dp_power.h b/drivers/gpu/drm/msm/dp/dp_power.h index ae55b78bf54a..756341e290ed 100644 --- a/drivers/gpu/drm/msm/dp/dp_power.h +++ b/drivers/gpu/drm/msm/dp/dp_power.h @@ -14,7 +14,6 @@ * @init: initializes the regulators/core clocks/GPIOs/pinctrl * @deinit: turns off the regulators/core clocks/GPIOs/pinctrl * @clk_enable: enable/disable the DP clocks - * @set_link_clk_parent: set the parent of DP link clock * @set_pixel_clk_parent: set the parent of DP pixel clock */ struct dp_power { @@ -22,10 +21,49 @@ struct dp_power { bool link_clks_on; }; +/** + * dp_power_init() - enable power supplies for display controller + * + * @power: instance of power module + * @flip: bool for flipping gpio direction + * return: 0 if success or error if failure. + * + * This API will turn on the regulators and configures gpio's + * aux/hpd. + */ int dp_power_init(struct dp_power *power, bool flip); + +/** + * dp_power_deinit() - turn off regulators and gpios. + * + * @power: instance of power module + * return: 0 for success + * + * This API turns off power and regulators. + */ int dp_power_deinit(struct dp_power *power); + +/** + * dp_power_clk_enable() - enable display controller clocks + * + * @power: instance of power module + * @pm_type: type of pm, core/ctrl/phy + * @enable: enables or disables + * return: pointer to allocated power module data + * + * This API will call setrate and enable for DP clocks + */ + int dp_power_clk_enable(struct dp_power *power, enum dp_pm_type pm_type, bool enable); +/** + * dp_power_set_link_clk_parent() - configures parent of link clocks + * + * @power: instance of power module + * return: 0 for success, error for failures + * + * This API will set the link clock parent source + */ int dp_power_set_link_clk_parent(struct dp_power *power); /** diff --git a/drivers/gpu/drm/msm/dp/dp_reg.h b/drivers/gpu/drm/msm/dp/dp_reg.h index 28c16822bb73..ad6f1760f893 100644 --- a/drivers/gpu/drm/msm/dp/dp_reg.h +++ b/drivers/gpu/drm/msm/dp/dp_reg.h @@ -6,6 +6,22 @@ #ifndef _DP_REG_H_ #define _DP_REG_H_ +/* DP PHY Register Regions */ +#define REG_DP_PHY_REGION_BASE (0x088ea000) +#define REG_DP_PHY_REGION_SIZE (0x00000C00) + +#define REG_USB3_DP_COM_REGION_BASE (0x088e8000) +#define REG_USB3_DP_COM_REGION_SIZE (0x00000020) + +#define DP_PHY_PLL_OFFSET (0x00000000) +#define DP_PHY_PLL_SIZE (0x00000200) +#define DP_PHY_REG_OFFSET (0x00000A00) +#define DP_PHY_REG_SIZE (0x00000200) +#define DP_PHY_LN_TX0_OFFSET (0x00000200) +#define DP_PHY_LN_TX0_SIZE (0x00000200) +#define DP_PHY_LN_TX1_OFFSET (0x00000600) +#define DP_PHY_LN_TX1_SIZE (0x00000200) + /* DP_TX Registers */ #define REG_DP_HW_VERSION (0x00000000)