mbox series

[00/21] ASoC: Intel: fix cppcheck warnings

Message ID 20200813200147.61990-1-pierre-louis.bossart@linux.intel.com (mailing list archive)
Headers show
Series ASoC: Intel: fix cppcheck warnings | expand

Message

Pierre-Louis Bossart Aug. 13, 2020, 8:01 p.m. UTC
This patchset tries to reduce the number of warnings on those drivers,
so that cppcheck can become a viable tool to detect issues (currently
hundreds of reports).

Most of the problems are related to unnecessary/redundant variable
assignments, prototypes and one nice logical mistake resulting in an
always-true condition.

Pierre-Louis Bossart (21):
  ASoC: Intel: Atom: sst-atom-controls: remove redundant assignments
  ASoC: Intel: Atom: compress: remove redundant assignment
  ASoC: Intel: Atom: platform-pcm: remove redundant assignment
  ASoC: Intel: Atom: sst: remove useless NULL assignment
  ASoC: Intel: Atom: remove redundant initialization
  ASoC: Intel: Atom: sst_pvt: remove redundant initialization
  ASoC: Intel: Atom: platform-pcm: fix redundant return
  ASoC: Intel: Atom: remove useless assignment
  ASoC: Intel: Atom: sst_loader: remove always-true condition
  ASoC: Intel: Atom: sst_pvt: simplify return handling
  ASoC: Intel: Atom: (cosmetic) align parameters
  ASoC: Intel: Baytrail: (cosmetic) align function parameters
  ASoC: Intel: common: (cosmetic) align function parameters
  ASoC: Intel: haswell: (cosmetic) align function parameters
  ASoC: Intel: haswell-ipc: remove redundant assignments
  ASoC: Intel: Skylake: skl-nhlt: remove redundant initialization
  ASoC: Intel: Skylake: cldma: remove redundant initialization
  ASoC: Intel: Skylake: sst-utils: remove redundant assignment
  ASoC: Intel: Skylake: skl-topology: remove redundant assignments
  ASoC: Intel: Skylake: skl-topology: remove redundant assignment
  ASoC: Intel: Skylake: (cosmetic) align function parameters

 sound/soc/intel/atom/sst-atom-controls.c      |  4 +--
 .../intel/atom/sst-mfld-platform-compress.c   |  3 +-
 sound/soc/intel/atom/sst-mfld-platform-pcm.c  |  4 +--
 sound/soc/intel/atom/sst-mfld-platform.h      |  4 +--
 sound/soc/intel/atom/sst/sst.c                |  5 ++-
 sound/soc/intel/atom/sst/sst.h                | 34 +++++++++----------
 sound/soc/intel/atom/sst/sst_loader.c         |  3 +-
 sound/soc/intel/atom/sst/sst_pvt.c            |  4 +--
 sound/soc/intel/baytrail/sst-baytrail-ipc.h   |  3 +-
 sound/soc/intel/common/sst-dsp-priv.h         |  2 +-
 sound/soc/intel/common/sst-dsp.h              | 15 ++++----
 sound/soc/intel/haswell/sst-haswell-ipc.c     |  4 +--
 sound/soc/intel/haswell/sst-haswell-ipc.h     |  2 +-
 sound/soc/intel/skylake/cnl-sst-dsp.h         |  4 +--
 sound/soc/intel/skylake/skl-nhlt.c            |  2 +-
 sound/soc/intel/skylake/skl-sst-cldma.c       |  2 +-
 sound/soc/intel/skylake/skl-sst-ipc.h         | 16 ++++-----
 sound/soc/intel/skylake/skl-sst-utils.c       |  2 +-
 sound/soc/intel/skylake/skl-topology.c        |  8 ++---
 sound/soc/intel/skylake/skl-topology.h        |  8 ++---
 sound/soc/intel/skylake/skl.h                 |  2 +-
 21 files changed, 63 insertions(+), 68 deletions(-)

Comments

Mark Brown Aug. 18, 2020, 4:54 p.m. UTC | #1
On Thu, 13 Aug 2020 15:01:26 -0500, Pierre-Louis Bossart wrote:
> This patchset tries to reduce the number of warnings on those drivers,
> so that cppcheck can become a viable tool to detect issues (currently
> hundreds of reports).
> 
> Most of the problems are related to unnecessary/redundant variable
> assignments, prototypes and one nice logical mistake resulting in an
> always-true condition.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/21] ASoC: Intel: Atom: sst-atom-controls: remove redundant assignments
        commit: c6a6586126d3f8010a181c01d4dd6aa90a953b66
[02/21] ASoC: Intel: Atom: compress: remove redundant assignment
        commit: b0a2a93dc3acb4c2868c60ef0d3278289a532816
[03/21] ASoC: Intel: Atom: platform-pcm: remove redundant assignment
        commit: b0754c55adf9a2aeb3c3732eb159615e91c70397
[04/21] ASoC: Intel: Atom: sst: remove useless NULL assignment
        commit: 4e3aab3217cdd1506ff89642e554995cbfa0806a
[05/21] ASoC: Intel: Atom: remove redundant initialization
        commit: 30701e0f3b1a134cbd000ca607a26342a10f6383
[06/21] ASoC: Intel: Atom: sst_pvt: remove redundant initialization
        commit: f3352e6b7c27078d9342c9faa8332b8113719f4b
[07/21] ASoC: Intel: Atom: platform-pcm: fix redundant return
        commit: 5ab56a224398a05ade1762d591321f238c284b19
[08/21] ASoC: Intel: Atom: remove useless assignment
        commit: eeb460f21250d46e5fa8e8429c38de47fe912481
[09/21] ASoC: Intel: Atom: sst_loader: remove always-true condition
        commit: b66a056e1539d8470013fff00f476377a616baa3
[10/21] ASoC: Intel: Atom: sst_pvt: simplify return handling
        commit: 7b99434c2c35e6045cc65992e3aaf231012e93ef
[11/21] ASoC: Intel: Atom: (cosmetic) align parameters
        commit: cfe8cc9419918bc56f528fa370aa8435d99b8353
[12/21] ASoC: Intel: Baytrail: (cosmetic) align function parameters
        commit: 0af1fcea054497ba784fc2d9b0125c4c2f6609e3
[13/21] ASoC: Intel: common: (cosmetic) align function parameters
        commit: 2b84a26f99762774b98fdb1e66be7400c0d22199
[14/21] ASoC: Intel: haswell: (cosmetic) align function parameters
        commit: c9b1f82d53930762094af0381c5dc7a8a2b6a86d
[15/21] ASoC: Intel: haswell-ipc: remove redundant assignments
        commit: 523615b716005b189f5a6cd9f7a255a902e45bce
[16/21] ASoC: Intel: Skylake: skl-nhlt: remove redundant initialization
        commit: 8be54edba9096056ff5d0fb2a29d0b3b962fa60c
[17/21] ASoC: Intel: Skylake: cldma: remove redundant initialization
        commit: 3b4d60f0f7dd13594916bcd6644ea6208597d993
[18/21] ASoC: Intel: Skylake: sst-utils: remove redundant assignment
        commit: c6193988e945b658bffd09174edae1b43b8ab0b6
[19/21] ASoC: Intel: Skylake: skl-topology: remove redundant assignments
        commit: 25722cf606f6c58b1f2f709434aeb418c4b0b1ca
[20/21] ASoC: Intel: Skylake: skl-topology: remove redundant assignment
        commit: 11a790f94b340c3deb893c6229c3948233a91a4a
[21/21] ASoC: Intel: Skylake: (cosmetic) align function parameters
        commit: 8f0ccd59bcc9305241507cb48c6aaa08a9f375c8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark