| Message ID | 1597892486-3236-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: adi-axi-adc: Use kobj_to_dev() instead of container_of() | expand |
On Thu, Aug 20, 2020 at 6:04 AM Tian Tao <tiantao6@hisilicon.com> wrote: > > Use kobj_to_dev() instead of container_of() > Good point. Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> > --- > drivers/iio/adc/adi-axi-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > index 86b6b65..9109da2 100644 > --- a/drivers/iio/adc/adi-axi-adc.c > +++ b/drivers/iio/adc/adi-axi-adc.c > @@ -276,7 +276,7 @@ static struct attribute *adi_axi_adc_attributes[] = { > static umode_t axi_adc_attr_is_visible(struct kobject *kobj, > struct attribute *attr, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct iio_dev *indio_dev = dev_to_iio_dev(dev); > struct adi_axi_adc_state *st = iio_priv(indio_dev); > struct adi_axi_adc_conv *conv = &st->client->conv; > -- > 2.7.4 >
On Thu, Aug 20, 2020 at 12:10 PM Alexandru Ardelean <ardeleanalex@gmail.com> wrote: > On Thu, Aug 20, 2020 at 6:04 AM Tian Tao <tiantao6@hisilicon.com> wrote: > > > > Use kobj_to_dev() instead of container_of() > Good point. > > Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> ... > > - struct device *dev = container_of(kobj, struct device, kobj); > > + struct device *dev = kobj_to_dev(kobj); > > struct iio_dev *indio_dev = dev_to_iio_dev(dev); And now this can be one line since dev is not used separately. > > struct adi_axi_adc_state *st = iio_priv(indio_dev); > > struct adi_axi_adc_conv *conv = &st->client->conv;
On Thu, Aug 20, 2020 at 4:05 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Aug 20, 2020 at 12:10 PM Alexandru Ardelean > <ardeleanalex@gmail.com> wrote: > > On Thu, Aug 20, 2020 at 6:04 AM Tian Tao <tiantao6@hisilicon.com> wrote: > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > + struct device *dev = kobj_to_dev(kobj); > And now this can be one line since dev is not used separately. On the other hand perhaps one object per line is better to read.
On Thu, 20 Aug 2020 16:07:04 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Aug 20, 2020 at 4:05 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Thu, Aug 20, 2020 at 12:10 PM Alexandru Ardelean > > <ardeleanalex@gmail.com> wrote: > > > On Thu, Aug 20, 2020 at 6:04 AM Tian Tao <tiantao6@hisilicon.com> wrote: > > > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > > + struct device *dev = kobj_to_dev(kobj); > > > And now this can be one line since dev is not used separately. > > On the other hand perhaps one object per line is better to read. > Indeed, not clear one way or the others, so I'm going with the path of least resistance. Applied as is. Thanks, Jonathan
diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c index 86b6b65..9109da2 100644 --- a/drivers/iio/adc/adi-axi-adc.c +++ b/drivers/iio/adc/adi-axi-adc.c @@ -276,7 +276,7 @@ static struct attribute *adi_axi_adc_attributes[] = { static umode_t axi_adc_attr_is_visible(struct kobject *kobj, struct attribute *attr, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct adi_axi_adc_state *st = iio_priv(indio_dev); struct adi_axi_adc_conv *conv = &st->client->conv;
Use kobj_to_dev() instead of container_of() Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/iio/adc/adi-axi-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)