diff mbox series

[09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen

Message ID 20200830135200.24304-9-krzk@kernel.org (mailing list archive)
State Rejected
Headers show
Series [01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 | expand

Commit Message

Krzysztof Kozlowski Aug. 30, 2020, 1:51 p.m. UTC 
The PMIC has a 32768 Hz clock used by the modem which is implemented by
driver as a regulator.  Add and enable it to be sure modem get's its
signal.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Marek Szyprowski Aug. 31, 2020, 9:16 a.m. UTC | #1 
Hi Krzysztof,

On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> The PMIC has a 32768 Hz clock used by the modem which is implemented by
> driver as a regulator.  Add and enable it to be sure modem get's its
> signal.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Origen board doesn't have any modem/cp, so I see no point in enabling 
this clock.

> ---
>   arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
> index 747221bbb856..fcf45619a3e4 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -298,6 +298,11 @@
>   				regulator-name = "EN32KHZ_AP";
>   				regulator-always-on;
>   			};
> +
> +			EN32KHZ_CP {
> +				regulator-name = "EN32KHZ_CP";
> +				regulator-always-on;
> +			};
>   		};
>   	};
>   };

Best regards
Krzysztof Kozlowski Aug. 31, 2020, 9:37 a.m. UTC | #2 
On Mon, 31 Aug 2020 at 11:16, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Hi Krzysztof,
>
> On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> > The PMIC has a 32768 Hz clock used by the modem which is implemented by
> > driver as a regulator.  Add and enable it to be sure modem get's its
> > signal.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Origen board doesn't have any modem/cp, so I see no point in enabling
> this clock.

Good point, thanks for review.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 747221bbb856..fcf45619a3e4 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -298,6 +298,11 @@ 
 				regulator-name = "EN32KHZ_AP";
 				regulator-always-on;
 			};
+
+			EN32KHZ_CP {
+				regulator-name = "EN32KHZ_CP";
+				regulator-always-on;
+			};
 		};
 	};
 };