| Message ID | 3a5c9483-954d-e045-7ebe-645250d61efe@sandeen.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mkfs.xfs: remove comment about needed future work | expand |
On Thu, Aug 27, 2020 at 02:37:17PM -0500, Eric Sandeen wrote: > Remove comment about the need to sync this function with the > kernel; that was mostly taken care of with: > > 7b7548052 ("mkfs: use libxfs to write out new AGs") > > There's maybe a little more samey-samey that we could do here, > but it's not egregiously cut & pasted as it was before. > > Signed-off-by: Eric Sandeen <sandeen2redhat.com> > --- Reviewed-by: Brian Foster <bfoster@redhat.com> > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index a687f385..874e40da 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -3418,11 +3418,6 @@ prepare_devices( > > } > > -/* > - * XXX: this code is mostly common with the kernel growfs code. > - * These initialisations should be pulled into libxfs to keep the > - * kernel/userspace header initialisation code the same. > - */ > static void > initialise_ag_headers( > struct mkfs_params *cfg, >
On Thu, Aug 27, 2020 at 02:37:17PM -0500, Eric Sandeen wrote: > Remove comment about the need to sync this function with the > kernel; that was mostly taken care of with: > > 7b7548052 ("mkfs: use libxfs to write out new AGs") > > There's maybe a little more samey-samey that we could do here, > but it's not egregiously cut & pasted as it was before. > > Signed-off-by: Eric Sandeen <sandeen2redhat.com> Fixes: 7b7548052d12 ("mkfs: use libxfs to write out new AGs") Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index a687f385..874e40da 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -3418,11 +3418,6 @@ prepare_devices( > > } > > -/* > - * XXX: this code is mostly common with the kernel growfs code. > - * These initialisations should be pulled into libxfs to keep the > - * kernel/userspace header initialisation code the same. > - */ > static void > initialise_ag_headers( > struct mkfs_params *cfg, >
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index a687f385..874e40da 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -3418,11 +3418,6 @@ prepare_devices( } -/* - * XXX: this code is mostly common with the kernel growfs code. - * These initialisations should be pulled into libxfs to keep the - * kernel/userspace header initialisation code the same. - */ static void initialise_ag_headers( struct mkfs_params *cfg,
Remove comment about the need to sync this function with the kernel; that was mostly taken care of with: 7b7548052 ("mkfs: use libxfs to write out new AGs") There's maybe a little more samey-samey that we could do here, but it's not egregiously cut & pasted as it was before. Signed-off-by: Eric Sandeen <sandeen2redhat.com> ---