diff mbox series

[v1] libxc: use bitmap_alloc

Message ID 20200909095344.9462-1-olaf@aepfle.de (mailing list archive)
State New, archived
Headers show
Series [v1] libxc: use bitmap_alloc | expand

Commit Message

Olaf Hering Sept. 9, 2020, 9:53 a.m. UTC 
Use existing helper to allocate a bitmap.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 tools/libxc/xc_sr_save.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Cooper Sept. 9, 2020, 10:01 a.m. UTC | #1 
On 09/09/2020 10:53, Olaf Hering wrote:
> Use existing helper to allocate a bitmap.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Wei Liu Sept. 9, 2020, 11:10 a.m. UTC | #2 
On Wed, Sep 09, 2020 at 11:01:19AM +0100, Andrew Cooper wrote:
> On 09/09/2020 10:53, Olaf Hering wrote:
> > Use existing helper to allocate a bitmap.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Wei Liu <wl@xen.org>

I've rebased pushed this patch to staging to save another round of
posting. Please check if there is any issue.

Wei.
diff mbox series

Patch

diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
index 80b1d5de1f..bc5a1a723c 100644
--- a/tools/libxc/xc_sr_save.c
+++ b/tools/libxc/xc_sr_save.c
@@ -809,7 +809,7 @@  static int setup(struct xc_sr_context *ctx)
         xch, dirty_bitmap, NRPAGES(bitmap_size(ctx->save.p2m_size)));
     ctx->save.batch_pfns = malloc(MAX_BATCH_SIZE *
                                   sizeof(*ctx->save.batch_pfns));
-    ctx->save.deferred_pages = calloc(1, bitmap_size(ctx->save.p2m_size));
+    ctx->save.deferred_pages = bitmap_alloc(ctx->save.p2m_size);
 
     if ( !ctx->save.batch_pfns || !dirty_bitmap || !ctx->save.deferred_pages )
     {