Message ID | 20200908115322.325832-1-kwolf@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [PULL,v2] Block layer patches | expand |
On Tue, 8 Sep 2020 at 12:53, Kevin Wolf <kwolf@redhat.com> wrote: > > The following changes since commit 7c37270b3fbe3d034ba80e488761461676e21eb4: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200904-pull-request' into staging (2020-09-06 16:23:55 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to c984095a47c30e0952d34e77decf9f4c0f8d5a19: > > block/nvme: Pair doorbell registers (2020-09-08 13:40:53 +0200) > > ---------------------------------------------------------------- > Block layer patches: > > - qemu-img create: Fail gracefully when backing file is an empty string > - Fixes related to filter block nodes ("Deal with filters" series) > - block/nvme: Various cleanups required to use multiple queues > - block/nvme: Use NvmeBar structure from "block/nvme.h" > - file-win32: Fix "locking" option > - iotests: Allow running from different directory This fails 'make check' on NetBSD and OpenBSD: ./check: line 47: realpath: command not found ./check: line 60: /common.env: No such file or directory check: failed to source common.env (make sure the qemu-iotests are run from tests/qemu-iotests in the build tree) gmake: *** [/home/qemu/qemu-test.vcb7nz/src/tests/Makefile.include:144: check-block] Error 1 thanks -- PMM
On 9/9/20 4:55 PM, Peter Maydell wrote: > > This fails 'make check' on NetBSD and OpenBSD: > > ./check: line 47: realpath: command not found > ./check: line 60: /common.env: No such file or directory > check: failed to source common.env (make sure the qemu-iotests are run > from tests/qemu-iotests in the build tree) > gmake: *** [/home/qemu/qemu-test.vcb7nz/src/tests/Makefile.include:144: > check-block] Error 1 BSD has 'readlink -f' (and so does coreutils on Linux), which does the same thing as the Linux-only realpath.
Am 10.09.2020 um 00:09 hat Eric Blake geschrieben: > On 9/9/20 4:55 PM, Peter Maydell wrote: > > > > > This fails 'make check' on NetBSD and OpenBSD: > > > > ./check: line 47: realpath: command not found > > ./check: line 60: /common.env: No such file or directory > > check: failed to source common.env (make sure the qemu-iotests are run > > from tests/qemu-iotests in the build tree) > > gmake: *** [/home/qemu/qemu-test.vcb7nz/src/tests/Makefile.include:144: > > check-block] Error 1 > > BSD has 'readlink -f' (and so does coreutils on Linux), which does the same > thing as the Linux-only realpath. Thanks, I'll use that in v3. Max, if v3 doesn't go through either, please take over the pull request as I will be on PTO until the 22th. Kevin
On 10.09.20 11:13, Kevin Wolf wrote: > Am 10.09.2020 um 00:09 hat Eric Blake geschrieben: >> On 9/9/20 4:55 PM, Peter Maydell wrote: >> >>> >>> This fails 'make check' on NetBSD and OpenBSD: >>> >>> ./check: line 47: realpath: command not found >>> ./check: line 60: /common.env: No such file or directory >>> check: failed to source common.env (make sure the qemu-iotests are run >>> from tests/qemu-iotests in the build tree) >>> gmake: *** [/home/qemu/qemu-test.vcb7nz/src/tests/Makefile.include:144: >>> check-block] Error 1 >> >> BSD has 'readlink -f' (and so does coreutils on Linux), which does the same >> thing as the Linux-only realpath. > > Thanks, I'll use that in v3. > > Max, if v3 doesn't go through either, please take over the pull request > as I will be on PTO until the 22th. OK, sure. (Enjoy your time off. :)) Max
On 10/09/2020 00.09, Eric Blake wrote: > On 9/9/20 4:55 PM, Peter Maydell wrote: > >> >> This fails 'make check' on NetBSD and OpenBSD: >> >> ./check: line 47: realpath: command not found >> ./check: line 60: /common.env: No such file or directory >> check: failed to source common.env (make sure the qemu-iotests are run >> from tests/qemu-iotests in the build tree) >> gmake: *** [/home/qemu/qemu-test.vcb7nz/src/tests/Makefile.include:144: >> check-block] Error 1 > > BSD has 'readlink -f' (and so does coreutils on Linux), which does the > same thing as the Linux-only realpath. Seems like readlink -f does not work on macOS: https://cirrus-ci.com/task/5735398972325888?command=main#L7038 Any ideas what to use instead? Peter, why did this slip through your merge tests, do you still skip the iotests there? Thomas
On Sat, 12 Sep 2020 at 13:27, Thomas Huth <thuth@redhat.com> wrote: > Peter, why did this slip through your merge tests, do you still skip the > iotests there? I forget what the reason for them being skipped is, maybe it's because they demand a gnu sed ? thanks -- PMM
On 12/09/2020 20.38, Peter Maydell wrote: > On Sat, 12 Sep 2020 at 13:27, Thomas Huth <thuth@redhat.com> wrote: >> Peter, why did this slip through your merge tests, do you still skip the >> iotests there? > > I forget what the reason for them being skipped is, maybe > it's because they demand a gnu sed ? The tests/check-block.sh script should tell you when you run "make check-block" ... but yes, they need gnu sed - which should be available via homebrew. Thomas