diff mbox series

ath11k: remove calling ath11k_init_hw_params() second time

Message ID 010101746d2a40d3-25cd7dbe-c0dd-4fdf-8735-366d7fb40207-000000@us-west-2.amazonses.com (mailing list archive)
State Accepted
Commit a9d9e03858ad418c6dc91658b3e9ba936668dffe
Delegated to: Kalle Valo
Headers show
Series ath11k: remove calling ath11k_init_hw_params() second time | expand

Commit Message

Anilkumar Kolli Sept. 8, 2020, 10:01 a.m. UTC
During probe ath11k_init_hw_params() is called from ath11k_core_pre_init()
and is not needed agian in ath11k_core_init().

Tested on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

Fixes: 1ff8ed786d5d (ath11k: use remoteproc only with AHB devices)
Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/core.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Kalle Valo Sept. 11, 2020, 9:57 a.m. UTC | #1
Anilkumar Kolli <akolli@codeaurora.org> wrote:

> During probe ath11k_init_hw_params() is called from ath11k_core_pre_init()
> and is not needed agian in ath11k_core_init().
> 
> Tested on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1
> 
> Fixes: 1ff8ed786d5d (ath11k: use remoteproc only with AHB devices)
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

a9d9e03858ad ath11k: remove calling ath11k_init_hw_params() second time
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 648a697e414a..03e922111cd6 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -849,12 +849,6 @@  int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}
 
-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}
-
 	ret = ath11k_core_soc_create(ab);
 	if (ret) {
 		ath11k_err(ab, "failed to create soc core: %d\n", ret);