| Message ID | 1597286952-5706-1-git-send-email-wangqing@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi/nfit: Use kobj_to_dev() instead | expand |
On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote: > > Use kobj_to_dev() instead of container_of() > > Signed-off-by: Wang Qing <wangqing@vivo.com> LGTM Dan, any objections? > --- > drivers/acpi/nfit/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index fa4500f..3bb350b > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, > struct attribute *a, int n) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct nvdimm *nvdimm = to_nvdimm(dev); > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > > -- > 2.7.4 >
On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote: > On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote: > > Use kobj_to_dev() instead of container_of() > > > > Signed-off-by: Wang Qing <wangqing@vivo.com> > > LGTM > > Dan, any objections? Looks good to me - you can add: Acked-by: Vishal Verma <vishal.l.verma@intel.com> > > > --- > > drivers/acpi/nfit/core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > > index fa4500f..3bb350b > > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) > > > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) > > { > > - struct device *dev = container_of(kobj, struct device, kobj); > > + struct device *dev = kobj_to_dev(kobj); > > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); > > > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) > > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { > > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, > > struct attribute *a, int n) > > { > > - struct device *dev = container_of(kobj, struct device, kobj); > > + struct device *dev = kobj_to_dev(kobj); > > struct nvdimm *nvdimm = to_nvdimm(dev); > > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > > > > -- > > 2.7.4 > >
On Sat, Aug 15, 2020 at 12:52 AM Verma, Vishal L <vishal.l.verma@intel.com> wrote: > > On Fri, 2020-08-14 at 17:28 +0200, Rafael J. Wysocki wrote: > > On Thu, Aug 13, 2020 at 4:54 AM Wang Qing <wangqing@vivo.com> wrote: > > > Use kobj_to_dev() instead of container_of() > > > > > > Signed-off-by: Wang Qing <wangqing@vivo.com> > > > > LGTM > > > > Dan, any objections? > > Looks good to me - you can add: > Acked-by: Vishal Verma <vishal.l.verma@intel.com> Applied as 5.10 material, thanks! > > > --- > > > drivers/acpi/nfit/core.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > > > index fa4500f..3bb350b > > > --- a/drivers/acpi/nfit/core.c > > > +++ b/drivers/acpi/nfit/core.c > > > @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) > > > > > > static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) > > > { > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > + struct device *dev = kobj_to_dev(kobj); > > > struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); > > > > > > if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) > > > @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { > > > static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, > > > struct attribute *a, int n) > > > { > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > + struct device *dev = kobj_to_dev(kobj); > > > struct nvdimm *nvdimm = to_nvdimm(dev); > > > struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm); > > > > > > -- > > > 2.7.4 > > >
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index fa4500f..3bb350b --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -1382,7 +1382,7 @@ static bool ars_supported(struct nvdimm_bus *nvdimm_bus) static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct nvdimm_bus *nvdimm_bus = to_nvdimm_bus(dev); if (a == &dev_attr_scrub.attr && !ars_supported(nvdimm_bus)) @@ -1667,7 +1667,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, struct attribute *a, int n) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct nvdimm *nvdimm = to_nvdimm(dev); struct nfit_mem *nfit_mem = nvdimm_provider_data(nvdimm);
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing <wangqing@vivo.com> --- drivers/acpi/nfit/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)