Message ID | 20200909160409.8678-6-narmstrong@baylibre.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | usb: dwc-meson-g12a: Add support for USB on S400 board | expand |
Hi Neil, On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote: [...] > +&usb { > + status = "okay"; > + dr_mode = "otg"; > + vbus-supply = <&usb_pwr>; > +}; > + > +&usb2_phy1 { > + phy-supply = <&vcc_5v>; out of curiosity: why do we need this phy-supply here? isn't the usb_pwr regulator as vbus-supply above enough? Best regards, Martin
On 15/09/2020 22:05, Martin Blumenstingl wrote: > Hi Neil, > > On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > [...] >> +&usb { >> + status = "okay"; >> + dr_mode = "otg"; >> + vbus-supply = <&usb_pwr>; >> +}; >> + >> +&usb2_phy1 { >> + phy-supply = <&vcc_5v>; > out of curiosity: why do we need this phy-supply here? > isn't the usb_pwr regulator as vbus-supply above enough? Damn you're right ! Thanks for noticing. Neil > > > Best regards, > Martin >
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts index cb1360ae1211..5f131debcbad 100644 --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts @@ -584,3 +584,13 @@ pinctrl-0 = <&uart_ao_a_pins>; pinctrl-names = "default"; }; + +&usb { + status = "okay"; + dr_mode = "otg"; + vbus-supply = <&usb_pwr>; +}; + +&usb2_phy1 { + phy-supply = <&vcc_5v>; +};
This enables USB OTG on the S400 board. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)