| Message ID | 20200911044439.13842-1-kohada.t2@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] exfat: remove useless directory scan in exfat_add_entry() | expand |
> There is nothing in directory just created, so there is no need to scan. > > Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com> Acked-by: Sungjong Seo <sj1557.seo@samsung.com> > --- > fs/exfat/namei.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index > b966b9120c9c..803748946ddb 100644 > --- a/fs/exfat/namei.c > +++ b/fs/exfat/namei.c > @@ -530,19 +530,10 @@ static int exfat_add_entry(struct inode *inode, > const char *path, > info->size = 0; > info->num_subdirs = 0; > } else { > - int count; > - struct exfat_chain cdir; > - > info->attr = ATTR_SUBDIR; > info->start_clu = start_clu; > info->size = clu_size; > - > - exfat_chain_set(&cdir, info->start_clu, > - EXFAT_B_TO_CLU(info->size, sbi), info->flags); > - count = exfat_count_dir_entries(sb, &cdir); > - if (count < 0) > - return -EIO; > - info->num_subdirs = count + EXFAT_MIN_SUBDIR; > + info->num_subdirs = EXFAT_MIN_SUBDIR; > } > memset(&info->crtime, 0, sizeof(info->crtime)); > memset(&info->mtime, 0, sizeof(info->mtime)); > -- > 2.25.1
2020-09-15 19:22 GMT-07:00, Sungjong Seo <sj1557.seo@samsung.com>: >> There is nothing in directory just created, so there is no need to scan. >> >> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com> > > Acked-by: Sungjong Seo <sj1557.seo@samsung.com> Applied. Thanks for your patch!
diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index b966b9120c9c..803748946ddb 100644 --- a/fs/exfat/namei.c +++ b/fs/exfat/namei.c @@ -530,19 +530,10 @@ static int exfat_add_entry(struct inode *inode, const char *path, info->size = 0; info->num_subdirs = 0; } else { - int count; - struct exfat_chain cdir; - info->attr = ATTR_SUBDIR; info->start_clu = start_clu; info->size = clu_size; - - exfat_chain_set(&cdir, info->start_clu, - EXFAT_B_TO_CLU(info->size, sbi), info->flags); - count = exfat_count_dir_entries(sb, &cdir); - if (count < 0) - return -EIO; - info->num_subdirs = count + EXFAT_MIN_SUBDIR; + info->num_subdirs = EXFAT_MIN_SUBDIR; } memset(&info->crtime, 0, sizeof(info->crtime)); memset(&info->mtime, 0, sizeof(info->mtime));
There is nothing in directory just created, so there is no need to scan. Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com> --- fs/exfat/namei.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)