| Message ID | 20200918190548.12598-1-dmurphy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/9] ASoC: tas2770: Fix calling reset in probe | expand |
On Fri, 18 Sep 2020 14:05:40 -0500, Dan Murphy wrote: > tas2770_reset is called during i2c probe. The reset calls the > snd_soc_component_write which depends on the tas2770->component being > available. The component pointer is not set until codec_probe so move > the reset to the codec_probe after the pointer is set. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] dt-bindings: tas2770: Fix I2C addresses for the TAS2770 commit: b23d9eb897a1209e4d741fd69e5490f1b5b9e7cf [2/5] ASoC: tas2770: Fix unbalanced calls to pm_runtime commit: d3d71c99b541040da198f43da3bbd85d8e9598cb [3/5] ASoC: tas2770: Convert bit mask to GENMASK in header commit: ec9377dca2ca77eaf4fbdb09ac803f379b10d731 [4/5] ASoC: tas2770: Fix the spacing and new lines commit: d3964aff7331cd9695d0c18655e053b08837ff78 [5/5] ASoC: tas2770: Refactor sample rate function commit: be05ab41c61858cce557a1fe863ed00f38e31e97 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index c09851834395..03d7ad1885b8 100644 --- a/sound/soc/codecs/tas2770.c +++ b/sound/soc/codecs/tas2770.c @@ -575,6 +575,8 @@ static int tas2770_codec_probe(struct snd_soc_component *component) tas2770->component = component; + tas2770_reset(tas2770); + return 0; } @@ -771,8 +773,6 @@ static int tas2770_i2c_probe(struct i2c_client *client, tas2770->channel_size = 0; tas2770->slot_width = 0; - tas2770_reset(tas2770); - result = tas2770_register_codec(tas2770); if (result) dev_err(tas2770->dev, "Register codec failed.\n");
tas2770_reset is called during i2c probe. The reset calls the snd_soc_component_write which depends on the tas2770->component being available. The component pointer is not set until codec_probe so move the reset to the codec_probe after the pointer is set. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy <dmurphy@ti.com> --- sound/soc/codecs/tas2770.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)