| Message ID | 1600601186-7420-15-git-send-email-Julia.Lawall@inria.fr (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | drop double zeroing | expand |
On Sun, Sep 20, 2020 at 01:26:26PM +0200, Julia Lawall wrote: > sg_init_table zeroes its first argument, so the allocation of that argument > doesn't have to. > > the semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x; > @@ > > x = > - kzalloc > + kmalloc > (...) > ... > sg_init_table(x,...) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Applied to pci/misc for v5.10, thanks! > --- > drivers/pci/p2pdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -762,7 +762,7 @@ struct scatterlist *pci_p2pmem_alloc_sgl > struct scatterlist *sg; > void *addr; > > - sg = kzalloc(sizeof(*sg), GFP_KERNEL); > + sg = kmalloc(sizeof(*sg), GFP_KERNEL); > if (!sg) > return NULL; > >
diff -u -p a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c --- a/drivers/pci/p2pdma.c +++ b/drivers/pci/p2pdma.c @@ -762,7 +762,7 @@ struct scatterlist *pci_p2pmem_alloc_sgl struct scatterlist *sg; void *addr; - sg = kzalloc(sizeof(*sg), GFP_KERNEL); + sg = kmalloc(sizeof(*sg), GFP_KERNEL); if (!sg) return NULL;
sg_init_table zeroes its first argument, so the allocation of that argument doesn't have to. the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x; @@ x = - kzalloc + kmalloc (...) ... sg_init_table(x,...) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> --- drivers/pci/p2pdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)