| Message ID | 20200930065617.934638-1-palmerdabbelt@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clocksource: clint: Export clint_time_val for modules | expand |
On Tue, Sep 29, 2020 at 11:56:18PM -0700, Palmer Dabbelt wrote: > clint_time_val will soon be used by the RISC-V implementation of > random_get_entropy(), which is a static inline function that may be used by > modules (at least CRYPTO_JITTERENTROPY=m). At very least this needs to be an EXPORT_SYMBOL_GPL. But I really don't think modules have any business using get_cycles, so I'd much rather fix CRYPTO_JITTERENTROPY to be required to be build in. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com> > --- > drivers/clocksource/timer-clint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-clint.c > index d17367dee02c..6cfe2ab73eb0 100644 > --- a/drivers/clocksource/timer-clint.c > +++ b/drivers/clocksource/timer-clint.c > @@ -38,6 +38,7 @@ static unsigned int clint_timer_irq; > > #ifdef CONFIG_RISCV_M_MODE > u64 __iomem *clint_time_val; > +EXPORT_SYMBOL(clint_time_val); > #endif > > static void clint_send_ipi(const struct cpumask *target) > -- > 2.28.0.709.gb0816b6eb0-goog > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv ---end quoted text---
Am Freitag, 2. Oktober 2020, 08:49:05 CEST schrieb Christoph Hellwig: Hi Christoph, > On Tue, Sep 29, 2020 at 11:56:18PM -0700, Palmer Dabbelt wrote: > > clint_time_val will soon be used by the RISC-V implementation of > > random_get_entropy(), which is a static inline function that may be used > > by > > modules (at least CRYPTO_JITTERENTROPY=m). > > At very least this needs to be an EXPORT_SYMBOL_GPL. But I really don't > think modules have any business using get_cycles, so I'd much rather > fix CRYPTO_JITTERENTROPY to be required to be build in. Changing CRYPTO_JITTERENTROPY from tistate to bool should be no problem. I will provide a patch. Ciao Stephan
diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-clint.c index d17367dee02c..6cfe2ab73eb0 100644 --- a/drivers/clocksource/timer-clint.c +++ b/drivers/clocksource/timer-clint.c @@ -38,6 +38,7 @@ static unsigned int clint_timer_irq; #ifdef CONFIG_RISCV_M_MODE u64 __iomem *clint_time_val; +EXPORT_SYMBOL(clint_time_val); #endif static void clint_send_ipi(const struct cpumask *target)
clint_time_val will soon be used by the RISC-V implementation of random_get_entropy(), which is a static inline function that may be used by modules (at least CRYPTO_JITTERENTROPY=m). Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com> --- drivers/clocksource/timer-clint.c | 1 + 1 file changed, 1 insertion(+)