| Message ID | 20201001190456.2860155-1-atish.patra@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RISC-V: Make sure memblock reserves the memory containing DT | expand |
On Fri, Oct 2, 2020 at 12:35 AM Atish Patra <atish.patra@wdc.com> wrote: > > Currently, the memory containing DT is not reserved. Thus, that region > of memory can be reallocated or reused for other purposes. This may result > in corrupted DT for nommu virt board in Qemu. We may not face any issue > in kendryte as DT is embedded in the kernel image for that. > > Fixes: 6bd33e1ece52 ("riscv: add nommu support") > Signed-off-by: Atish Patra <atish.patra@wdc.com> > > --- > @Palmer This patch is applicable for v5.9 & before. This fix is already > part of the "RISC-V: Move DT mapping outof fixmap" patch from UEFI support > series. That's why, this patch doesn't need to go into for-next. > --- > arch/riscv/mm/init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 564e0be677b7..cabf1697e748 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -510,6 +510,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa) > #else > dtb_early_va = (void *)dtb_pa; > #endif > + dtb_early_pa = dtb_pa; > } > > static inline void setup_vm_final(void) > -- > 2.25.1 > Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup
On Thu, 01 Oct 2020 12:04:56 PDT (-0700), Atish Patra wrote: > Currently, the memory containing DT is not reserved. Thus, that region > of memory can be reallocated or reused for other purposes. This may result > in corrupted DT for nommu virt board in Qemu. We may not face any issue > in kendryte as DT is embedded in the kernel image for that. > > Fixes: 6bd33e1ece52 ("riscv: add nommu support") > Signed-off-by: Atish Patra <atish.patra@wdc.com> > > --- > @Palmer This patch is applicable for v5.9 & before. This fix is already > part of the "RISC-V: Move DT mapping outof fixmap" patch from UEFI support > series. That's why, this patch doesn't need to go into for-next. > --- > arch/riscv/mm/init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 564e0be677b7..cabf1697e748 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -510,6 +510,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa) > #else > dtb_early_va = (void *)dtb_pa; > #endif > + dtb_early_pa = dtb_pa; > } > > static inline void setup_vm_final(void) Thanks, this is on fixes.
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 564e0be677b7..cabf1697e748 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -510,6 +510,7 @@ asmlinkage void __init setup_vm(uintptr_t dtb_pa) #else dtb_early_va = (void *)dtb_pa; #endif + dtb_early_pa = dtb_pa; } static inline void setup_vm_final(void)
Currently, the memory containing DT is not reserved. Thus, that region of memory can be reallocated or reused for other purposes. This may result in corrupted DT for nommu virt board in Qemu. We may not face any issue in kendryte as DT is embedded in the kernel image for that. Fixes: 6bd33e1ece52 ("riscv: add nommu support") Signed-off-by: Atish Patra <atish.patra@wdc.com> --- @Palmer This patch is applicable for v5.9 & before. This fix is already part of the "RISC-V: Move DT mapping outof fixmap" patch from UEFI support series. That's why, this patch doesn't need to go into for-next. --- arch/riscv/mm/init.c | 1 + 1 file changed, 1 insertion(+)