| Message ID | iwlwifi.20201008181047.d0e2253c282f.Icd2ff00adff52f6c96fb261c34fbf129ce67a00d@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8fac81b5005926b1d71473816aca439b9c142a6a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | iwlwifi: updates intended for v5.10 2020-10-08 part 2 | expand |
Luca Coelho <luca@coelho.fi> writes: > From: Luca Coelho <luciano.coelho@intel.com> > > We were using 5 ms for some qu devices, but their xtal stabilizes > much faster than that. Reduce the value to 500 ms. > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > --- > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > index 60e0640d07dc..8b97c2eb2632 100644 > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = { > .device_family = IWL_DEVICE_FAMILY_22000, > .base_params = &iwl_22000_base_params, > .integrated = true, > - .xtal_latency = 5000, > + .xtal_latency = 500, > .ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US, > }; The commit log doesn't make sense, I'll do s/5 ms/5 s/ during commit.
On Thu, 2020-10-08 at 18:47 +0300, Kalle Valo wrote: > Luca Coelho <luca@coelho.fi> writes: > > > From: Luca Coelho <luciano.coelho@intel.com> > > > > We were using 5 ms for some qu devices, but their xtal stabilizes > > much faster than that. Reduce the value to 500 ms. > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > > --- > > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > > index 60e0640d07dc..8b97c2eb2632 100644 > > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > > @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = { > > .device_family = IWL_DEVICE_FAMILY_22000, > > .base_params = &iwl_22000_base_params, > > .integrated = true, > > - .xtal_latency = 5000, > > + .xtal_latency = 500, > > .ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US, > > }; > > The commit log doesn't make sense, I'll do s/5 ms/5 s/ during commit. Hmmm, indeed it doesn't make sense like that. But I actually think the 5 ms is correct, but the other one should be 500 microseconds. -- Luca.
Luca Coelho <luca@coelho.fi> writes: > On Thu, 2020-10-08 at 18:47 +0300, Kalle Valo wrote: >> Luca Coelho <luca@coelho.fi> writes: >> >> > From: Luca Coelho <luciano.coelho@intel.com> >> > >> > We were using 5 ms for some qu devices, but their xtal stabilizes >> > much faster than that. Reduce the value to 500 ms. >> > >> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> >> > --- >> > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c >> > index 60e0640d07dc..8b97c2eb2632 100644 >> > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c >> > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c >> > @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = { >> > .device_family = IWL_DEVICE_FAMILY_22000, >> > .base_params = &iwl_22000_base_params, >> > .integrated = true, >> > - .xtal_latency = 5000, >> > + .xtal_latency = 500, >> > .ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US, >> > }; >> >> The commit log doesn't make sense, I'll do s/5 ms/5 s/ during commit. > > Hmmm, indeed it doesn't make sense like that. But I actually think the > 5 ms is correct, but the other one should be 500 microseconds. Oh, didn't think of that. And it's too late to fix it now.
On Fri, 2020-10-09 at 10:35 +0300, Kalle Valo wrote: > Luca Coelho <luca@coelho.fi> writes: > > > On Thu, 2020-10-08 at 18:47 +0300, Kalle Valo wrote: > > > Luca Coelho <luca@coelho.fi> writes: > > > > > > > From: Luca Coelho <luciano.coelho@intel.com> > > > > > > > > We were using 5 ms for some qu devices, but their xtal stabilizes > > > > much faster than that. Reduce the value to 500 ms. > > > > > > > > Signed-off-by: Luca Coelho <luciano.coelho@intel.com> > > > > --- > > > > drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > > > > index 60e0640d07dc..8b97c2eb2632 100644 > > > > --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > > > > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c > > > > @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = { > > > > .device_family = IWL_DEVICE_FAMILY_22000, > > > > .base_params = &iwl_22000_base_params, > > > > .integrated = true, > > > > - .xtal_latency = 5000, > > > > + .xtal_latency = 500, > > > > .ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US, > > > > }; > > > > > > The commit log doesn't make sense, I'll do s/5 ms/5 s/ during commit. > > > > Hmmm, indeed it doesn't make sense like that. But I actually think the > > 5 ms is correct, but the other one should be 500 microseconds. > > Oh, didn't think of that. And it's too late to fix it now. Yeah, doesn't really matter. FWIW, I double-checked and indeed these values are in usecs. -- Cheers, Luca.
diff --git a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c index 60e0640d07dc..8b97c2eb2632 100644 --- a/drivers/net/wireless/intel/iwlwifi/cfg/22000.c +++ b/drivers/net/wireless/intel/iwlwifi/cfg/22000.c @@ -253,7 +253,7 @@ const struct iwl_cfg_trans_params iwl_qu_trans_cfg = { .device_family = IWL_DEVICE_FAMILY_22000, .base_params = &iwl_22000_base_params, .integrated = true, - .xtal_latency = 5000, + .xtal_latency = 500, .ltr_delay = IWL_CFG_TRANS_LTR_DELAY_200US, };