| Message ID | 1603971249-64044-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [-next] platform/x86/dell-wmi-sysman: Make some symbols static | expand |
On Thu, Oct 29, 2020 at 1:22 PM Zou Wei <zou_wei@huawei.com> wrote: > > Fix the following sparse warnings: > > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: > warning: symbol 'po_is_pass_set' was not declared. Should it be static? > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: warning: > symbol 'po_current_password' was not declared. Should it be static? > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23: > warning: symbol 'po_new_password' was not declared. Should it be static? > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23: > warning: symbol 'po_min_pass_length' was not declared. Should it be static? > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23: > warning: symbol 'po_max_pass_length' was not declared. Should it be static? > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23: > warning: symbol 'po_mechanism' was not declared. Should it be static? > drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23: > warning: symbol 'po_role' was not declared. Should it be static? > > po_is_pass_set, po_current_password, po_new_password, > po_min_pass_length, po_max_pass_length, po_mechanism and po_role > have only call within passobj-attributes.c > They should be static I think at the same time you may put all of them in a way that each occupies only a single line. ... > -struct kobj_attribute po_role = > +static struct kobj_attribute po_role = > __ATTR_RO(role);
diff --git a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c index e6199fb..81562b1 100644 --- a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c +++ b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c @@ -35,7 +35,7 @@ static ssize_t is_enabled_show(struct kobject *kobj, struct kobj_attribute *attr return ret; } -struct kobj_attribute po_is_pass_set = +static struct kobj_attribute po_is_pass_set = __ATTR_RO(is_enabled); static ssize_t current_password_store(struct kobject *kobj, @@ -67,7 +67,7 @@ static ssize_t current_password_store(struct kobject *kobj, return count; } -struct kobj_attribute po_current_password = +static struct kobj_attribute po_current_password = __ATTR_WO(current_password); static ssize_t new_password_store(struct kobject *kobj, @@ -96,15 +96,15 @@ static ssize_t new_password_store(struct kobject *kobj, return ret ? ret : count; } -struct kobj_attribute po_new_password = +static struct kobj_attribute po_new_password = __ATTR_WO(new_password); attribute_n_property_show(min_password_length, po); -struct kobj_attribute po_min_pass_length = +static struct kobj_attribute po_min_pass_length = __ATTR_RO(min_password_length); attribute_n_property_show(max_password_length, po); -struct kobj_attribute po_max_pass_length = +static struct kobj_attribute po_max_pass_length = __ATTR_RO(max_password_length); static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr, @@ -113,7 +113,7 @@ static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr, return sprintf(buf, "password\n"); } -struct kobj_attribute po_mechanism = +static struct kobj_attribute po_mechanism = __ATTR_RO(mechanism); static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr, @@ -126,7 +126,7 @@ static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr, return -EIO; } -struct kobj_attribute po_role = +static struct kobj_attribute po_role = __ATTR_RO(role); static struct attribute *po_attrs[] = {
Fix the following sparse warnings: drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: warning: symbol 'po_is_pass_set' was not declared. Should it be static? drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: warning: symbol 'po_current_password' was not declared. Should it be static? drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23: warning: symbol 'po_new_password' was not declared. Should it be static? drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23: warning: symbol 'po_min_pass_length' was not declared. Should it be static? drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23: warning: symbol 'po_max_pass_length' was not declared. Should it be static? drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23: warning: symbol 'po_mechanism' was not declared. Should it be static? drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23: warning: symbol 'po_role' was not declared. Should it be static? po_is_pass_set, po_current_password, po_new_password, po_min_pass_length, po_max_pass_length, po_mechanism and po_role have only call within passobj-attributes.c They should be static Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)