| Message ID | 1604045940-33684-1-git-send-email-tiantao6@hisilicon.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: arm64 - move const after static | expand |
On Fri, 30 Oct 2020 at 09:18, Tian Tao <tiantao6@hisilicon.com> wrote: > > Fixed the WARNING: Move const after static - use 'static const u8' > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com> Nak. What warning is that? This is perfectly valid C, and the const is already after the static. And in general, const applies to the type on the left, unless it comes first, so putting it after the type is less ambiguous: > --- > arch/arm64/crypto/aes-ce-glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/crypto/aes-ce-glue.c b/arch/arm64/crypto/aes-ce-glue.c > index 56a5f6f..8ba6f04 100644 > --- a/arch/arm64/crypto/aes-ce-glue.c > +++ b/arch/arm64/crypto/aes-ce-glue.c > @@ -77,7 +77,7 @@ int ce_aes_expandkey(struct crypto_aes_ctx *ctx, const u8 *in_key, > /* > * The AES key schedule round constants > */ > - static u8 const rcon[] = { > + static const u8 rcon[] = { > 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80, 0x1b, 0x36, > }; > > -- > 2.7.4 >
diff --git a/arch/arm64/crypto/aes-ce-glue.c b/arch/arm64/crypto/aes-ce-glue.c index 56a5f6f..8ba6f04 100644 --- a/arch/arm64/crypto/aes-ce-glue.c +++ b/arch/arm64/crypto/aes-ce-glue.c @@ -77,7 +77,7 @@ int ce_aes_expandkey(struct crypto_aes_ctx *ctx, const u8 *in_key, /* * The AES key schedule round constants */ - static u8 const rcon[] = { + static const u8 rcon[] = { 0x01, 0x02, 0x04, 0x08, 0x10, 0x20, 0x40, 0x80, 0x1b, 0x36, };
Fixed the WARNING: Move const after static - use 'static const u8' Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- arch/arm64/crypto/aes-ce-glue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)