| Message ID | 20201102222220.1785859-2-nico@fluxnic.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | MIPI I3c HCI (Host Controller Interface) driver | expand |
On Mon, 02 Nov 2020 17:22:19 -0500, Nicolas Pitre wrote: > From: Nicolas Pitre <npitre@baylibre.com> > > The MIPI I3C HCI (Host Controller Interface) specification defines > a common software driver interface to support compliant MIPI I3C > host controller hardware implementations from multiple vendors. > > All that is needed is an I/O area and an interrupt signal;. The hardware > is self-advertising wrt its implementor and implemented capabilities so > there is currently no details that the driver can't figure out on its own. > > Signed-off-by: Nicolas Pitre <npitre@baylibre.com> > --- > .../devicetree/bindings/i3c/mipi-i3c-hci.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml: 'additionalProperties' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml See https://patchwork.ozlabs.org/patch/1392544 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Nov 02, 2020 at 05:22:19PM -0500, Nicolas Pitre wrote: > From: Nicolas Pitre <npitre@baylibre.com> > > The MIPI I3C HCI (Host Controller Interface) specification defines > a common software driver interface to support compliant MIPI I3C > host controller hardware implementations from multiple vendors. > > All that is needed is an I/O area and an interrupt signal;. The hardware > is self-advertising wrt its implementor and implemented capabilities so > there is currently no details that the driver can't figure out on its own. > > Signed-off-by: Nicolas Pitre <npitre@baylibre.com> > --- > .../devicetree/bindings/i3c/mipi-i3c-hci.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml With additionalProperties added, Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, 4 Nov 2020, Rob Herring wrote: > On Mon, Nov 02, 2020 at 05:22:19PM -0500, Nicolas Pitre wrote: > > From: Nicolas Pitre <npitre@baylibre.com> > > > > The MIPI I3C HCI (Host Controller Interface) specification defines > > a common software driver interface to support compliant MIPI I3C > > host controller hardware implementations from multiple vendors. > > > > All that is needed is an I/O area and an interrupt signal;. The hardware > > is self-advertising wrt its implementor and implemented capabilities so > > there is currently no details that the driver can't figure out on its own. > > > > Signed-off-by: Nicolas Pitre <npitre@baylibre.com> > > --- > > .../devicetree/bindings/i3c/mipi-i3c-hci.yaml | 45 +++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml > > With additionalProperties added, > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks. Fixed patch below. ----- >8 From: Nicolas Pitre <npitre@baylibre.com> Subject: [PATCH] dt-bindings: i3c: MIPI I3C Host Controller Interface The MIPI I3C HCI (Host Controller Interface) specification defines a common software driver interface to support compliant MIPI I3C host controller hardware implementations from multiple vendors. All that is needed is an I/O area and an interrupt signal;. The hardware is self-advertising wrt its implementor and implemented capabilities so there is currently no details that the driver can't figure out on its own. Signed-off-by: Nicolas Pitre <npitre@baylibre.com> Reviewed-by: Rob Herring <robh@kernel.org> diff --git a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml new file mode 100644 index 0000000000..07a7b10163 --- /dev/null +++ b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/i3c/mipi-i3c-hci.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: MIPI I3C HCI Device Tree Bindings + +maintainers: + - Nicolas Pitre <npitre@baylibre.com> + +description: | + MIPI I3C Host Controller Interface + + The MIPI I3C HCI (Host Controller Interface) specification defines + a common software driver interface to support compliant MIPI I3C + host controller hardware implementations from multiple vendors. + + The hardware is self-advertising for differences in implementation + capabilities, including the spec version it is based on, so there + isn't much to describe here (yet). + + For details, please see: + https://www.mipi.org/specifications/i3c-hci + +properties: + compatible: + const: mipi-i3c-hci + reg: + maxItems: 1 + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + i3c@a0000000 { + compatible = "mipi-i3c-hci"; + reg = <0xa0000000 0x2000>; + interrupts = <89>; + };
diff --git a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml new file mode 100644 index 0000000000..1ceb165252 --- /dev/null +++ b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/i3c/mipi-i3c-hci.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: MIPI I3C HCI Device Tree Bindings + +maintainers: + - Nicolas Pitre <npitre@baylibre.com> + +description: | + MIPI I3C Host Controller Interface + + The MIPI I3C HCI (Host Controller Interface) specification defines + a common software driver interface to support compliant MIPI I3C + host controller hardware implementations from multiple vendors. + + The hardware is self-advertising for differences in implementation + capabilities, including the spec version it is based on, so there + isn't much to describe here (yet). + + For details, please see: + https://www.mipi.org/specifications/i3c-hci + +properties: + compatible: + const: mipi-i3c-hci + reg: + maxItems: 1 + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +examples: + - | + i3c@a0000000 { + compatible = "mipi-i3c-hci"; + reg = <0xa0000000 0x2000>; + interrupts = <89>; + };