| Message ID | 20201015131501.1939685-1-sven@narfation.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77581df8639faf28ae52fea170e48cdf9870468a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] dt: bindings: add new dt entry for ath11k calibration variant | expand |
On Thu, 15 Oct 2020 15:15:00 +0200, Sven Eckelmann wrote: > The bus + qmi-chip-id + qmi-board-id is not enough to identify the correct > board data file on IPQ6018 based devices. Multiple different boards share > the same values. Only the original reference designs can currently be > identified and loaded from the board-2.bin. But these will not result in > the correct calibration data when combined with the pre-calibration data > from the device. > > An additional "variant" information has to be provided to select the > correct board data for a design which was modified by an ODM. This follows > the same approach as ath10k. > > Signed-off-by: Sven Eckelmann <sven@narfation.org> > --- > .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Sven Eckelmann <sven@narfation.org> wrote: > The bus + qmi-chip-id + qmi-board-id is not enough to identify the correct > board data file on IPQ6018 based devices. Multiple different boards share > the same values. Only the original reference designs can currently be > identified and loaded from the board-2.bin. But these will not result in > the correct calibration data when combined with the pre-calibration data > from the device. > > An additional "variant" information has to be provided to select the > correct board data for a design which was modified by an ODM. This follows > the same approach as ath10k. > > Signed-off-by: Sven Eckelmann <sven@narfation.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> 2 patches applied to ath-next branch of ath.git, thanks. 77581df8639f dt: bindings: add new dt entry for ath11k calibration variant 14f43c5fca57 ath11k: search DT for qcom,ath11k-calibration-variant
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml index 4b365c9d9378..6af999191559 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml @@ -144,6 +144,12 @@ properties: * reg * reg-names + qcom,ath11k-calibration-variant: + $ref: /schemas/types.yaml#/definitions/string + description: + string to uniquely identify variant of the calibration data in the + board-2.bin for designs with colliding bus and device specific ids + required: - compatible - reg
The bus + qmi-chip-id + qmi-board-id is not enough to identify the correct board data file on IPQ6018 based devices. Multiple different boards share the same values. Only the original reference designs can currently be identified and loaded from the board-2.bin. But these will not result in the correct calibration data when combined with the pre-calibration data from the device. An additional "variant" information has to be provided to select the correct board data for a design which was modified by an ODM. This follows the same approach as ath10k. Signed-off-by: Sven Eckelmann <sven@narfation.org> --- .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 6 ++++++ 1 file changed, 6 insertions(+)