| Message ID | 20201107081420.60325-23-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | RISC-V Kendryte K210 support improvments | expand |
On 11/7/20 3:14 AM, Damien Le Moal wrote: > Document the device tree bindings of the Kendryte K210 SoC system > controller driver in > Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > .../bindings/mfd/kendryte,k210-sysctl.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml b/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml > new file mode 100644 > index 000000000000..8c002d2078f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/kendryte,k210-sysctl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kendryte K210 System Controller Device Tree Bindings > + > +maintainers: > + - Damien Le Moal <damien.lemoal@wdc.com> > + > +description: | > + Kendryte K210 system controller driver which provides a register map for > + clocks and peripherals within the SoC. > + > + See also: > + - dt-bindings/mfd/kendryte,k210-sysctl.h > + > +properties: > + compatible: > + allOf: > + - items: > + - const: kendryte,k210-sysctl > + - const: syscon > + - const: simple-mfd > + > + clocks: > + minItems: 1 > + maxItems: 1 > + items: > + - description: APB interface clock source > + > + clock-names: > + minItems: 1 > + items: > + - const: pclk > + > + reg: > + items: > + - description: system controller register space base address and size > + > + reg-io-width: > + const: 4 > + > +required: > + - compatible > + - clocks > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/mfd/k210-sysctl.h> > + > + sysctl: system-controller@50440000 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "kendryte,k210-sysctl", > + "syscon", "simple-mfd"; > + reg = <0x50440000 0x1000>; > + reg-io-width = <4>; > + /* ... */ > + }; > + > Reviewed-by: Sean Anderson <seanga2@gmail.com>
On Sat, 07 Nov 2020 17:14:10 +0900, Damien Le Moal wrote: > Document the device tree bindings of the Kendryte K210 SoC system > controller driver in > Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > .../bindings/mfd/kendryte,k210-sysctl.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml: properties:clocks: 'anyOf' conditional failed, one must be fixed: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: 'minItems' is not one of ['maxItems'] 'minItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'default', '$ref'] /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: 'items' is not one of ['maxItems'] 'items' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'default', '$ref'] 'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'default', '$ref'] 1 is less than the minimum of 2 'minItems' is not one of ['type', 'description', 'dependencies', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'allOf', 'anyOf', 'oneOf', '$ref'] 'maxItems' is not one of ['type', 'description', 'dependencies', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'allOf', 'anyOf', 'oneOf', '$ref'] 'items' is not one of ['type', 'description', 'dependencies', 'properties', 'patternProperties', 'additionalProperties', 'unevaluatedProperties', 'deprecated', 'required', 'allOf', 'anyOf', 'oneOf', '$ref'] 'type' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml: ignoring, error in schema: properties: clocks warning: no schema found in file: ./Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml See https://patchwork.ozlabs.org/patch/1396076 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml b/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml new file mode 100644 index 000000000000..8c002d2078f4 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/kendryte,k210-sysctl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Kendryte K210 System Controller Device Tree Bindings + +maintainers: + - Damien Le Moal <damien.lemoal@wdc.com> + +description: | + Kendryte K210 system controller driver which provides a register map for + clocks and peripherals within the SoC. + + See also: + - dt-bindings/mfd/kendryte,k210-sysctl.h + +properties: + compatible: + allOf: + - items: + - const: kendryte,k210-sysctl + - const: syscon + - const: simple-mfd + + clocks: + minItems: 1 + maxItems: 1 + items: + - description: APB interface clock source + + clock-names: + minItems: 1 + items: + - const: pclk + + reg: + items: + - description: system controller register space base address and size + + reg-io-width: + const: 4 + +required: + - compatible + - clocks + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/mfd/k210-sysctl.h> + + sysctl: system-controller@50440000 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "kendryte,k210-sysctl", + "syscon", "simple-mfd"; + reg = <0x50440000 0x1000>; + reg-io-width = <4>; + /* ... */ + }; +
Document the device tree bindings of the Kendryte K210 SoC system controller driver in Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- .../bindings/mfd/kendryte,k210-sysctl.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/kendryte,k210-sysctl.yaml