| Message ID | 1604914627-9203-1-git-send-email-weiyi.lu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: mediatek: fix mtk_clk_register_mux() as static function | expand |
On Mon, Nov 09, 2020 at 05:37:07PM +0800, Weiyi Lu wrote: > mtk_clk_register_mux() should be a static function > > Fixes: a3ae549917f16 ("clk: mediatek: Add new clkmux register API") > Cc: <stable@vger.kernel.org> Why is this for stable trees?
On Mon, 2020-11-09 at 11:20 +0100, Greg KH wrote: > On Mon, Nov 09, 2020 at 05:37:07PM +0800, Weiyi Lu wrote: > > mtk_clk_register_mux() should be a static function > > > > Fixes: a3ae549917f16 ("clk: mediatek: Add new clkmux register API") > > Cc: <stable@vger.kernel.org> > > Why is this for stable trees? Hi Greg, My Mistake. Indeed, this is not a bug fix for stable tree. And there are simple questions. Will I be allowed to keep the fixes tag in this patch to indicate the mistakes we made in previous commit if it's not a bug fix for stable tree? And all I need to do now is to remove stable tree from cc list. Is it correct? Many thanks. >
On 10/11/2020 02:38, Weiyi Lu wrote: > On Mon, 2020-11-09 at 11:20 +0100, Greg KH wrote: >> On Mon, Nov 09, 2020 at 05:37:07PM +0800, Weiyi Lu wrote: >>> mtk_clk_register_mux() should be a static function >>> >>> Fixes: a3ae549917f16 ("clk: mediatek: Add new clkmux register API") >>> Cc: <stable@vger.kernel.org> >> >> Why is this for stable trees? > > Hi Greg, > > My Mistake. Indeed, this is not a bug fix for stable tree. > And there are simple questions. > Will I be allowed to keep the fixes tag in this patch to indicate the > mistakes we made in previous commit if it's not a bug fix for stable > tree? > And all I need to do now is to remove stable tree from cc list. Is it > correct? That's my understanding, yes. Keep fixes tag but delete cc to stable. Regards, Matthias
diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c index 14e127e..dcc1352 100644 --- a/drivers/clk/mediatek/clk-mux.c +++ b/drivers/clk/mediatek/clk-mux.c @@ -155,7 +155,7 @@ static int mtk_clk_mux_set_parent_setclr_lock(struct clk_hw *hw, u8 index) .set_parent = mtk_clk_mux_set_parent_setclr_lock, }; -struct clk *mtk_clk_register_mux(const struct mtk_mux *mux, +static struct clk *mtk_clk_register_mux(const struct mtk_mux *mux, struct regmap *regmap, spinlock_t *lock) { diff --git a/drivers/clk/mediatek/clk-mux.h b/drivers/clk/mediatek/clk-mux.h index f5625f4..8e2f927 100644 --- a/drivers/clk/mediatek/clk-mux.h +++ b/drivers/clk/mediatek/clk-mux.h @@ -77,10 +77,6 @@ struct mtk_mux { _width, _gate, _upd_ofs, _upd, \ CLK_SET_RATE_PARENT) -struct clk *mtk_clk_register_mux(const struct mtk_mux *mux, - struct regmap *regmap, - spinlock_t *lock); - int mtk_clk_register_muxes(const struct mtk_mux *muxes, int num, struct device_node *node, spinlock_t *lock,
mtk_clk_register_mux() should be a static function Fixes: a3ae549917f16 ("clk: mediatek: Add new clkmux register API") Cc: <stable@vger.kernel.org> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> --- drivers/clk/mediatek/clk-mux.c | 2 +- drivers/clk/mediatek/clk-mux.h | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-)