| Message ID | 20201106112412.390724-4-j.neuschaefer@gmx.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support for ELAN eKTF2132 touchscreens | expand |
On Fri, Nov 06, 2020 at 12:24:12PM +0100, Jonathan Neuschäfer wrote: > The Kobo Aura has an eKTF2132 touchscreen controller. > > Although the vendor kernel toggles a reset pin (GPIO5-12) during the > startup sequence, the touchscreen works without it. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Applied, thanks.
On Fri, Nov 06, 2020 at 12:24:12PM +0100, Jonathan Neuschäfer wrote: > The Kobo Aura has an eKTF2132 touchscreen controller. > > Although the vendor kernel toggles a reset pin (GPIO5-12) during the > startup sequence, the touchscreen works without it. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > > This patch requires "[PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix > to pinctrl node names" in order to apply cleanly. > (https://lore.kernel.org/lkml/20201031210729.2804471-1-j.neuschaefer@gmx.net/) > --- > arch/arm/boot/dts/imx50-kobo-aura.dts | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/imx50-kobo-aura.dts > index b2fbee60271f2..82ce8c43be867 100644 > --- a/arch/arm/boot/dts/imx50-kobo-aura.dts > +++ b/arch/arm/boot/dts/imx50-kobo-aura.dts > @@ -120,7 +120,14 @@ &i2c1 { > pinctrl-0 = <&pinctrl_i2c1>; > status = "okay"; > > - /* TODO: ektf2132 touch controller at 0x15 */ > + touchscreen@15 { > + reg = <0x15>; > + compatible = "elan,ektf2132"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ts>; > + power-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>; > + interrupts-extended = <&gpio5 13 IRQ_TYPE_EDGE_FALLING>; It needs include of <dt-bindings/interrupt-controller/irq.h>. DTC arch/arm/boot/dts/imx50-kobo-aura.dtb Error: ../arch/arm/boot/dts/imx50-kobo-aura.dts:128.36-37 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:326: recipe for target 'arch/arm/boot/dts/imx50-kobo-aura.dtb' failed make[2]: *** [arch/arm/boot/dts/imx50-kobo-aura.dtb] Error 1 Patch dropped. Shawn > + }; > }; > > &i2c2 { > @@ -240,6 +247,13 @@ MX50_PAD_SD3_D7__ESDHC3_DAT7 0x1d4 > >; > }; > > + pinctrl_ts: tsgrp { > + fsl,pins = < > + MX50_PAD_CSPI_MOSI__GPIO4_9 0x0 > + MX50_PAD_SD2_D5__GPIO5_13 0x0 > + >; > + }; > + > pinctrl_uart2: uart2grp { > fsl,pins = < > MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4 > -- > 2.28.0 >
On Tue, Nov 10, 2020 at 11:12:52AM +0800, Shawn Guo wrote: > On Fri, Nov 06, 2020 at 12:24:12PM +0100, Jonathan Neuschäfer wrote: ... > > - /* TODO: ektf2132 touch controller at 0x15 */ > > + touchscreen@15 { > > + reg = <0x15>; > > + compatible = "elan,ektf2132"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ts>; > > + power-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>; > > + interrupts-extended = <&gpio5 13 IRQ_TYPE_EDGE_FALLING>; > > It needs include of <dt-bindings/interrupt-controller/irq.h>. > > DTC arch/arm/boot/dts/imx50-kobo-aura.dtb > Error: ../arch/arm/boot/dts/imx50-kobo-aura.dts:128.36-37 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:326: recipe for target 'arch/arm/boot/dts/imx50-kobo-aura.dtb' failed > make[2]: *** [arch/arm/boot/dts/imx50-kobo-aura.dtb] Error 1 Ooops, indeed. > Patch dropped. I'll send a version 2. Thanks, Jonathan Neuschäfer
diff --git a/arch/arm/boot/dts/imx50-kobo-aura.dts b/arch/arm/boot/dts/imx50-kobo-aura.dts index b2fbee60271f2..82ce8c43be867 100644 --- a/arch/arm/boot/dts/imx50-kobo-aura.dts +++ b/arch/arm/boot/dts/imx50-kobo-aura.dts @@ -120,7 +120,14 @@ &i2c1 { pinctrl-0 = <&pinctrl_i2c1>; status = "okay"; - /* TODO: ektf2132 touch controller at 0x15 */ + touchscreen@15 { + reg = <0x15>; + compatible = "elan,ektf2132"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ts>; + power-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>; + interrupts-extended = <&gpio5 13 IRQ_TYPE_EDGE_FALLING>; + }; }; &i2c2 { @@ -240,6 +247,13 @@ MX50_PAD_SD3_D7__ESDHC3_DAT7 0x1d4 >; }; + pinctrl_ts: tsgrp { + fsl,pins = < + MX50_PAD_CSPI_MOSI__GPIO4_9 0x0 + MX50_PAD_SD2_D5__GPIO5_13 0x0 + >; + }; + pinctrl_uart2: uart2grp { fsl,pins = < MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
The Kobo Aura has an eKTF2132 touchscreen controller. Although the vendor kernel toggles a reset pin (GPIO5-12) during the startup sequence, the touchscreen works without it. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- This patch requires "[PATCH] ARM: dts: imx50-kobo-aura: Add 'grp' suffix to pinctrl node names" in order to apply cleanly. (https://lore.kernel.org/lkml/20201031210729.2804471-1-j.neuschaefer@gmx.net/) --- arch/arm/boot/dts/imx50-kobo-aura.dts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) -- 2.28.0