diff mbox series

ath11k: Fix beamformee STS in HE cap

Message ID 1604933229-15815-1-git-send-email-rgnanase@codeaurora.org (mailing list archive)
State Accepted
Commit 1057db1b8b7661c5031caa0244dfa6bee9adc938
Delegated to: Kalle Valo
Headers show
Series ath11k: Fix beamformee STS in HE cap | expand

Commit Message

Ramya Gnanasekar Nov. 9, 2020, 2:47 p.m. UTC
STS Beamformee capability sent from firmware is overwritten as
num_tx_chains - 1.
When num_tx_chains is 2, then STS is set to invalid value 1.
Since STS is not limited by number of TX chain, not overwriting the
capability received from firmware.

Tested on: IPQ6018 WLAN.HK.2.4.0.1-00303-QCAHKSWPL_SILICONZ-1

Signed-off-by: Ramya Gnanasekar <rgnanase@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/mac.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Kalle Valo Nov. 23, 2020, 6:06 p.m. UTC | #1
Ramya Gnanasekar <rgnanase@codeaurora.org> wrote:

> STS Beamformee capability sent from firmware is overwritten as
> num_tx_chains - 1.
> When num_tx_chains is 2, then STS is set to invalid value 1.
> Since STS is not limited by number of TX chain, not overwriting the
> capability received from firmware.
> 
> Tested on: IPQ6018 WLAN.HK.2.4.0.1-00303-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Ramya Gnanasekar <rgnanase@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

1057db1b8b76 ath11k: Fix beamformee STS in HE cap
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 7f8dd47..787b052 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3729,11 +3729,6 @@  static int ath11k_mac_copy_he_cap(struct ath11k *ar,
 
 		he_cap_elem->mac_cap_info[1] &=
 			IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK;
-		he_cap_elem->phy_cap_info[4] &=
-			~IEEE80211_HE_PHY_CAP4_BEAMFORMEE_MAX_STS_UNDER_80MHZ_MASK;
-		he_cap_elem->phy_cap_info[4] &=
-			~IEEE80211_HE_PHY_CAP4_BEAMFORMEE_MAX_STS_ABOVE_80MHZ_MASK;
-		he_cap_elem->phy_cap_info[4] |= (ar->num_tx_chains - 1) << 2;
 
 		he_cap_elem->phy_cap_info[5] &=
 			~IEEE80211_HE_PHY_CAP5_BEAMFORMEE_NUM_SND_DIM_UNDER_80MHZ_MASK;