| Message ID | 20201124135730.9185-1-pduplessis@efficios.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [RFC,v2] tracing: Remove duplicate `type` field from regmap `regcache_sync` trace event | expand |
On Tue, Nov 24, 2020 at 08:57:30AM -0500, Philippe Duplessis-Guindon wrote: > Fixes commit 593600890110c ("regmap: Add the regcache_sync trace event") > > Signed-off-by: Philippe Duplessis-Guindon <pduplessis@efficios.com> Please follow the format for Fixes: tags documented in submitting-patches.rst and existing usage in the kernel. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Tue, 24 Nov 2020 08:57:30 -0500, Philippe Duplessis-Guindon wrote: > I have an error saying that `regcache_sync` has 2 fields named `type` > while using libtraceevent. > > Erase the `int field` type, which is not assigned. This field is > introduced by mistake and this commit removes it. > > Fixes commit 593600890110c ("regmap: Add the regcache_sync trace event") Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next Thanks! [1/1] regmap: Remove duplicate `type` field from regmap `regcache_sync` trace event commit: e6e9354b58307c120afbdc2719a6093638c37446 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, 24 Nov 2020 08:57:30 -0500 Philippe Duplessis-Guindon <pduplessis@efficios.com> wrote: > I have an error saying that `regcache_sync` has 2 fields named `type` > while using libtraceevent. > > Erase the `int field` type, which is not assigned. This field is > introduced by mistake and this commit removes it. > > Fixes commit 593600890110c ("regmap: Add the regcache_sync trace event") > > Signed-off-by: Philippe Duplessis-Guindon <pduplessis@efficios.com> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve > --- > drivers/base/regmap/trace.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h > index d4066fa079ab..9abee14df9ee 100644 > --- a/drivers/base/regmap/trace.h > +++ b/drivers/base/regmap/trace.h > @@ -126,7 +126,6 @@ TRACE_EVENT(regcache_sync, > __string( name, regmap_name(map) ) > __string( status, status ) > __string( type, type ) > - __field( int, type ) > ), > > TP_fast_assign(
diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h index d4066fa079ab..9abee14df9ee 100644 --- a/drivers/base/regmap/trace.h +++ b/drivers/base/regmap/trace.h @@ -126,7 +126,6 @@ TRACE_EVENT(regcache_sync, __string( name, regmap_name(map) ) __string( status, status ) __string( type, type ) - __field( int, type ) ), TP_fast_assign(
I have an error saying that `regcache_sync` has 2 fields named `type` while using libtraceevent. Erase the `int field` type, which is not assigned. This field is introduced by mistake and this commit removes it. Fixes commit 593600890110c ("regmap: Add the regcache_sync trace event") Signed-off-by: Philippe Duplessis-Guindon <pduplessis@efficios.com> --- drivers/base/regmap/trace.h | 1 - 1 file changed, 1 deletion(-)