[v2,4.19.y-cip,0/7] Add RPC-IF driver for RZ/G2x SoC's

Message

Lad Prabhakar Nov. 24, 2020, 5:59 p.m. UTC

Hi Nobuhiro, Pavel,

This patch series adds SPI driver for the Renesas RPC-IF.
Alongside relevant changes for spi-mem have been also
backported. This enables accessing SPI flash chip connected
to RPC-IF on RZ/G2x boards.

We currently only aim to backport just the driver hence there
are no changes to dts/i files. The driver has been tested on
RZ/G2{EM} with all the required dts/i changes [1].

Currently we are upstreaming clock [2] and pinctrl [3] changes
required for RPC-IF interface on RZ/G2x SoC's once that hits
v5.11 we shall backport it.

All the patches have been cherry picked from Linux 5.10-rc5.

[1] https://github.com/prabhakarlad/cip/commits/master
[2] https://patchwork.kernel.org/project/linux-renesas-soc/
    list/?series=365697&archive=both&state=*
[3] https://patchwork.kernel.org/project/linux-renesas-soc/
    list/?series=387535&archive=both&state=*

Changes for v2:
* Patches {1, 3, 4}/7 unchanged
* Patch 2/7
   * Fixed reference leak for OF node in rpcif_probe()
   * Fixed overwriting return value in error path of rpcif_manual_xfer()
   * Replaced C++ style comment with C style
   * Replaced tab with a space between struct and struct name
   * Fixed a typo in commit message (s/absract/abstract)
* Patch 5/7
   * Fixed reference leak in spi_mem_access_start for PM
* Patch 6/7
   * Return early in spi_mem_dirmap_dirmap_{read/write}
* Patch 7/7
   * Replaced C++ style comment with C style
   * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
     CONFIG_PM_SLEEP ifdef checks
   * Elaborated the description for SPI_RPCIF config
   * Dropped the label err_put_ctlr from rpc_spi_probe()

Cheers,
Prabhakar

Boris Brezillon (3):
  spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum
  spi: spi-mem: Split spi_mem_exec_op() code
  spi: spi-mem: Add a new API to support direct mapping

Naga Sureshkumar Relli (1):
  spi: spi-mem: export spi_mem_default_supports_op()

Sergei Shtylyov (3):
  dt-bindings: memory: document Renesas RPC-IF bindings
  memory: add Renesas RPC-IF driver
  spi: add Renesas RPC-IF driver

 .../memory-controllers/renesas,rpc-if.yaml    |  88 +++
 drivers/memory/Kconfig                        |   9 +
 drivers/memory/Makefile                       |   1 +
 drivers/memory/renesas-rpc-if.c               | 606 ++++++++++++++++++
 drivers/spi/Kconfig                           |   8 +
 drivers/spi/Makefile                          |   1 +
 drivers/spi/spi-mem.c                         | 274 +++++++-
 drivers/spi/spi-rpc-if.c                      | 208 ++++++
 include/linux/spi/spi-mem.h                   |  93 +++
 include/memory/renesas-rpc-if.h               |  87 +++
 10 files changed, 1351 insertions(+), 24 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
 create mode 100644 drivers/memory/renesas-rpc-if.c
 create mode 100644 drivers/spi/spi-rpc-if.c
 create mode 100644 include/memory/renesas-rpc-if.h

Comments

Pavel Machek Nov. 24, 2020, 7:49 p.m. UTC | #1

Hi!

> This patch series adds SPI driver for the Renesas RPC-IF.
> Alongside relevant changes for spi-mem have been also
> backported. This enables accessing SPI flash chip connected
> to RPC-IF on RZ/G2x boards.
> 
> We currently only aim to backport just the driver hence there
> are no changes to dts/i files. The driver has been tested on
> RZ/G2{EM} with all the required dts/i changes [1].

Okay, that was quick.

What is your plan, merge dts changes soon? Or is the driver useful
even without the dts changes?

> Changes for v2:
> * Patches {1, 3, 4}/7 unchanged
> * Patch 2/7
>    * Fixed reference leak for OF node in rpcif_probe()
>    * Fixed overwriting return value in error path of rpcif_manual_xfer()
>    * Replaced C++ style comment with C style
>    * Replaced tab with a space between struct and struct name
>    * Fixed a typo in commit message (s/absract/abstract)
> * Patch 5/7
>    * Fixed reference leak in spi_mem_access_start for PM
> * Patch 6/7
>    * Return early in spi_mem_dirmap_dirmap_{read/write}
> * Patch 7/7
>    * Replaced C++ style comment with C style
>    * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
>      CONFIG_PM_SLEEP ifdef checks
>    * Elaborated the description for SPI_RPCIF config
>    * Dropped the label err_put_ctlr from rpc_spi_probe()

Thanks for the changes; they are probably good (I have yet to take
close look), but I wonder if we should wait until they hit next or
mainline? If upstream maintainer disagrees, we would get divergence...

Best regards,
								Pavel

Nobuhiro Iwamatsu Nov. 25, 2020, 6:48 a.m. UTC | #2

Hi,

> -----Original Message-----
> From: Pavel Machek [mailto:[e-mail]]
> Sent: Wednesday, November 25, 2020 4:49 AM
> To: Lad Prabhakar <[e-mail]>
> Cc: [e-mail]; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <[e-mail]>; Pavel Machek <[e-mail]>; Biju Das <[e-mail]>
> Subject: Re: [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
> 
> Hi!
> 
> > This patch series adds SPI driver for the Renesas RPC-IF.
> > Alongside relevant changes for spi-mem have been also
> > backported. This enables accessing SPI flash chip connected
> > to RPC-IF on RZ/G2x boards.
> >
> > We currently only aim to backport just the driver hence there
> > are no changes to dts/i files. The driver has been tested on
> > RZ/G2{EM} with all the required dts/i changes [1].
> 
> Okay, that was quick.
> 
> What is your plan, merge dts changes soon? Or is the driver useful
> even without the dts changes?
> 
> > Changes for v2:
> > * Patches {1, 3, 4}/7 unchanged
> > * Patch 2/7
> >    * Fixed reference leak for OF node in rpcif_probe()
> >    * Fixed overwriting return value in error path of rpcif_manual_xfer()
> >    * Replaced C++ style comment with C style
> >    * Replaced tab with a space between struct and struct name
> >    * Fixed a typo in commit message (s/absract/abstract)
> > * Patch 5/7
> >    * Fixed reference leak in spi_mem_access_start for PM
> > * Patch 6/7
> >    * Return early in spi_mem_dirmap_dirmap_{read/write}
> > * Patch 7/7
> >    * Replaced C++ style comment with C style
> >    * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
> >      CONFIG_PM_SLEEP ifdef checks
> >    * Elaborated the description for SPI_RPCIF config
> >    * Dropped the label err_put_ctlr from rpc_spi_probe()
> 

I don't see any problems with this series.

> Thanks for the changes; they are probably good (I have yet to take
> close look), but I wonder if we should wait until they hit next or
> mainline? If upstream maintainer disagrees, we would get divergence...

These patch series contain fixes for issues in the patch itself, so we need to
separate them and post them mainline or subsystem tree.
So I think we have to wait for those patches to be merged.

Best regards,
  Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5868): https://lists.cip-project.org/g/cip-dev/message/5868
Mute This Topic: https://lists.cip-project.org/mt/78482875/4520388
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Lad Prabhakar Nov. 25, 2020, 8:49 a.m. UTC | #3

Hi Pavel,

> -----Original Message-----
> From: Pavel Machek <[e-mail]>
> Sent: 24 November 2020 19:49
> To: Prabhakar Mahadev Lad <[e-mail]>
> Cc: [e-mail]; Nobuhiro Iwamatsu <[e-mail]>; Pavel Machek
> <[e-mail]>; Biju Das <[e-mail]>
> Subject: Re: [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
> 
> Hi!
> 
> > This patch series adds SPI driver for the Renesas RPC-IF.
> > Alongside relevant changes for spi-mem have been also
> > backported. This enables accessing SPI flash chip connected
> > to RPC-IF on RZ/G2x boards.
> >
> > We currently only aim to backport just the driver hence there
> > are no changes to dts/i files. The driver has been tested on
> > RZ/G2{EM} with all the required dts/i changes [1].
> 
> Okay, that was quick.
> 
> What is your plan, merge dts changes soon? Or is the driver useful
> even without the dts changes?
> 
We only plan to upstream/backport driver, pinctrl and clock atm (consumers needing this feature will have to manually enable the DTS)

> > Changes for v2:
> > * Patches {1, 3, 4}/7 unchanged
> > * Patch 2/7
> >    * Fixed reference leak for OF node in rpcif_probe()
> >    * Fixed overwriting return value in error path of rpcif_manual_xfer()
> >    * Replaced C++ style comment with C style
> >    * Replaced tab with a space between struct and struct name
> >    * Fixed a typo in commit message (s/absract/abstract)
> > * Patch 5/7
> >    * Fixed reference leak in spi_mem_access_start for PM
> > * Patch 6/7
> >    * Return early in spi_mem_dirmap_dirmap_{read/write}
> > * Patch 7/7
> >    * Replaced C++ style comment with C style
> >    * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
> >      CONFIG_PM_SLEEP ifdef checks
> >    * Elaborated the description for SPI_RPCIF config
> >    * Dropped the label err_put_ctlr from rpc_spi_probe()
> 
> Thanks for the changes; they are probably good (I have yet to take
> close look), but I wonder if we should wait until they hit next or
> mainline? If upstream maintainer disagrees, we would get divergence...
> 
Agreed when the fixes hit linux-next I shall post a v3.

Cheers,
Prabhakar

> Best regards,
> 								Pavel
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5872): https://lists.cip-project.org/g/cip-dev/message/5872
Mute This Topic: https://lists.cip-project.org/mt/78482875/4520388
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Lad Prabhakar Nov. 25, 2020, 8:53 a.m. UTC | #4

Hi Nobuhiro,

> -----Original Message-----
> From: [e-mail] <[e-mail]>
> Sent: 25 November 2020 06:48
> To: [e-mail]; Prabhakar Mahadev Lad <[e-mail]>
> Cc: [e-mail]; Biju Das <[e-mail]>
> Subject: RE: [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
> 
> Hi,
> 
> > -----Original Message-----
> > From: Pavel Machek [mailto:[e-mail]]
> > Sent: Wednesday, November 25, 2020 4:49 AM
> > To: Lad Prabhakar <[e-mail]>
> > Cc: [e-mail]; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> > <[e-mail]>; Pavel Machek <[e-mail]>; Biju Das
> <[e-mail]>
> > Subject: Re: [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
> >
> > Hi!
> >
> > > This patch series adds SPI driver for the Renesas RPC-IF.
> > > Alongside relevant changes for spi-mem have been also
> > > backported. This enables accessing SPI flash chip connected
> > > to RPC-IF on RZ/G2x boards.
> > >
> > > We currently only aim to backport just the driver hence there
> > > are no changes to dts/i files. The driver has been tested on
> > > RZ/G2{EM} with all the required dts/i changes [1].
> >
> > Okay, that was quick.
> >
> > What is your plan, merge dts changes soon? Or is the driver useful
> > even without the dts changes?
> >
> > > Changes for v2:
> > > * Patches {1, 3, 4}/7 unchanged
> > > * Patch 2/7
> > >    * Fixed reference leak for OF node in rpcif_probe()
> > >    * Fixed overwriting return value in error path of rpcif_manual_xfer()
> > >    * Replaced C++ style comment with C style
> > >    * Replaced tab with a space between struct and struct name
> > >    * Fixed a typo in commit message (s/absract/abstract)
> > > * Patch 5/7
> > >    * Fixed reference leak in spi_mem_access_start for PM
> > > * Patch 6/7
> > >    * Return early in spi_mem_dirmap_dirmap_{read/write}
> > > * Patch 7/7
> > >    * Replaced C++ style comment with C style
> > >    * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
> > >      CONFIG_PM_SLEEP ifdef checks
> > >    * Elaborated the description for SPI_RPCIF config
> > >    * Dropped the label err_put_ctlr from rpc_spi_probe()
> >
> 
> I don't see any problems with this series.
> 
Thank you for the review.

> > Thanks for the changes; they are probably good (I have yet to take
> > close look), but I wonder if we should wait until they hit next or
> > mainline? If upstream maintainer disagrees, we would get divergence...
> 
> These patch series contain fixes for issues in the patch itself, so we need to
> separate them and post them mainline or subsystem tree.
> So I think we have to wait for those patches to be merged.
> 
Agreed will repost the series once the fixes hit linux-next.

Cheers,
Prabhakar

> Best regards,
>   Nobuhiro
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5873): https://lists.cip-project.org/g/cip-dev/message/5873
Mute This Topic: https://lists.cip-project.org/mt/78482875/4520388
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-

Lad Prabhakar Dec. 3, 2020, 10:28 a.m. UTC | #5

Hi Pavel, Nobuhiro,

> -----Original Message-----
> From: [e-mail] <[e-mail]> On Behalf Of Lad Prabhakar via
> lists.cip-project.org
> Sent: 25 November 2020 08:50
> To: Pavel Machek <[e-mail]>
> Cc: [e-mail]; Nobuhiro Iwamatsu <[e-mail]>; Biju Das
> <[e-mail]>
> Subject: Re: [cip-dev] [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
> 
> Hi Pavel,
> 
> > -----Original Message-----
> > From: Pavel Machek <[e-mail]>
> > Sent: 24 November 2020 19:49
> > To: Prabhakar Mahadev Lad <[e-mail]>
> > Cc: [e-mail]; Nobuhiro Iwamatsu <[e-mail]>; Pavel
> Machek
> > <[e-mail]>; Biju Das <[e-mail]>
> > Subject: Re: [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
> >
> > Hi!
> >
> > > This patch series adds SPI driver for the Renesas RPC-IF.
> > > Alongside relevant changes for spi-mem have been also
> > > backported. This enables accessing SPI flash chip connected
> > > to RPC-IF on RZ/G2x boards.
> > >
> > > We currently only aim to backport just the driver hence there
> > > are no changes to dts/i files. The driver has been tested on
> > > RZ/G2{EM} with all the required dts/i changes [1].
> >
> > Okay, that was quick.
> >
> > What is your plan, merge dts changes soon? Or is the driver useful
> > even without the dts changes?
> >
> We only plan to upstream/backport driver, pinctrl and clock atm (consumers needing this feature will
> have to manually enable the DTS)
> 
> > > Changes for v2:
> > > * Patches {1, 3, 4}/7 unchanged
> > > * Patch 2/7
> > >    * Fixed reference leak for OF node in rpcif_probe()
> > >    * Fixed overwriting return value in error path of rpcif_manual_xfer()
> > >    * Replaced C++ style comment with C style
> > >    * Replaced tab with a space between struct and struct name
> > >    * Fixed a typo in commit message (s/absract/abstract)
> > > * Patch 5/7
> > >    * Fixed reference leak in spi_mem_access_start for PM
> > > * Patch 6/7
> > >    * Return early in spi_mem_dirmap_dirmap_{read/write}
> > > * Patch 7/7
> > >    * Replaced C++ style comment with C style
> > >    * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
> > >      CONFIG_PM_SLEEP ifdef checks
> > >    * Elaborated the description for SPI_RPCIF config
> > >    * Dropped the label err_put_ctlr from rpc_spi_probe()
> >
> > Thanks for the changes; they are probably good (I have yet to take
> > close look), but I wonder if we should wait until they hit next or
> > mainline? If upstream maintainer disagrees, we would get divergence...
> >
> Agreed when the fixes hit linux-next I shall post a v3.
> 
Fixes to the driver have hit Linux-next, is it OK if I re-spin a v3 now or wait for it to hit -rc release ?

Cheers,
Prabhakar
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5937): https://lists.cip-project.org/g/cip-dev/message/5937
Mute This Topic: https://lists.cip-project.org/mt/78482875/4520388
Group Owner: [e-mail]
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [[e-mail]]
-=-=-=-=-=-=-=-=-=-=-=-