| Message ID | 20201124124538.660710-60-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert DSI code to use drm_mipi_dsi and drm_panel | expand |
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index c3592c6db977..7fee9cf8782d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -5140,6 +5140,13 @@ static int omap_dsi_host_attach(struct mipi_dsi_host *host, > dsi->config.lp_clk_min = 7000000; // TODO: get from client? > dsi->config.lp_clk_max = client->lp_rate; > > + if (client->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) > + dsi->config.trans_mode = OMAP_DSS_DSI_BURST_MODE; > + else if (client->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) > + dsi->config.trans_mode = OMAP_DSS_DSI_PULSE_MODE; > + else > + dsi->config.trans_mode = OMAP_DSS_DSI_EVENT_MODE; > + > dsi->ulps_auto_idle = false; > > return 0; >
Hi, On Tue, Nov 24, 2020 at 02:45:17PM +0200, Tomi Valkeinen wrote: > The DSI host driver currently ignores the video mode flags in > client->mode_flags. Add the code to take the transfer mode from client's > mode_flags. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index c3592c6db977..7fee9cf8782d 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -5140,6 +5140,13 @@ static int omap_dsi_host_attach(struct mipi_dsi_host *host, > dsi->config.lp_clk_min = 7000000; // TODO: get from client? > dsi->config.lp_clk_max = client->lp_rate; > > + if (client->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) > + dsi->config.trans_mode = OMAP_DSS_DSI_BURST_MODE; > + else if (client->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) > + dsi->config.trans_mode = OMAP_DSS_DSI_PULSE_MODE; > + else > + dsi->config.trans_mode = OMAP_DSS_DSI_EVENT_MODE; > + > dsi->ulps_auto_idle = false; > > return 0; > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index c3592c6db977..7fee9cf8782d 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -5140,6 +5140,13 @@ static int omap_dsi_host_attach(struct mipi_dsi_host *host, dsi->config.lp_clk_min = 7000000; // TODO: get from client? dsi->config.lp_clk_max = client->lp_rate; + if (client->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) + dsi->config.trans_mode = OMAP_DSS_DSI_BURST_MODE; + else if (client->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) + dsi->config.trans_mode = OMAP_DSS_DSI_PULSE_MODE; + else + dsi->config.trans_mode = OMAP_DSS_DSI_EVENT_MODE; + dsi->ulps_auto_idle = false; return 0;
The DSI host driver currently ignores the video mode flags in client->mode_flags. Add the code to take the transfer mode from client's mode_flags. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++++++ 1 file changed, 7 insertions(+)