mbox series

[daxctl,v2,0/5] daxctl: device align support

Message ID 20201216224833.6229-1-joao.m.martins@oracle.com (mailing list archive)
Headers show
Series daxctl: device align support | expand

Message

Joao Martins Dec. 16, 2020, 10:48 p.m. UTC
Hey,

This series adds support for:

 1) {create,reconfigure}-device for selecting @align (hugepage size).
 Here we add a '-a|--align 4K|2M|1G' option to the existing commands;

 2) Listing now displays align (if supported).

Testing requires a 5.10+ kernel. 

v1 -> v2:
  * Fix listing of dax devices on kernels that don't support align;
  * Adds a unit test for align;
  * Remove the mapping part to a later series;

Joao Martins (5):
  daxctl: add daxctl_dev_{get,set}_align()
  util/json: Print device align
  daxctl: add align support in reconfigure-device
  daxctl: add align support in create-device
  daxctl/test: Add a test for daxctl-create with align

 Documentation/daxctl/daxctl-create-device.txt      |  8 +++++
 Documentation/daxctl/daxctl-reconfigure-device.txt | 12 ++++++++
 daxctl/device.c                                    | 32 ++++++++++++++++---
 daxctl/lib/libdaxctl-private.h                     |  1 +
 daxctl/lib/libdaxctl.c                             | 36 ++++++++++++++++++++++
 daxctl/lib/libdaxctl.sym                           |  2 ++
 daxctl/libdaxctl.h                                 |  2 ++
 test/daxctl-create.sh                              | 29 +++++++++++++++++
 util/json.c                                        |  9 +++++-
 9 files changed, 125 insertions(+), 6 deletions(-)

Comments

Verma, Vishal L Dec. 17, 2020, 12:48 a.m. UTC | #1
On Wed, 2020-12-16 at 22:48 +0000, Joao Martins wrote:
> Hey,
> 
> This series adds support for:
> 
>  1) {create,reconfigure}-device for selecting @align (hugepage size).
>  Here we add a '-a|--align 4K|2M|1G' option to the existing commands;
> 
>  2) Listing now displays align (if supported).
> 
> Testing requires a 5.10+ kernel. 
> 
> v1 -> v2:
>   * Fix listing of dax devices on kernels that don't support align;
>   * Adds a unit test for align;
>   * Remove the mapping part to a later series;
> 

These all look good to me, I've applied them and pushed a branch out,
'jm/devdax_subdiv'. As Dan mentioned in the other thread, if you had a
respin of the provisioning flows patches, we can add them in.

Thanks for the quick turnaround on these!

> Joao Martins (5):
>   daxctl: add daxctl_dev_{get,set}_align()
>   util/json: Print device align
>   daxctl: add align support in reconfigure-device
>   daxctl: add align support in create-device
>   daxctl/test: Add a test for daxctl-create with align
> 
>  Documentation/daxctl/daxctl-create-device.txt      |  8 +++++
>  Documentation/daxctl/daxctl-reconfigure-device.txt | 12 ++++++++
>  daxctl/device.c                                    | 32 ++++++++++++++++---
>  daxctl/lib/libdaxctl-private.h                     |  1 +
>  daxctl/lib/libdaxctl.c                             | 36 ++++++++++++++++++++++
>  daxctl/lib/libdaxctl.sym                           |  2 ++
>  daxctl/libdaxctl.h                                 |  2 ++
>  test/daxctl-create.sh                              | 29 +++++++++++++++++
>  util/json.c                                        |  9 +++++-
>  9 files changed, 125 insertions(+), 6 deletions(-)
>