| Message ID | 20201216170018.861710-2-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: r8a779a0: Add FCP and VSP support | expand |
Hi Kieran, Thank you for the patch. On Wed, Dec 16, 2020 at 05:00:16PM +0000, Kieran Bingham wrote: > Provide FCPVD support for the V3U. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > index 6cf77ce9aa93..ba6fbbd8710e 100644 > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -117,6 +117,22 @@ gic: interrupt-controller@f1000000 { > power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > }; > > + fcpvd0: fcp@fea10000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfea10000 0 0x200>; > + clocks = <&cpg CPG_MOD 508>; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 508>; > + }; > + > + fcpvd1: fcp@fea11000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfea2f000 0 0x200>; This doesn't match the node address (the former being correct I believe). With this fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + clocks = <&cpg CPG_MOD 509>; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 509>; > + }; > + > prr: chipid@fff00044 { > compatible = "renesas,prr"; > reg = <0 0xfff00044 0 4>;
Hi Laurent, On 16/12/2020 17:41, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wed, Dec 16, 2020 at 05:00:16PM +0000, Kieran Bingham wrote: >> Provide FCPVD support for the V3U. >> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> --- >> arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi >> index 6cf77ce9aa93..ba6fbbd8710e 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi >> @@ -117,6 +117,22 @@ gic: interrupt-controller@f1000000 { >> power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; >> }; >> >> + fcpvd0: fcp@fea10000 { >> + compatible = "renesas,fcpv"; >> + reg = <0 0xfea10000 0 0x200>; >> + clocks = <&cpg CPG_MOD 508>; >> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; >> + resets = <&cpg 508>; >> + }; >> + >> + fcpvd1: fcp@fea11000 { >> + compatible = "renesas,fcpv"; >> + reg = <0 0xfea2f000 0 0x200>; > > This doesn't match the node address (the former being correct I > believe). With this fixed, Oh dear, that's bad indeed. I'm sorry - could you help me locate the correct buttons on my keyboard to fix this please? : > https://as1.ftcdn.net/jpg/00/74/64/78/500_F_74647888_XIrZ25aSYKhu5YB4PyuU7qYqzAJr3EjQ.jpg :-D > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks. K > >> + clocks = <&cpg CPG_MOD 509>; >> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; >> + resets = <&cpg 509>; >> + }; >> + >> prr: chipid@fff00044 { >> compatible = "renesas,prr"; >> reg = <0 0xfff00044 0 4>; >
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi index 6cf77ce9aa93..ba6fbbd8710e 100644 --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi @@ -117,6 +117,22 @@ gic: interrupt-controller@f1000000 { power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; }; + fcpvd0: fcp@fea10000 { + compatible = "renesas,fcpv"; + reg = <0 0xfea10000 0 0x200>; + clocks = <&cpg CPG_MOD 508>; + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; + resets = <&cpg 508>; + }; + + fcpvd1: fcp@fea11000 { + compatible = "renesas,fcpv"; + reg = <0 0xfea2f000 0 0x200>; + clocks = <&cpg CPG_MOD 509>; + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; + resets = <&cpg 509>; + }; + prr: chipid@fff00044 { compatible = "renesas,prr"; reg = <0 0xfff00044 0 4>;
Provide FCPVD support for the V3U. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)