| Message ID | 20201230003255.3450874-5-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: improvement on bioset & bvec allocation | expand |
On Wed, Dec 30, 2020 at 08:32:53AM +0800, Ming Lei wrote: > bvec_alloc() may allocate more bio vectors than requested, so set .bi_max_vecs as > actual allocated vector number, instead of the requested number. This way can help > fs build bigger bio because new bio often won't be allocated until the current one > becomes full. Overly long lines above. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/block/bio.c b/block/bio.c index 3991a5aab1bc..e567feb380b6 100644 --- a/block/bio.c +++ b/block/bio.c @@ -502,12 +502,13 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs, goto err_free; bio->bi_flags |= idx << BVEC_POOL_OFFSET; + bio->bi_max_vecs = bvec_nr_vecs(idx); } else if (nr_iovecs) { bvl = bio->bi_inline_vecs; + bio->bi_max_vecs = inline_vecs; } bio->bi_pool = bs; - bio->bi_max_vecs = nr_iovecs; bio->bi_io_vec = bvl; return bio;
bvec_alloc() may allocate more bio vectors than requested, so set .bi_max_vecs as actual allocated vector number, instead of the requested number. This way can help fs build bigger bio because new bio often won't be allocated until the current one becomes full. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/bio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)