| Message ID | 20210119134749.401311-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/check-block.sh: Refuse to run the iotests with BusyBox' sed | expand |
On 1/19/21 2:47 PM, Thomas Huth wrote: > BusyBox' sed reports itself as "This is not GNU sed version 4.0" > when being run with the --version parameter. However, the iotests > really need GNU sed, they do not work with the BusyBox version. > So let's make sure that we really have GNU sed and refuse to run > the tests with BusyBox' sed. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/check-block.sh | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Tue, Jan 19, 2021 at 02:47:49PM +0100, Thomas Huth wrote: > BusyBox' sed reports itself as "This is not GNU sed version 4.0" > when being run with the --version parameter. However, the iotests > really need GNU sed, they do not work with the BusyBox version. > So let's make sure that we really have GNU sed and refuse to run > the tests with BusyBox' sed. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/check-block.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/check-block.sh b/tests/check-block.sh > index fb4c1baae9..e4f37905be 100755 > --- a/tests/check-block.sh > +++ b/tests/check-block.sh > @@ -60,6 +60,13 @@ if ! (sed --version | grep 'GNU sed') > /dev/null 2>&1 ; then > echo "GNU sed not available ==> Not running the qemu-iotests." > exit 0 > fi > +else > + # Double-check that we're not using BusyBox' sed which says > + # that "This is not GNU sed version 4.0" ... > + if sed --version | grep -q 'not GNU sed' ; then > + echo "BusyBox sed not supported ==> Not running the qemu-iotests." > + exit 0 > + fi > fi Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
Am 19.01.2021 um 14:47 hat Thomas Huth geschrieben: > BusyBox' sed reports itself as "This is not GNU sed version 4.0" > when being run with the --version parameter. However, the iotests > really need GNU sed, they do not work with the BusyBox version. > So let's make sure that we really have GNU sed and refuse to run > the tests with BusyBox' sed. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/tests/check-block.sh b/tests/check-block.sh index fb4c1baae9..e4f37905be 100755 --- a/tests/check-block.sh +++ b/tests/check-block.sh @@ -60,6 +60,13 @@ if ! (sed --version | grep 'GNU sed') > /dev/null 2>&1 ; then echo "GNU sed not available ==> Not running the qemu-iotests." exit 0 fi +else + # Double-check that we're not using BusyBox' sed which says + # that "This is not GNU sed version 4.0" ... + if sed --version | grep -q 'not GNU sed' ; then + echo "BusyBox sed not supported ==> Not running the qemu-iotests." + exit 0 + fi fi cd tests/qemu-iotests
BusyBox' sed reports itself as "This is not GNU sed version 4.0" when being run with the --version parameter. However, the iotests really need GNU sed, they do not work with the BusyBox version. So let's make sure that we really have GNU sed and refuse to run the tests with BusyBox' sed. Signed-off-by: Thomas Huth <thuth@redhat.com> --- tests/check-block.sh | 7 +++++++ 1 file changed, 7 insertions(+)