| Message ID | 20210114121350.123684-1-wangyanan55@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Some optimization for stage-2 translation | expand |
On Thu, 14 Jan 2021 20:13:47 +0800, Yanan Wang wrote: > This patch series(v3) make some optimization for stage-2 translation. > > About patch-1: > Procedures of hyp stage-1 map and guest stage-2 map are quite different, > but they are now tied closely by function kvm_set_valid_leaf_pte(). > So adjust the relative code for ease of code maintenance in the future. > > [...] Applied to kvm-arm64/concurrent-translation-fault, thanks! [1/3] KVM: arm64: Adjust partial code of hyp stage-1 map and guest stage-2 map commit: 8ed80051c8c31d1587722fdb3af16677eba9d693 [2/3] KVM: arm64: Filter out the case of only changing permissions from stage-2 map path commit: 694d071f8d85d504055540a27f0dbe9dbf44584e [3/3] KVM: arm64: Mark the page dirty only if the fault is handled successfully commit: 509552e65ae8287178a5cdea2d734dcd2d6380ab Cheers, M.
Hi, This patch series(v3) make some optimization for stage-2 translation. About patch-1: Procedures of hyp stage-1 map and guest stage-2 map are quite different, but they are now tied closely by function kvm_set_valid_leaf_pte(). So adjust the relative code for ease of code maintenance in the future. About patch-2: There have been the separate map handler and perms handler used independently for mapping and relaxing permissions in the new page-table infrastructure for stage-2, yet there is still a specific case where we end up changing the access permissions in the map path, and something unsatisfactory could happen because of current handling for this case. To solve above problem, we can filter out this case from the map path and abort the PTE update. Instead, let the vCPU enter back the guest and it will exit next time to go through the relax_perms path if still needed. About patch-3: We now set the pfn dirty and mark the page dirty before calling fault handlers in user_mem_abort(), so we might end up having spurious dirty pages if update of permissions or mapping has failed. Let's move these two operations after the fault handlers, and they will be done only if the fault has been handled successfully. When an -EAGAIN errno is returned from the map handler, we hope to the vcpu to enter guest directly instead of exiting back to userspace, so adjust the return value at the end of function. --- Changelogs v2->v3: - Rebased on top of v5.11-rc3 - Refine the commit messages - Make some adjustment about return value in patch-2 and patch-3 - v2: https://lore.kernel.org/lkml/20201216122844.25092-1-wangyanan55@huawei.com/ v1->v2: - Make part of the diff a seperate patch (patch-1) - Add Will's Signed-off-by for patch-1 - Return an errno when meeting changing permissions case in map path - Add a new patch (patch-3) - v1: https://lore.kernel.org/lkml/20201211080115.21460-1-wangyanan55@huawei.com/ --- Yanan Wang (3): KVM: arm64: Adjust partial code of hyp stage-1 map and guest stage-2 map KVM: arm64: Filter out the case of only changing permissions from stage-2 map path KVM: arm64: Mark the page dirty only if the fault is handled successfully arch/arm64/include/asm/kvm_pgtable.h | 5 ++ arch/arm64/kvm/hyp/pgtable.c | 83 ++++++++++++++++------------ arch/arm64/kvm/mmu.c | 13 +++-- 3 files changed, 60 insertions(+), 41 deletions(-)