| Message ID | 20210128135627.2067003-1-sw@weilnetz.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/tcg: Replace /bin/true by true (required on macOS) | expand |
On 1/28/21 2:56 PM, Stefan Weil wrote: > /bin/true is missing on macOS, but simply "true" is available as a shell builtin. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > > A similar change might be needed for tests/qemu-iotests. > > Regards, > Stefan > > tests/tcg/Makefile.qemu | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On Thu, 28 Jan 2021 at 13:59, Stefan Weil <sw@weilnetz.de> wrote: > > /bin/true is missing on macOS, but simply "true" is available as a shell builtin. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> It's also in /usr/bin/true if you happen to need a real executable rather than a builtin. Either way we shouldn't be hardcoding the path here. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Stefan Weil <sw@weilnetz.de> writes: > /bin/true is missing on macOS, but simply "true" is available as a shell builtin. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> Queued to testing/next, thanks.
diff --git a/tests/tcg/Makefile.qemu b/tests/tcg/Makefile.qemu index c096c611a2..a56564660c 100644 --- a/tests/tcg/Makefile.qemu +++ b/tests/tcg/Makefile.qemu @@ -90,11 +90,11 @@ run-guest-tests: guest-tests else guest-tests: - $(call quiet-command, /bin/true, "BUILD", \ + $(call quiet-command, true, "BUILD", \ "$(TARGET) guest-tests SKIPPED") run-guest-tests: - $(call quiet-command, /bin/true, "RUN", \ + $(call quiet-command, true, "RUN", \ "tests for $(TARGET) SKIPPED") endif
/bin/true is missing on macOS, but simply "true" is available as a shell builtin. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- A similar change might be needed for tests/qemu-iotests. Regards, Stefan tests/tcg/Makefile.qemu | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)