| Message ID | 20210203063850.15844-1-samirweng1979@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rt2x00: remove duplicate word in comment | expand |
On 2/2/21 10:38 PM, samirweng1979 wrote: > From: wengjianfeng <wengjianfeng@yulong.com> > > remove duplicate word 'we' in comment > > Signed-off-by: wengjianfeng <wengjianfeng@yulong.com> > --- > drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c > index c861811..7158152 100644 > --- a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c > +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c > @@ -179,7 +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb, > * Make room for new data. There are 2 possibilities > * either the alignment is already present between > * the 802.11 header and payload. In that case we > - * we have to move the header less then the iv_len > + * have to move the header less then the iv_len s/then/than/ > * since we can use the already available l2pad bytes > * for the iv data. > * When the alignment must be added manually we must >
On Wed, 3 Feb 2021 07:16:17 -0800 Randy Dunlap <rdunlap@infradead.org> wrote: > On 2/2/21 10:38 PM, samirweng1979 wrote: > > From: wengjianfeng <wengjianfeng@yulong.com> > > > > remove duplicate word 'we' in comment > > > > Signed-off-by: wengjianfeng <wengjianfeng@yulong.com> > > --- > > drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c > > b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index > > c861811..7158152 100644 --- > > a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++ > > b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7 > > +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb, > > * Make room for new data. There are 2 possibilities > > * either the alignment is already present between > > * the 802.11 header and payload. In that case we > > - * we have to move the header less then the iv_len > > + * have to move the header less then the iv_len > > s/then/than/ > > > * since we can use the already available l2pad bytes > > * for the iv data. > > * When the alignment must be added manually we must > > > > Hi Randy, So you means add it for byte alignment, right? if yes,just ignore the patch. thanks.
On 2/3/21 4:30 PM, wengjianfeng wrote: > On Wed, 3 Feb 2021 07:16:17 -0800 > Randy Dunlap <rdunlap@infradead.org> wrote: > >> On 2/2/21 10:38 PM, samirweng1979 wrote: >>> From: wengjianfeng <wengjianfeng@yulong.com> >>> >>> remove duplicate word 'we' in comment >>> >>> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com> >>> --- >>> drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c >>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index >>> c861811..7158152 100644 --- >>> a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++ >>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7 >>> +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb, >>> * Make room for new data. There are 2 possibilities >>> * either the alignment is already present between >>> * the 802.11 header and payload. In that case we >>> - * we have to move the header less then the iv_len >>> + * have to move the header less then the iv_len >> >> s/then/than/ >> >>> * since we can use the already available l2pad bytes >>> * for the iv data. >>> * When the alignment must be added manually we must >>> >> >> > > Hi Randy, > So you means add it for byte alignment, right? if yes,just ignore > the patch. thanks. No, I mean that there is a typo there also: "then" should be changed to "than" while you are making changes. thanks.
On Wed, 3 Feb 2021 16:33:37 -0800 Randy Dunlap <rdunlap@infradead.org> wrote: > On 2/3/21 4:30 PM, wengjianfeng wrote: > > On Wed, 3 Feb 2021 07:16:17 -0800 > > Randy Dunlap <rdunlap@infradead.org> wrote: > > > >> On 2/2/21 10:38 PM, samirweng1979 wrote: > >>> From: wengjianfeng <wengjianfeng@yulong.com> > >>> > >>> remove duplicate word 'we' in comment > >>> > >>> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com> > >>> --- > >>> drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c > >>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index > >>> c861811..7158152 100644 --- > >>> a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++ > >>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7 > >>> +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb, > >>> * Make room for new data. There are 2 possibilities > >>> * either the alignment is already present between > >>> * the 802.11 header and payload. In that case we > >>> - * we have to move the header less then the iv_len > >>> + * have to move the header less then the iv_len > >> > >> s/then/than/ > >> > >>> * since we can use the already available l2pad bytes > >>> * for the iv data. > >>> * When the alignment must be added manually we must > >>> > >> > >> > > > > Hi Randy, > > So you means add it for byte alignment, right? if yes,just ignore > > the patch. thanks. > > No, I mean that there is a typo there also: "then" should be changed > to "than" while you are making changes. > > thanks. Hi Randy， Ok， I will update the patch，thanks for your reply.
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index c861811..7158152 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7 +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb, * Make room for new data. There are 2 possibilities * either the alignment is already present between * the 802.11 header and payload. In that case we - * we have to move the header less then the iv_len + * have to move the header less then the iv_len * since we can use the already available l2pad bytes * for the iv data. * When the alignment must be added manually we must