diff mbox series

iwlwifi: remove incorrect comment in pnvm

Message ID iwlwifi.20210211223049.40d545a0fa89.I04793aaa5312b926335c8db32131f000432df511@changeid (mailing list archive)
State Accepted
Commit 3304b6f937a3a60bbdfe6d7d4df7de2dfa8545e8
Delegated to: Kalle Valo
Headers show
Series iwlwifi: remove incorrect comment in pnvm | expand

Commit Message

Luca Coelho Feb. 11, 2021, 8:30 p.m. UTC 
From: Luca Coelho <luciano.coelho@intel.com>

We use this driver as a backport that also runs on older kernels (as
part of the backports project).  So we use some checks to backport or
prevent code from compiling in incompatible kernel version.

When I took one of the PNVM patches from the backport, I accidentally
left the comment that a certain part of the code doesn't work in older
kernels.  This obviously should never be valid for the mainline.
Remove this comment.

Reported-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/fw/pnvm.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Kalle Valo Feb. 12, 2021, 6:11 a.m. UTC | #1 
Luca Coelho <luca@coelho.fi> writes:

> From: Luca Coelho <luciano.coelho@intel.com>
>
> We use this driver as a backport that also runs on older kernels (as
> part of the backports project).  So we use some checks to backport or
> prevent code from compiling in incompatible kernel version.
>
> When I took one of the PNVM patches from the backport, I accidentally
> left the comment that a certain part of the code doesn't work in older
> kernels.  This obviously should never be valid for the mainline.
> Remove this comment.
>
> Reported-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

Thanks, I assigned this to myself on patchwork and apply directly to
wireless-drivers-next.
Kalle Valo Feb. 12, 2021, 7:47 a.m. UTC | #2 
Luca Coelho <luca@coelho.fi> wrote:

> From: Luca Coelho <luciano.coelho@intel.com>
> 
> We use this driver as a backport that also runs on older kernels (as
> part of the backports project).  So we use some checks to backport or
> prevent code from compiling in incompatible kernel version.
> 
> When I took one of the PNVM patches from the backport, I accidentally
> left the comment that a certain part of the code doesn't work in older
> kernels.  This obviously should never be valid for the mainline.
> Remove this comment.
> 
> Reported-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

Patch applied to wireless-drivers-next.git, thanks.

3304b6f937a3 iwlwifi: remove incorrect comment in pnvm
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
index 2cd07d2690e0..fd070ca5e517 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.c
@@ -220,11 +220,6 @@  static int iwl_pnvm_parse(struct iwl_trans *trans, const u8 *data,
 	return -ENOENT;
 }
 
-/*
- * This is known to be broken on v4.19 and to work on v5.4.  Until we
- * figure out why this is the case and how to make it work, simply
- * disable the feature in old kernels.
- */
 #if defined(CONFIG_EFI)
 
 #define IWL_EFI_VAR_GUID EFI_GUID(0x92daaf2f, 0xc02b, 0x455b,	\