diff mbox series

module: remove duplicate include in ./arch/arm/include/asm/pgtable.h

Message ID 20210303020422.174818-1-zhang.yunkai@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series module: remove duplicate include in ./arch/arm/include/asm/pgtable.h | expand

Commit Message

Menglong Dong March 3, 2021, 2:04 a.m. UTC 
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>

'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated.

Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 arch/arm/include/asm/pgtable.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Russell King (Oracle) March 3, 2021, 10:24 a.m. UTC | #1 
On Tue, Mar 02, 2021 at 06:04:22PM -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> 
> 'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated.
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>

I don't see this change has anything to do with module code, so what is
the reason for "module:" in the subject line? What am I missing here?

I also think that this patch needs a better explanation, since it's not
a removal of a redundant include, whereas your other similarly described
changes are.
diff mbox series

Patch

diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h
index c02f24400369..f3124e57be83 100644
--- a/arch/arm/include/asm/pgtable.h
+++ b/arch/arm/include/asm/pgtable.h
@@ -9,15 +9,14 @@ 
 
 #include <linux/const.h>
 #include <asm/proc-fns.h>
+#include <asm-generic/pgtable-nopud.h>
 
 #ifndef CONFIG_MMU
 
-#include <asm-generic/pgtable-nopud.h>
 #include <asm/pgtable-nommu.h>
 
 #else
 
-#include <asm-generic/pgtable-nopud.h>
 #include <asm/memory.h>
 #include <asm/pgtable-hwdef.h>