| Message ID | 161472735969.3478298.17752955323122832118.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fstests: various fixes | expand |
On 03 Mar 2021 at 04:52, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > This test is designed to fail an mmap write and see what happens. > Typically this is a segmentation fault. If the user's computer is > configured to capture core dumps, this will cause the test to fail, even > though we got the reaction we wanted. > Looks good to me. Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com> > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > tests/generic/623 | 1 + > 1 file changed, 1 insertion(+) > > > diff --git a/tests/generic/623 b/tests/generic/623 > index 7be38955..04411405 100755 > --- a/tests/generic/623 > +++ b/tests/generic/623 > @@ -37,6 +37,7 @@ _scratch_mount > # status on the page. > file=$SCRATCH_MNT/file > $XFS_IO_PROG -fc "pwrite 0 4k" -c fsync $file | _filter_xfs_io > +ulimit -c 0 > $XFS_IO_PROG -x -c "mmap 0 4k" -c "mwrite 0 4k" -c shutdown -c fsync \ > -c "mwrite 0 4k" $file | _filter_xfs_io >
On Tue, Mar 02, 2021 at 03:22:39PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > This test is designed to fail an mmap write and see what happens. > Typically this is a segmentation fault. If the user's computer is > configured to capture core dumps, this will cause the test to fail, even > though we got the reaction we wanted. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/tests/generic/623 b/tests/generic/623 index 7be38955..04411405 100755 --- a/tests/generic/623 +++ b/tests/generic/623 @@ -37,6 +37,7 @@ _scratch_mount # status on the page. file=$SCRATCH_MNT/file $XFS_IO_PROG -fc "pwrite 0 4k" -c fsync $file | _filter_xfs_io +ulimit -c 0 $XFS_IO_PROG -x -c "mmap 0 4k" -c "mwrite 0 4k" -c shutdown -c fsync \ -c "mwrite 0 4k" $file | _filter_xfs_io