diff mbox series

[v2] arm64: defconfig: Use DEBUG_INFO_REDUCED

Message ID 20210304174407.17537-1-broonie@kernel.org (mailing list archive)
State New, archived
Headers show
Series [v2] arm64: defconfig: Use DEBUG_INFO_REDUCED | expand

Commit Message

Mark Brown March 4, 2021, 5:44 p.m. UTC
We've had DEBUG_INFO enabled for arm64 defconfigs since the initial
commit.  This is probably not that frequently used but substantially
inflates the size of the build tree and amount of I/O needed during the
build.  This was causing issues with storage usage in some automated CI
environments which don't expect defconfigs to be quite this big, and
generally increases the resource consumption for both them and people
doing local builds.  The main use case for the debug info is decoding
things with scripts/faddr2line but that doesn't need the full
DEBUG_INFO, DEBUG_INFO_REDUCED is enough for it, so enable that by
default.

Without this patch my build tree is 6.8G, with it the size drops to 2G
(smaller than the 6.4G for allmodconfig!).

Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
Reported-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Acked-by: Kevin Hilman <khilman@baylibre.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Will Deacon March 4, 2021, 6:30 p.m. UTC | #1
On Thu, Mar 04, 2021 at 05:44:07PM +0000, Mark Brown wrote:
> We've had DEBUG_INFO enabled for arm64 defconfigs since the initial
> commit.  This is probably not that frequently used but substantially
> inflates the size of the build tree and amount of I/O needed during the
> build.  This was causing issues with storage usage in some automated CI
> environments which don't expect defconfigs to be quite this big, and
> generally increases the resource consumption for both them and people
> doing local builds.  The main use case for the debug info is decoding
> things with scripts/faddr2line but that doesn't need the full
> DEBUG_INFO, DEBUG_INFO_REDUCED is enough for it, so enable that by
> default.
> 
> Without this patch my build tree is 6.8G, with it the size drops to 2G
> (smaller than the 6.4G for allmodconfig!).
> 
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> Reported-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..8793a9cb9d4b 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1156,6 +1156,7 @@ CONFIG_CRYPTO_DEV_HISI_TRNG=m
>  CONFIG_CMA_SIZE_MBYTES=32
>  CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_INFO=y
> +CONFIG_DEBUG_INFO_REDUCED=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_DEBUG_KERNEL=y

I gave this a spin with clang and it looks alright! Are you targetting 5.12
with this or can it wait until 5.13? I can't tell how big a deal it is on
the CI side of things.

Will
Mark Brown March 4, 2021, 6:33 p.m. UTC | #2
On Thu, Mar 04, 2021 at 06:30:34PM +0000, Will Deacon wrote:

> I gave this a spin with clang and it looks alright! Are you targetting 5.12
> with this or can it wait until 5.13? I can't tell how big a deal it is on
> the CI side of things.

v5.13 should be fine, it's more annoying for CI users than anything else
I think - KernelCI certainly dealt with it already.
Will Deacon March 4, 2021, 6:49 p.m. UTC | #3
On Thu, Mar 04, 2021 at 06:33:26PM +0000, Mark Brown wrote:
> On Thu, Mar 04, 2021 at 06:30:34PM +0000, Will Deacon wrote:
> 
> > I gave this a spin with clang and it looks alright! Are you targetting 5.12
> > with this or can it wait until 5.13? I can't tell how big a deal it is on
> > the CI side of things.
> 
> v5.13 should be fine, it's more annoying for CI users than anything else
> I think - KernelCI certainly dealt with it already.

Ok, in which case:

Acked-by: Will Deacon <will@kernel.org>

and I'll leave it to Catalin.

Will
Catalin Marinas March 15, 2021, 7:13 p.m. UTC | #4
On Thu, 4 Mar 2021 17:44:07 +0000, Mark Brown wrote:
> We've had DEBUG_INFO enabled for arm64 defconfigs since the initial
> commit.  This is probably not that frequently used but substantially
> inflates the size of the build tree and amount of I/O needed during the
> build.  This was causing issues with storage usage in some automated CI
> environments which don't expect defconfigs to be quite this big, and
> generally increases the resource consumption for both them and people
> doing local builds.  The main use case for the debug info is decoding
> things with scripts/faddr2line but that doesn't need the full
> DEBUG_INFO, DEBUG_INFO_REDUCED is enough for it, so enable that by
> default.
> 
> [...]

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: defconfig: Use DEBUG_INFO_REDUCED
      https://git.kernel.org/arm64/c/ed938a4bfc58
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..8793a9cb9d4b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1156,6 +1156,7 @@  CONFIG_CRYPTO_DEV_HISI_TRNG=m
 CONFIG_CMA_SIZE_MBYTES=32
 CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_INFO_REDUCED=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 CONFIG_DEBUG_KERNEL=y