| Message ID | 20210306135317.17803-1-baijiaju1990@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Leon Romanovsky |
| Headers | show |
| Series | infiniband: hw: cxgb4: fix error return code of pass_open_rpl() | expand |
On Sat, Mar 06, 2021 at 05:53:17AM -0800, Jia-Ju Bai wrote: > When ep is NULL, no error code of pass_open_rpl() is returned. > To fix this bug, pass_open_rpl() returns -EINVAL in this case. Why do you think that this is an error? > > Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 8769e7aa097f..773d3805bb25 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -2382,7 +2382,7 @@ static int pass_open_rpl(struct c4iw_dev *dev, struct sk_buff *skb) > > if (!ep) { > pr_warn("%s stid %d lookup failure!\n", __func__, stid); > - goto out; > + return -EINVAL; > } > pr_debug("ep %p status %d error %d\n", ep, > rpl->status, status2errno(rpl->status)); > -- > 2.17.1 >
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 8769e7aa097f..773d3805bb25 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -2382,7 +2382,7 @@ static int pass_open_rpl(struct c4iw_dev *dev, struct sk_buff *skb) if (!ep) { pr_warn("%s stid %d lookup failure!\n", __func__, stid); - goto out; + return -EINVAL; } pr_debug("ep %p status %d error %d\n", ep, rpl->status, status2errno(rpl->status));
When ep is NULL, no error code of pass_open_rpl() is returned. To fix this bug, pass_open_rpl() returns -EINVAL in this case. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)