diff mbox series

dt-bindings: serial: stm32: add examples

Message ID 20210209095948.15889-1-valentin.caron@foss.st.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: serial: stm32: add examples | expand

Commit Message

Valentin Caron Feb. 9, 2021, 9:59 a.m. UTC
From: Valentin Caron <valentin.caron@st.com>

Add examples to show more use cases :
 - uart2 with hardware flow control
 - uart4 without flow control

Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
---
 .../bindings/serial/st,stm32-uart.yaml        | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Rob Herring (Arm) March 5, 2021, 6:53 p.m. UTC | #1
On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
> From: Valentin Caron <valentin.caron@st.com>
> 
> Add examples to show more use cases :
>  - uart2 with hardware flow control
>  - uart4 without flow control

Why do I need these? I can go read your dts files if I need more 
examples.

> 
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
>  .../bindings/serial/st,stm32-uart.yaml        | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> index 06d5f251ec88..3a4aab5d1862 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
> @@ -82,6 +82,26 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/stm32mp1-clks.h>
> +
> +    usart4: serial@40004c00 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004c00 0x400>;
> +      interrupts = <52>;
> +      clocks = <&clk_pclk1>;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart4>;
> +    };
> +
> +    usart2: serial@40004400 {
> +      compatible = "st,stm32-uart";
> +      reg = <0x40004400 0x400>;
> +      interrupts = <38>;
> +      clocks = <&clk_pclk1>;
> +      st,hw-flow-ctrl;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
> +    };
> +
>      usart1: serial@40011000 {
>        compatible = "st,stm32-uart";
>        reg = <0x40011000 0x400>;
> -- 
> 2.17.1
>
Valentin Caron March 10, 2021, 8:41 a.m. UTC | #2
On 3/5/21 7:53 PM, Rob Herring wrote:
> On Tue, Feb 09, 2021 at 10:59:48AM +0100, Valentin Caron wrote:
>> From: Valentin Caron <valentin.caron@st.com>
>>
>> Add examples to show more use cases :
>>   - uart2 with hardware flow control
>>   - uart4 without flow control
> Why do I need these? I can go read your dts files if I need more
> examples.
Hi,

These examples were present in the dt-binding before the convertion to 
json :

https://patchwork.kernel.org/project/linux-arm-kernel/patch/20200122095558.22553-3-benjamin.gaignard@st.com/

Would you like a v2 with this precision ?
However this is not an essential patch, we can just drop it.
>
>> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
>> ---
>>   .../bindings/serial/st,stm32-uart.yaml        | 20 +++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> index 06d5f251ec88..3a4aab5d1862 100644
>> --- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
>> @@ -82,6 +82,26 @@ additionalProperties: false
>>   examples:
>>     - |
>>       #include <dt-bindings/clock/stm32mp1-clks.h>
>> +
>> +    usart4: serial@40004c00 {
>> +      compatible = "st,stm32-uart";
>> +      reg = <0x40004c00 0x400>;
>> +      interrupts = <52>;
>> +      clocks = <&clk_pclk1>;
>> +      pinctrl-names = "default";
>> +      pinctrl-0 = <&pinctrl_usart4>;
>> +    };
>> +
>> +    usart2: serial@40004400 {
>> +      compatible = "st,stm32-uart";
>> +      reg = <0x40004400 0x400>;
>> +      interrupts = <38>;
>> +      clocks = <&clk_pclk1>;
>> +      st,hw-flow-ctrl;
>> +      pinctrl-names = "default";
>> +      pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
>> +    };
>> +
>>       usart1: serial@40011000 {
>>         compatible = "st,stm32-uart";
>>         reg = <0x40011000 0x400>;
>> -- 
>> 2.17.1
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 06d5f251ec88..3a4aab5d1862 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -82,6 +82,26 @@  additionalProperties: false
 examples:
   - |
     #include <dt-bindings/clock/stm32mp1-clks.h>
+
+    usart4: serial@40004c00 {
+      compatible = "st,stm32-uart";
+      reg = <0x40004c00 0x400>;
+      interrupts = <52>;
+      clocks = <&clk_pclk1>;
+      pinctrl-names = "default";
+      pinctrl-0 = <&pinctrl_usart4>;
+    };
+
+    usart2: serial@40004400 {
+      compatible = "st,stm32-uart";
+      reg = <0x40004400 0x400>;
+      interrupts = <38>;
+      clocks = <&clk_pclk1>;
+      st,hw-flow-ctrl;
+      pinctrl-names = "default";
+      pinctrl-0 = <&pinctrl_usart2 &pinctrl_usart2_rtscts>;
+    };
+
     usart1: serial@40011000 {
       compatible = "st,stm32-uart";
       reg = <0x40011000 0x400>;