mbox series

[0/4] btrfs: Convert more kmaps to kmap_local_page()

Message ID 20210217024826.3466046-1-ira.weiny@intel.com (mailing list archive)
Headers show
Series btrfs: Convert more kmaps to kmap_local_page() | expand

Message

Ira Weiny Feb. 17, 2021, 2:48 a.m. UTC
From: Ira Weiny <ira.weiny@intel.com>

I am submitting these for 5.13.

Further work to remove more kmap() calls in favor of the kmap_local_page() this
series converts those calls which required more than a common pattern which
were covered in my previous series[1].  This is the second of what I hope to be
3 series to fully convert btrfs.  However, the 3rd series is going to be an RFC
because I need to have more eyes on it before I'm sure about what to do.  For
now this series should be good to go for 5.13.

Also this series converts the kmaps in the raid5/6 code which required a fix to
the kmap'ings which was submitted in [2].

Thanks,
Ira

[1] https://lore.kernel.org/lkml/20210210062221.3023586-1-ira.weiny@intel.com/
[2] https://lore.kernel.org/lkml/20210205163943.GD5033@iweiny-DESK2.sc.intel.com/


Ira Weiny (4):
  fs/btrfs: Convert kmap to kmap_local_page() using coccinelle
  fs/btrfs: Convert raid5/6 kmaps to kmap_local_page()
  fs/btrfs: Use kmap_local_page() in __btrfsic_submit_bio()
  fs/btrfs: Convert block context kmap's to kmap_local_page()

 fs/btrfs/check-integrity.c | 12 ++++----
 fs/btrfs/compression.c     |  4 +--
 fs/btrfs/inode.c           |  4 +--
 fs/btrfs/lzo.c             |  9 +++---
 fs/btrfs/raid56.c          | 61 +++++++++++++++++++-------------------
 5 files changed, 44 insertions(+), 46 deletions(-)

Comments

Ira Weiny March 11, 2021, 9:30 p.m. UTC | #1
On Tue, Feb 16, 2021 at 06:48:22PM -0800, 'Ira Weiny' wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> I am submitting these for 5.13.

Just a friendly ping on this set.

Ira

> 
> Further work to remove more kmap() calls in favor of the kmap_local_page() this
> series converts those calls which required more than a common pattern which
> were covered in my previous series[1].  This is the second of what I hope to be
> 3 series to fully convert btrfs.  However, the 3rd series is going to be an RFC
> because I need to have more eyes on it before I'm sure about what to do.  For
> now this series should be good to go for 5.13.
> 
> Also this series converts the kmaps in the raid5/6 code which required a fix to
> the kmap'ings which was submitted in [2].
> 
> Thanks,
> Ira
> 
> [1] https://lore.kernel.org/lkml/20210210062221.3023586-1-ira.weiny@intel.com/
> [2] https://lore.kernel.org/lkml/20210205163943.GD5033@iweiny-DESK2.sc.intel.com/
> 
> 
> Ira Weiny (4):
>   fs/btrfs: Convert kmap to kmap_local_page() using coccinelle
>   fs/btrfs: Convert raid5/6 kmaps to kmap_local_page()
>   fs/btrfs: Use kmap_local_page() in __btrfsic_submit_bio()
>   fs/btrfs: Convert block context kmap's to kmap_local_page()
> 
>  fs/btrfs/check-integrity.c | 12 ++++----
>  fs/btrfs/compression.c     |  4 +--
>  fs/btrfs/inode.c           |  4 +--
>  fs/btrfs/lzo.c             |  9 +++---
>  fs/btrfs/raid56.c          | 61 +++++++++++++++++++-------------------
>  5 files changed, 44 insertions(+), 46 deletions(-)
> 
> -- 
> 2.28.0.rc0.12.gb6a658bd00c9
>
David Sterba March 12, 2021, 7:41 p.m. UTC | #2
On Tue, Feb 16, 2021 at 06:48:22PM -0800, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> I am submitting these for 5.13.
> 
> Further work to remove more kmap() calls in favor of the kmap_local_page() this
> series converts those calls which required more than a common pattern which
> were covered in my previous series[1].  This is the second of what I hope to be
> 3 series to fully convert btrfs.  However, the 3rd series is going to be an RFC
> because I need to have more eyes on it before I'm sure about what to do.  For
> now this series should be good to go for 5.13.
> 
> Also this series converts the kmaps in the raid5/6 code which required a fix to
> the kmap'ings which was submitted in [2].

Branch added to for-next and will be moved to the devel queue next week.
I've added some comments about the ordering requirement, that's
something not obvious. There's a comment under 1st patch but that's
trivial to fix if needed. Thanks.
Ira Weiny March 12, 2021, 8:05 p.m. UTC | #3
On Fri, Mar 12, 2021 at 08:41:41PM +0100, David Sterba wrote:
> On Tue, Feb 16, 2021 at 06:48:22PM -0800, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > I am submitting these for 5.13.
> > 
> > Further work to remove more kmap() calls in favor of the kmap_local_page() this
> > series converts those calls which required more than a common pattern which
> > were covered in my previous series[1].  This is the second of what I hope to be
> > 3 series to fully convert btrfs.  However, the 3rd series is going to be an RFC
> > because I need to have more eyes on it before I'm sure about what to do.  For
> > now this series should be good to go for 5.13.
> > 
> > Also this series converts the kmaps in the raid5/6 code which required a fix to
> > the kmap'ings which was submitted in [2].
> 
> Branch added to for-next and will be moved to the devel queue next week.
> I've added some comments about the ordering requirement, that's
> something not obvious. There's a comment under 1st patch but that's
> trivial to fix if needed. Thanks.

I've replied to the first patch.  LMK if you want me to respin it.

Thanks!
Ira
David Sterba March 16, 2021, 11:07 a.m. UTC | #4
On Fri, Mar 12, 2021 at 12:05:00PM -0800, Ira Weiny wrote:
> On Fri, Mar 12, 2021 at 08:41:41PM +0100, David Sterba wrote:
> > On Tue, Feb 16, 2021 at 06:48:22PM -0800, ira.weiny@intel.com wrote:
> > > From: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > I am submitting these for 5.13.
> > > 
> > > Further work to remove more kmap() calls in favor of the kmap_local_page() this
> > > series converts those calls which required more than a common pattern which
> > > were covered in my previous series[1].  This is the second of what I hope to be
> > > 3 series to fully convert btrfs.  However, the 3rd series is going to be an RFC
> > > because I need to have more eyes on it before I'm sure about what to do.  For
> > > now this series should be good to go for 5.13.
> > > 
> > > Also this series converts the kmaps in the raid5/6 code which required a fix to
> > > the kmap'ings which was submitted in [2].
> > 
> > Branch added to for-next and will be moved to the devel queue next week.
> > I've added some comments about the ordering requirement, that's
> > something not obvious. There's a comment under 1st patch but that's
> > trivial to fix if needed. Thanks.
> 
> I've replied to the first patch.  LMK if you want me to respin it.

No need to respin, patchset now in misc-next. Thanks.
Ira Weiny March 16, 2021, 4:56 p.m. UTC | #5
On Tue, Mar 16, 2021 at 12:07:24PM +0100, David Sterba wrote:
> On Fri, Mar 12, 2021 at 12:05:00PM -0800, Ira Weiny wrote:
> > On Fri, Mar 12, 2021 at 08:41:41PM +0100, David Sterba wrote:
> > > On Tue, Feb 16, 2021 at 06:48:22PM -0800, ira.weiny@intel.com wrote:
> > > > From: Ira Weiny <ira.weiny@intel.com>
> > > > 
> > > > I am submitting these for 5.13.
> > > > 
> > > > Further work to remove more kmap() calls in favor of the kmap_local_page() this
> > > > series converts those calls which required more than a common pattern which
> > > > were covered in my previous series[1].  This is the second of what I hope to be
> > > > 3 series to fully convert btrfs.  However, the 3rd series is going to be an RFC
> > > > because I need to have more eyes on it before I'm sure about what to do.  For
> > > > now this series should be good to go for 5.13.
> > > > 
> > > > Also this series converts the kmaps in the raid5/6 code which required a fix to
> > > > the kmap'ings which was submitted in [2].
> > > 
> > > Branch added to for-next and will be moved to the devel queue next week.
> > > I've added some comments about the ordering requirement, that's
> > > something not obvious. There's a comment under 1st patch but that's
> > > trivial to fix if needed. Thanks.
> > 
> > I've replied to the first patch.  LMK if you want me to respin it.
> 
> No need to respin, patchset now in misc-next. Thanks.

Sweet!  Thanks!
Ira