diff mbox series

[v2,1/2] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings

Message ID 20210308185940.2560917-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] ARM: dts: imx6dl-plybas: Fix gpio-keys W=1 warnings | expand

Commit Message

Fabio Estevam March 8, 2021, 6:59 p.m. UTC 
Remove the unnecessary #address-cells/#size-cells and rename the node
names to fix the following W=1 dtc warnings:

arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Changes since v1:
- Use button-xxx for the node names (Shawn)

 arch/arm/boot/dts/imx6dl-plybas.dts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Shawn Guo March 15, 2021, 6:18 a.m. UTC | #1 
On Mon, Mar 08, 2021 at 03:59:39PM -0300, Fabio Estevam wrote:
> Remove the unnecessary #address-cells/#size-cells and rename the node
> names to fix the following W=1 dtc warnings:
> 
> arch/arm/boot/dts/imx6dl-plybas.dts:26.13-30.5: Warning (unit_address_vs_reg): /gpio_keys/button@20: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:32.13-36.5: Warning (unit_address_vs_reg): /gpio_keys/button@21: node has a unit name, but no reg or ranges property
> arch/arm/boot/dts/imx6dl-plybas.dts:20.12-37.4: Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>

Applied both, thanks.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6dl-plybas.dts b/arch/arm/boot/dts/imx6dl-plybas.dts
index 333c306aa946..bf72a67a9c76 100644
--- a/arch/arm/boot/dts/imx6dl-plybas.dts
+++ b/arch/arm/boot/dts/imx6dl-plybas.dts
@@ -19,17 +19,15 @@  chosen {
 
 	gpio_keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 		autorepeat;
 
-		button@20 {
+		button-start {
 			label = "START";
 			linux,code = <31>;
 			gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
 		};
 
-		button@21 {
+		button-clean {
 			label = "CLEAN";
 			linux,code = <46>;
 			gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;