| Message ID | 20210310184458.10741-1-bostroesser@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 471ee95ccca9c417344453f73a39681cfde39af1 |
| Headers | show |
| Series | scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release | expand |
Bodo, > In patch "scsi: target: tcmu: Replace radix_tree with XArray" meaning > of last parameter of tcmu_blocks_release was changed. So in the > callers we should subtract 1 from the previous parameter. Applied to 5.13/scsi-staging, thanks!
On Wed, 10 Mar 2021 19:44:58 +0100, Bodo Stroesser wrote: > In patch > "scsi: target: tcmu: Replace radix_tree with XArray" > meaning of last parameter of tcmu_blocks_release was changed. > So in the callers we should subtract 1 from the previous > parameter. > > Unfortunately that change got lost at one of the two places > where tcmu_blocks_release is called. That does not lead to any > problems, but we should adjust it anyway. Applied to 5.13/scsi-queue, thanks! [1/1] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release https://git.kernel.org/mkp/scsi/c/471ee95ccca9
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 9e1b115cb032..bdfc057f000c 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1658,7 +1658,7 @@ static void tcmu_dev_kref_release(struct kref *kref) xa_destroy(&udev->commands); WARN_ON(!all_expired); - tcmu_blocks_release(&udev->data_blocks, 0, udev->dbi_max + 1); + tcmu_blocks_release(&udev->data_blocks, 0, udev->dbi_max); bitmap_free(udev->data_bitmap); mutex_unlock(&udev->cmdr_lock);
In patch "scsi: target: tcmu: Replace radix_tree with XArray" meaning of last parameter of tcmu_blocks_release was changed. So in the callers we should subtract 1 from the previous parameter. Unfortunately that change got lost at one of the two places where tcmu_blocks_release is called. That does not lead to any problems, but we should adjust it anyway. Signed-off-by: Bodo Stroesser <bostroesser@gmail.com> --- drivers/target/target_core_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)