diff mbox series

[9/9] xfs/305: make sure that fsstress is still running when we quotaoff

Message ID 161836232608.2754991.16417283237743979525.stgit@magnolia (mailing list archive)
State Accepted
Headers show
Series fstests: random fixes | expand

Commit Message

Darrick J. Wong April 14, 2021, 1:05 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Greatly increase the number of fs ops that fsstress is supposed to run
in in this test so that we can ensure that it's still running when the
quotaoff gets run.  1000 might have been sufficient in 2013, but it
isn't now.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/305 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig April 14, 2021, 6:21 a.m. UTC | #1 
On Tue, Apr 13, 2021 at 06:05:26PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Greatly increase the number of fs ops that fsstress is supposed to run
> in in this test so that we can ensure that it's still running when the
> quotaoff gets run.  1000 might have been sufficient in 2013, but it
> isn't now.

How long does this now run?
Darrick J. Wong April 14, 2021, 2:38 p.m. UTC | #2 
On Wed, Apr 14, 2021 at 07:21:35AM +0100, Christoph Hellwig wrote:
> On Tue, Apr 13, 2021 at 06:05:26PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Greatly increase the number of fs ops that fsstress is supposed to run
> > in in this test so that we can ensure that it's still running when the
> > quotaoff gets run.  1000 might have been sufficient in 2013, but it
> > isn't now.
> 
> How long does this now run?

The same amount of time (~15s per _exercise) as before -- we start
fsstress in the background, wait 10 seconds, run quotaoff, wait 5 more
seconds, and then kill the fsstress process.  Bumping nrops to 1 million
gives fsstress enough work to do that it probably won't exit on its own
before the quotaoff completes.

FWIW the fastest storage I have can run about ~100000 fsstress ops per
minute, so I figured that 1 million ought to do for now.

--D
Christoph Hellwig April 20, 2021, 6:21 a.m. UTC | #3 
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/305 b/tests/xfs/305
index fdb48a1d..9a3f0e03 100755
--- a/tests/xfs/305
+++ b/tests/xfs/305
@@ -50,7 +50,7 @@  _exercise()
 	_qmount
 	mkdir -p $QUOTA_DIR
 
-	$FSSTRESS_PROG -d $QUOTA_DIR -n 1000 -p 100 $FSSTRESS_AVOID >/dev/null 2>&1 &
+	$FSSTRESS_PROG -d $QUOTA_DIR -n 1000000 -p 100 $FSSTRESS_AVOID >/dev/null 2>&1 &
 	sleep 10
 	xfs_quota -x -c "off -$type" $SCRATCH_DEV
 	sleep 5