| Message ID | 20210419093852.14978-11-gabriel.fernandez@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce STM32MP1 RCC in secured mode | expand |
On Mon, 19 Apr 2021 11:38:51 +0200, gabriel.fernandez@foss.st.com wrote: > From: Gabriel Fernandez <gabriel.fernandez@foss.st.com> > > Introduce new compatible string "st,stm32mp1-rcc-secure" for > stm32mp1 clock driver when the device is configured with RCC > security support hardened. > > Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com> > --- > .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On 4/19/21 11:38 AM, gabriel.fernandez@foss.st.com wrote: > From: Gabriel Fernandez <gabriel.fernandez@foss.st.com> > > Introduce new compatible string "st,stm32mp1-rcc-secure" for > stm32mp1 clock driver when the device is configured with RCC > security support hardened. > > Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com> > --- > .../devicetree/bindings/clock/st,stm32mp1-rcc.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml > index 4e385508f516..8b1ecb2ecdd5 100644 > --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml > +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml > @@ -54,7 +54,9 @@ properties: > > compatible: > items: > - - const: st,stm32mp1-rcc > + - enum: > + - st,stm32mp1-rcc-secure > + - st,stm32mp1-rcc It is still the same IP and same SoC silicon, so shouldn't the configuration be discerned via DT property instead of compatible string ?
diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml index 4e385508f516..8b1ecb2ecdd5 100644 --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml @@ -54,7 +54,9 @@ properties: compatible: items: - - const: st,stm32mp1-rcc + - enum: + - st,stm32mp1-rcc-secure + - st,stm32mp1-rcc - const: syscon reg: @@ -71,7 +73,7 @@ additionalProperties: false examples: - | rcc: rcc@50000000 { - compatible = "st,stm32mp1-rcc", "syscon"; + compatible = "st,stm32mp1-rcc-secure", "syscon"; reg = <0x50000000 0x1000>; #clock-cells = <1>; #reset-cells = <1>;