| Message ID | 20210407160921.GA1504294@LEGION (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media/meson: remove redundant dev_err call | expand |
On 07/04/2021 18:09, Muhammad Usama Anjum wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. > > Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com> > --- > drivers/staging/media/meson/vdec/vdec.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 5d4db7a5b4b5..e51d69c4729d 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > core->dos_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->dos_base)) { > - dev_err(dev, "Couldn't remap DOS memory\n"); > + if (IS_ERR(core->dos_base)) > return PTR_ERR(core->dos_base); > - } > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > core->esparser_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->esparser_base)) { > - dev_err(dev, "Couldn't remap ESPARSER memory\n"); > + if (IS_ERR(core->esparser_base)) > return PTR_ERR(core->esparser_base); > - } > > core->regmap_ao = > syscon_regmap_lookup_by_phandle(dev->of_node, > Acked-by: Neil Armstrong <narmstrong@baylibre.com>
diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index 5d4db7a5b4b5..e51d69c4729d 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); core->dos_base = devm_ioremap_resource(dev, r); - if (IS_ERR(core->dos_base)) { - dev_err(dev, "Couldn't remap DOS memory\n"); + if (IS_ERR(core->dos_base)) return PTR_ERR(core->dos_base); - } r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); core->esparser_base = devm_ioremap_resource(dev, r); - if (IS_ERR(core->esparser_base)) { - dev_err(dev, "Couldn't remap ESPARSER memory\n"); + if (IS_ERR(core->esparser_base)) return PTR_ERR(core->esparser_base); - } core->regmap_ao = syscon_regmap_lookup_by_phandle(dev->of_node,
devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message. Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com> --- drivers/staging/media/meson/vdec/vdec.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)