| Message ID | 1619692940-104771-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | IB/qib: Remove redundant assignment to ret | expand |
On Thu, Apr 29, 2021 at 06:42:20PM +0800, Yang Li wrote: > Variable 'ret' is set to zero but this value is never read as it is > overwritten with a new value later on, hence it is a redundant > assignment and can be removed > > Clean up the following clang-analyzer warning: > > drivers/infiniband/hw/qib/qib_sd7220.c:690:2: warning: Value stored to > 'ret' is never read [clang-analyzer-deadcode.DeadStores] > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/infiniband/hw/qib/qib_sd7220.c | 1 - > 1 file changed, 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/qib/qib_sd7220.c b/drivers/infiniband/hw/qib/qib_sd7220.c index 4f4a09c..81b810d 100644 --- a/drivers/infiniband/hw/qib/qib_sd7220.c +++ b/drivers/infiniband/hw/qib/qib_sd7220.c @@ -687,7 +687,6 @@ static int qib_sd7220_reg_mod(struct qib_devdata *dd, int sdnum, u32 loc, spin_unlock_irqrestore(&dd->cspec->sdepb_lock, flags); return -1; } - ret = 0; for (tries = EPB_TRANS_TRIES; tries; --tries) { transval = qib_read_kreg32(dd, trans); if (transval & EPB_TRANS_RDY)
Variable 'ret' is set to zero but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed Clean up the following clang-analyzer warning: drivers/infiniband/hw/qib/qib_sd7220.c:690:2: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores] Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/infiniband/hw/qib/qib_sd7220.c | 1 - 1 file changed, 1 deletion(-)