diff mbox series

dmaengine: pl330: fix wrong usage of spinlock flags in dma_cyclc

Message ID 20210507063647.111209-1-chanho61.park@samsung.com (mailing list archive)
State Accepted
Commit 4ad5dd2d7876d79507a20f026507d1a93b8fff10
Headers show
Series dmaengine: pl330: fix wrong usage of spinlock flags in dma_cyclc | expand

Commit Message

Chanho Park May 7, 2021, 6:36 a.m. UTC 
From: Bumyong Lee <bumyong.lee@samsung.com>

flags varible which is the input parameter of pl330_prep_dma_cyclic()
should not be used by spinlock_irq[save/restore] function.

Signed-off-by: Jongho Park <jongho7.park@samsung.com>
Signed-off-by: Bumyong Lee <bumyong.lee@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
 drivers/dma/pl330.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Vinod Koul May 10, 2021, 4:09 p.m. UTC | #1 
On 07-05-21, 15:36, Chanho Park wrote:
> From: Bumyong Lee <bumyong.lee@samsung.com>
> 
> flags varible which is the input parameter of pl330_prep_dma_cyclic()
> should not be used by spinlock_irq[save/restore] function.

It should mention Fixes. I have added that and cced stable

Thanks
diff mbox series

Patch

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index fd8d2bc3be9f..110de8a60058 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2694,13 +2694,15 @@  static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
 	for (i = 0; i < len / period_len; i++) {
 		desc = pl330_get_desc(pch);
 		if (!desc) {
+			unsigned long iflags;
+
 			dev_err(pch->dmac->ddma.dev, "%s:%d Unable to fetch desc\n",
 				__func__, __LINE__);
 
 			if (!first)
 				return NULL;
 
-			spin_lock_irqsave(&pl330->pool_lock, flags);
+			spin_lock_irqsave(&pl330->pool_lock, iflags);
 
 			while (!list_empty(&first->node)) {
 				desc = list_entry(first->node.next,
@@ -2710,7 +2712,7 @@  static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
 
 			list_move_tail(&first->node, &pl330->desc_pool);
 
-			spin_unlock_irqrestore(&pl330->pool_lock, flags);
+			spin_unlock_irqrestore(&pl330->pool_lock, iflags);
 
 			return NULL;
 		}